You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by "sergeyuttsel (via GitHub)" <gi...@apache.org> on 2023/05/22 07:48:42 UTC

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2030: IGNITE-19177 Add assignments checks when building indexes

sergeyuttsel commented on code in PR #2030:
URL: https://github.com/apache/ignite-3/pull/2030#discussion_r1200097549


##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -382,8 +382,17 @@ public boolean stopReplica(ReplicationGroupId replicaGrpId) throws NodeStoppingE
      * @param replicaGrpId Replication group id.
      * @return True if the replica is found and closed, false otherwise.
      */
+    // TODO: IGNITE-19494 We need to correctly stop the replica

Review Comment:
   I have no objections. I agree that we should complete the future exceptionally in order to interrupt replica await process in ReplicaService#sendToReplica.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org