You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2026/07/15 16:26:40 UTC
[PR] Add regression test for unsatisfiable map-key predicates collapsing the scan to empty Values [pinot]
yashmayya opened a new pull request, #18995:
URL: https://github.com/apache/pinot/pull/18995
On Calcite 1.40, a multistage query with mutually exclusive predicates on the same map key (e.g. `WHERE (attributes['k'] = 'a' OR attributes['k'] = 'b') AND attributes['k'] = 'c'`) failed at runtime with `Unsupported function: ITEM`. The contradictory predicates were only reduced to `false` in the post-logical phase (`FILTER_REDUCE_EXPRESSIONS`), after the prune rules had already run, so the plan retained a `LogicalProject` with `ITEM` calls on top of empty `LogicalValues` — and intermediate stage projections can't evaluate `ITEM`.
The Calcite 1.42 upgrade (#18658) fixed this: the filter is now simplified early enough for `PruneEmptyProject` to remove the projection over the empty `Values`, so the query correctly returns an empty result. Verified by running this new test at the commit before #18658 (the MSE variant fails with `Unsupported function: ITEM`) and after it (passes).
This adds regression coverage for the scenario in `MapFieldTypeTest`, on both query engines: OR + EQ, IN + EQ, an int map variant, and an unsatisfiable filter under a group-by over map subscripts. All variants assert an empty result with no exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add regression test for unsatisfiable map-key predicates collapsing the scan to empty Values [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya merged PR #18995:
URL: https://github.com/apache/pinot/pull/18995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add regression test for unsatisfiable map-key predicates collapsing the scan to empty Values [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18995:
URL: https://github.com/apache/pinot/pull/18995#issuecomment-4983532797
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18995?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.86%. Comparing base ([`068b458`](https://app.codecov.io/gh/apache/pinot/commit/068b458883d645ee2c686ab2a5e123ef2ffe8cff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9643cf6`](https://app.codecov.io/gh/apache/pinot/commit/9643cf678a8ffcb4d07f10121a335b27505a35b2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (068b458) and HEAD (9643cf6). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (068b458) | HEAD (9643cf6) |
>|------|------|------|
>|java-21|5|1|
>|unittests|2|1|
>|temurin|5|1|
>|unittests2|1|0|
>|integration|3|0|
>|integration1|1|0|
>|integration2|1|0|
>|custom-integration1|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18995 +/- ##
============================================
- Coverage 65.22% 56.86% -8.37%
+ Complexity 1405 1 -1404
============================================
Files 3418 2622 -796
Lines 214651 155012 -59639
Branches 33922 25272 -8650
============================================
- Hits 140006 88140 -51866
+ Misses 63356 59334 -4022
+ Partials 11289 7538 -3751
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.86% <ø> (-8.37%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.86% <ø> (-8.37%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.86% <ø> (-8.37%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.86% <ø> (-0.01%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/18995?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org