You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/04/20 06:20:17 UTC
Review Request 46424: Windows: Added libprocess to build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46424/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-3103
https://issues.apache.org/jira/browse/MESOS-3103
Repository: mesos
Description
-------
Windows: Added libprocess to build.
Diffs
-----
3rdparty/libprocess/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852
3rdparty/libprocess/src/tests/CMakeLists.txt 9558adf1e45043630b637fa6fb21dc92ec036bd4
3rdparty/libprocess/src/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
3rdparty/libprocess/src/tests/subprocess_tests.cpp 727e940f12643974de4ff2734fba431b285b5de3
Diff: https://reviews.apache.org/r/46424/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46424: Windows: Added libprocess to build.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46424/#review130984
-----------------------------------------------------------
Bad patch!
Reviews applied: [46424, 46794, 46608, 46423, 46422, 46395, 46393]
Failed command: ./support/apply-review.sh -n -r 46424
Error:
2016-04-28 20:11:13 URL:https://reviews.apache.org/r/46424/diff/raw/ [10228/10228] -> "46424.patch" [1]
error: patch failed: 3rdparty/libprocess/src/tests/main.cpp:38
error: 3rdparty/libprocess/src/tests/main.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/12789/console
- Mesos ReviewBot
On April 28, 2016, 5:47 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46424/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 5:47 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-3103
> https://issues.apache.org/jira/browse/MESOS-3103
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added libprocess to build.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852
> 3rdparty/libprocess/src/tests/CMakeLists.txt 9558adf1e45043630b637fa6fb21dc92ec036bd4
> 3rdparty/libprocess/src/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 727e940f12643974de4ff2734fba431b285b5de3
>
> Diff: https://reviews.apache.org/r/46424/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 46424: Windows: Added libprocess to build.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46424/
-----------------------------------------------------------
(Updated April 28, 2016, 5:47 p.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-3103
https://issues.apache.org/jira/browse/MESOS-3103
Repository: mesos
Description
-------
Windows: Added libprocess to build.
Diffs
-----
3rdparty/libprocess/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852
3rdparty/libprocess/src/tests/CMakeLists.txt 9558adf1e45043630b637fa6fb21dc92ec036bd4
3rdparty/libprocess/src/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
3rdparty/libprocess/src/tests/subprocess_tests.cpp 727e940f12643974de4ff2734fba431b285b5de3
Diff: https://reviews.apache.org/r/46424/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46424: Windows: Added libprocess to build.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46424/
-----------------------------------------------------------
(Updated April 23, 2016, 10:30 p.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-3103
https://issues.apache.org/jira/browse/MESOS-3103
Repository: mesos
Description
-------
Windows: Added libprocess to build.
Diffs (updated)
-----
3rdparty/libprocess/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852
3rdparty/libprocess/src/tests/CMakeLists.txt 9558adf1e45043630b637fa6fb21dc92ec036bd4
3rdparty/libprocess/src/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
3rdparty/libprocess/src/tests/subprocess_tests.cpp 727e940f12643974de4ff2734fba431b285b5de3
Diff: https://reviews.apache.org/r/46424/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46424: Windows: Added libprocess to build.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46424/#review129734
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46424]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 20, 2016, 4:20 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46424/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 4:20 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-3103
> https://issues.apache.org/jira/browse/MESOS-3103
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added libprocess to build.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852
> 3rdparty/libprocess/src/tests/CMakeLists.txt 9558adf1e45043630b637fa6fb21dc92ec036bd4
> 3rdparty/libprocess/src/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 727e940f12643974de4ff2734fba431b285b5de3
>
> Diff: https://reviews.apache.org/r/46424/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>