You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "LiZhenNet (GitHub)" <gi...@apache.org> on 2019/01/30 07:49:37 UTC
[GitHub] [incubator-dubbo] LiZhenNet opened pull request #3397: Fix
when qos is disable,log will print every time.
## What is the purpose of the change
Fix when qos is disable,log will print every time where protocol.export() and protocol.refer()
## Brief changelog
Fix when qos is disable,log will print every time where protocol.export() and protocol.refer()
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3397: Fix
when qos is disable,log will print every time.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@19c1af8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3397 +/- ##
=========================================
Coverage ? 63.82%
Complexity ? 71
=========================================
Files ? 661
Lines ? 28602
Branches ? 4820
=========================================
Hits ? 18256
Misses ? 8122
Partials ? 2224
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/dubbo/qos/server/Server.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3397/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3NlcnZlci9TZXJ2ZXIuamF2YQ==) | `72.09% <100%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3397/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <100%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=footer). Last update [19c1af8...c722c5c](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3397: Fix
when qos is disable,log will print every time.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@19c1af8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3397 +/- ##
=========================================
Coverage ? 63.82%
Complexity ? 71
=========================================
Files ? 661
Lines ? 28602
Branches ? 4820
=========================================
Hits ? 18254
Misses ? 8127
Partials ? 2221
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3397/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <100%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=footer). Last update [19c1af8...6bc36ea](https://codecov.io/gh/apache/incubator-dubbo/pull/3397?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #3397: Fix
when qos is disable,log will print every time.
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
But not every time we called `startQosServer` right ?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #3397: Fix
when qos is disable,log will print every time.
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Nice work.
I will deal it after ci passed. Thx for your contribution.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3397: Fix
when qos is disable,log will print every time.
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
> After modification，the log will be still printed.
yes , but it only printed in the first time.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3397: Fix
when qos is disable,log will print every time.
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
Is there any progress?
@carryxyh @cvictory
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang closed pull request #3397:
Fix when qos is disable,log will print every time.
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
[ pull request closed by zonghaishang ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] cvictory commented on issue #3397: Fix
when qos is disable,log will print every time.
Posted by "cvictory (GitHub)" <gi...@apache.org>.
After modification，the log will be still printed.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3397 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org