You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Olivier Lamy <ol...@apache.org> on 2019/10/10 00:53:08 UTC
Surefire 3.0.0-M4 release?
Hi,
It's now almost 10 months since last and around 30 issues fixed.
Maybe time for a new release?
Moving issues still open to 3.0.0-M5?
cheers
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
I have to try to merge the fix because it avoids a situation when the VM
hanged. It is very important for the users.
The remaining fixes may go to M5.
I will adjust Jira release notes, oki?
I have time to cut the release, no problem. The only problem was to find
some spare time for coding the fixes.
I will try to be fast with the merge.
On Thu, Oct 10, 2019 at 1:17 PM Olivier Lamy <ol...@apache.org> wrote:
> We can release now 3.0.0-M4 and then release later with your remaining
> fixes/new features.
> As far I know we do not have a fix release content we can easily move the
> remaining fixes to a 3.0.0-M5
> I'm happy to release it myself if you don't have time.
>
> On Thu, 10 Oct 2019 at 21:11, Tibor Digana <ti...@apache.org> wrote:
>
> > I understood the wish from JUnit5 fans e.g. Olivier Lamy but still we
> have
> > important fixes for the stability and it is hard to find new developers.
> > I was thinking about this release/3.0.0-M4 and adding one more milestone
> > too but there is fix on my PC that I have a problem to merge without new
> > TCP/IP connector in Surefire.
> > We still have TCP/IP connector in progress...
> >
> > On Thu, Oct 10, 2019 at 7:11 AM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > +1
> > > Enrico
> > >
> > > Il gio 10 ott 2019, 06:40 Romain Manni-Bucau <rm...@gmail.com>
> ha
> > > scritto:
> > >
> > > > Anything user facing preventing to let it be a final?
> > > >
> > > > Anyway +1 to let fixes get out.
> > > >
> > > > Le jeu. 10 oct. 2019 à 02:53, Olivier Lamy <ol...@apache.org> a
> écrit
> > :
> > > >
> > > > > Hi,
> > > > > It's now almost 10 months since last and around 30 issues fixed.
> > > > > Maybe time for a new release?
> > > > > Moving issues still open to 3.0.0-M5?
> > > > >
> > > > > cheers
> > > > > --
> > > > > Olivier Lamy
> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > > >
> > > >
> > >
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: Surefire 3.0.0-M4 release?
Posted by Olivier Lamy <ol...@apache.org>.
We can release now 3.0.0-M4 and then release later with your remaining
fixes/new features.
As far I know we do not have a fix release content we can easily move the
remaining fixes to a 3.0.0-M5
I'm happy to release it myself if you don't have time.
On Thu, 10 Oct 2019 at 21:11, Tibor Digana <ti...@apache.org> wrote:
> I understood the wish from JUnit5 fans e.g. Olivier Lamy but still we have
> important fixes for the stability and it is hard to find new developers.
> I was thinking about this release/3.0.0-M4 and adding one more milestone
> too but there is fix on my PC that I have a problem to merge without new
> TCP/IP connector in Surefire.
> We still have TCP/IP connector in progress...
>
> On Thu, Oct 10, 2019 at 7:11 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > +1
> > Enrico
> >
> > Il gio 10 ott 2019, 06:40 Romain Manni-Bucau <rm...@gmail.com> ha
> > scritto:
> >
> > > Anything user facing preventing to let it be a final?
> > >
> > > Anyway +1 to let fixes get out.
> > >
> > > Le jeu. 10 oct. 2019 à 02:53, Olivier Lamy <ol...@apache.org> a écrit
> :
> > >
> > > > Hi,
> > > > It's now almost 10 months since last and around 30 issues fixed.
> > > > Maybe time for a new release?
> > > > Moving issues still open to 3.0.0-M5?
> > > >
> > > > cheers
> > > > --
> > > > Olivier Lamy
> > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >
> > >
> >
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
I understood the wish from JUnit5 fans e.g. Olivier Lamy but still we have
important fixes for the stability and it is hard to find new developers.
I was thinking about this release/3.0.0-M4 and adding one more milestone
too but there is fix on my PC that I have a problem to merge without new
TCP/IP connector in Surefire.
We still have TCP/IP connector in progress...
On Thu, Oct 10, 2019 at 7:11 AM Enrico Olivelli <eo...@gmail.com> wrote:
> +1
> Enrico
>
> Il gio 10 ott 2019, 06:40 Romain Manni-Bucau <rm...@gmail.com> ha
> scritto:
>
> > Anything user facing preventing to let it be a final?
> >
> > Anyway +1 to let fixes get out.
> >
> > Le jeu. 10 oct. 2019 à 02:53, Olivier Lamy <ol...@apache.org> a écrit :
> >
> > > Hi,
> > > It's now almost 10 months since last and around 30 issues fixed.
> > > Maybe time for a new release?
> > > Moving issues still open to 3.0.0-M5?
> > >
> > > cheers
> > > --
> > > Olivier Lamy
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Enrico Olivelli <eo...@gmail.com>.
+1
Enrico
Il gio 10 ott 2019, 06:40 Romain Manni-Bucau <rm...@gmail.com> ha
scritto:
> Anything user facing preventing to let it be a final?
>
> Anyway +1 to let fixes get out.
>
> Le jeu. 10 oct. 2019 à 02:53, Olivier Lamy <ol...@apache.org> a écrit :
>
> > Hi,
> > It's now almost 10 months since last and around 30 issues fixed.
> > Maybe time for a new release?
> > Moving issues still open to 3.0.0-M5?
> >
> > cheers
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Anything user facing preventing to let it be a final?
Anyway +1 to let fixes get out.
Le jeu. 10 oct. 2019 à 02:53, Olivier Lamy <ol...@apache.org> a écrit :
> Hi,
> It's now almost 10 months since last and around 30 issues fixed.
> Maybe time for a new release?
> Moving issues still open to 3.0.0-M5?
>
> cheers
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Have to admit I dont know, clearly a different load though. Feel free to
ask Joel on the ticket.
Le sam. 12 oct. 2019 à 12:49, Tibor Digana <ti...@apache.org> a
écrit :
> I have noticed this happening only with snapshot versions. The snapshot and
> release repos have different h/w?!
>
> On Sat, Oct 12, 2019 at 12:44 PM Romain Manni-Bucau <rmannibucau@gmail.com
> >
> wrote:
>
> > They work on it with some rate limiting until it gets resolved.
> > They had some abnormal load.
> >
> > Le sam. 12 oct. 2019 à 12:24, Tibor Digana <ti...@apache.org> a
> > écrit :
> >
> > > Romain, I have enabled JUnit5 5.6.0/1.6.0-SNAPSHOT.
> > > I want to know if the bug OSSRH-51220 is fixed.
> > >
> > >
> >
> https://builds.apache.org/job/maven-box/job/maven-surefire/job/junit5-snapshots/
> > >
> > > On Sat, Oct 12, 2019 at 12:10 PM Tibor Digana <ti...@apache.org>
> > > wrote:
> > >
> > > > Here is the pull request
> > > > https://github.com/codehaus-plexus/plexus-languages/pull/29
> > > >
> > > > On Sat, Oct 12, 2019 at 11:49 AM Romain Manni-Bucau <
> > > rmannibucau@gmail.com>
> > > > wrote:
> > > >
> > > >> I understand and if we can we must do but not a blocker - was my
> point
> > > >> Also keep in mind we could do the update automatically with asm
> > > versioning
> > > >> scheme using our resolver in the mojo.
> > > >> So let's fix issues for most users - once again j > 11 is a play
> area,
> > > not
> > > >> for prod today - and maybe enhance our asm integration layer later.
> > > >>
> > > >> Le sam. 12 oct. 2019 à 11:42, Tibor Digana <ti...@apache.org>
> a
> > > >> écrit :
> > > >>
> > > >> > all bad, see the stackoverflow. It happens that the users argue
> that
> > > >> they
> > > >> > have to update our dependencies which is our responsibility!
> > > >> >
> > > >> > On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <
> > > >> rmannibucau@gmail.com
> > > >> > >
> > > >> > wrote:
> > > >> >
> > > >> > > Dont think there is an api version upgrade between 7.0 and 7.2
> so
> > > can
> > > >> be
> > > >> > > upgraded in user pom so not a blocker for a milestone release
> > > >> IMHO....j13
> > > >> > > and j14 are still not adopted too so all good.
> > > >> > >
> > > >> > > Le sam. 12 oct. 2019 à 11:35, Tibor Digana <
> > tibordigana@apache.org>
> > > a
> > > >> > > écrit :
> > > >> > >
> > > >> > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > >> > > > The support for JDk 13 and 14 is in the version 7.2.
> > > >> > > > We have similar upgrade in
> > > >> > > > https://github.com/apache/maven-shade-plugin/pull/29
> > > >> > > >
> > > >> > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> olamy@apache.org>
> > > >> wrote:
> > > >> > > >
> > > >> > > > > Hi,
> > > >> > > > > It's now almost 10 months since last and around 30 issues
> > fixed.
> > > >> > > > > Maybe time for a new release?
> > > >> > > > > Moving issues still open to 3.0.0-M5?
> > > >> > > > >
> > > >> > > > > cheers
> > > >> > > > > --
> > > >> > > > > Olivier Lamy
> > > >> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
I have noticed this happening only with snapshot versions. The snapshot and
release repos have different h/w?!
On Sat, Oct 12, 2019 at 12:44 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> They work on it with some rate limiting until it gets resolved.
> They had some abnormal load.
>
> Le sam. 12 oct. 2019 à 12:24, Tibor Digana <ti...@apache.org> a
> écrit :
>
> > Romain, I have enabled JUnit5 5.6.0/1.6.0-SNAPSHOT.
> > I want to know if the bug OSSRH-51220 is fixed.
> >
> >
> https://builds.apache.org/job/maven-box/job/maven-surefire/job/junit5-snapshots/
> >
> > On Sat, Oct 12, 2019 at 12:10 PM Tibor Digana <ti...@apache.org>
> > wrote:
> >
> > > Here is the pull request
> > > https://github.com/codehaus-plexus/plexus-languages/pull/29
> > >
> > > On Sat, Oct 12, 2019 at 11:49 AM Romain Manni-Bucau <
> > rmannibucau@gmail.com>
> > > wrote:
> > >
> > >> I understand and if we can we must do but not a blocker - was my point
> > >> Also keep in mind we could do the update automatically with asm
> > versioning
> > >> scheme using our resolver in the mojo.
> > >> So let's fix issues for most users - once again j > 11 is a play area,
> > not
> > >> for prod today - and maybe enhance our asm integration layer later.
> > >>
> > >> Le sam. 12 oct. 2019 à 11:42, Tibor Digana <ti...@apache.org> a
> > >> écrit :
> > >>
> > >> > all bad, see the stackoverflow. It happens that the users argue that
> > >> they
> > >> > have to update our dependencies which is our responsibility!
> > >> >
> > >> > On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <
> > >> rmannibucau@gmail.com
> > >> > >
> > >> > wrote:
> > >> >
> > >> > > Dont think there is an api version upgrade between 7.0 and 7.2 so
> > can
> > >> be
> > >> > > upgraded in user pom so not a blocker for a milestone release
> > >> IMHO....j13
> > >> > > and j14 are still not adopted too so all good.
> > >> > >
> > >> > > Le sam. 12 oct. 2019 à 11:35, Tibor Digana <
> tibordigana@apache.org>
> > a
> > >> > > écrit :
> > >> > >
> > >> > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > >> > > > The support for JDk 13 and 14 is in the version 7.2.
> > >> > > > We have similar upgrade in
> > >> > > > https://github.com/apache/maven-shade-plugin/pull/29
> > >> > > >
> > >> > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> > >> wrote:
> > >> > > >
> > >> > > > > Hi,
> > >> > > > > It's now almost 10 months since last and around 30 issues
> fixed.
> > >> > > > > Maybe time for a new release?
> > >> > > > > Moving issues still open to 3.0.0-M5?
> > >> > > > >
> > >> > > > > cheers
> > >> > > > > --
> > >> > > > > Olivier Lamy
> > >> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
They work on it with some rate limiting until it gets resolved.
They had some abnormal load.
Le sam. 12 oct. 2019 à 12:24, Tibor Digana <ti...@apache.org> a
écrit :
> Romain, I have enabled JUnit5 5.6.0/1.6.0-SNAPSHOT.
> I want to know if the bug OSSRH-51220 is fixed.
>
> https://builds.apache.org/job/maven-box/job/maven-surefire/job/junit5-snapshots/
>
> On Sat, Oct 12, 2019 at 12:10 PM Tibor Digana <ti...@apache.org>
> wrote:
>
> > Here is the pull request
> > https://github.com/codehaus-plexus/plexus-languages/pull/29
> >
> > On Sat, Oct 12, 2019 at 11:49 AM Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > wrote:
> >
> >> I understand and if we can we must do but not a blocker - was my point
> >> Also keep in mind we could do the update automatically with asm
> versioning
> >> scheme using our resolver in the mojo.
> >> So let's fix issues for most users - once again j > 11 is a play area,
> not
> >> for prod today - and maybe enhance our asm integration layer later.
> >>
> >> Le sam. 12 oct. 2019 à 11:42, Tibor Digana <ti...@apache.org> a
> >> écrit :
> >>
> >> > all bad, see the stackoverflow. It happens that the users argue that
> >> they
> >> > have to update our dependencies which is our responsibility!
> >> >
> >> > On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <
> >> rmannibucau@gmail.com
> >> > >
> >> > wrote:
> >> >
> >> > > Dont think there is an api version upgrade between 7.0 and 7.2 so
> can
> >> be
> >> > > upgraded in user pom so not a blocker for a milestone release
> >> IMHO....j13
> >> > > and j14 are still not adopted too so all good.
> >> > >
> >> > > Le sam. 12 oct. 2019 à 11:35, Tibor Digana <ti...@apache.org>
> a
> >> > > écrit :
> >> > >
> >> > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> >> > > > The support for JDk 13 and 14 is in the version 7.2.
> >> > > > We have similar upgrade in
> >> > > > https://github.com/apache/maven-shade-plugin/pull/29
> >> > > >
> >> > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> >> wrote:
> >> > > >
> >> > > > > Hi,
> >> > > > > It's now almost 10 months since last and around 30 issues fixed.
> >> > > > > Maybe time for a new release?
> >> > > > > Moving issues still open to 3.0.0-M5?
> >> > > > >
> >> > > > > cheers
> >> > > > > --
> >> > > > > Olivier Lamy
> >> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
Romain, I have enabled JUnit5 5.6.0/1.6.0-SNAPSHOT.
I want to know if the bug OSSRH-51220 is fixed.
https://builds.apache.org/job/maven-box/job/maven-surefire/job/junit5-snapshots/
On Sat, Oct 12, 2019 at 12:10 PM Tibor Digana <ti...@apache.org>
wrote:
> Here is the pull request
> https://github.com/codehaus-plexus/plexus-languages/pull/29
>
> On Sat, Oct 12, 2019 at 11:49 AM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>> I understand and if we can we must do but not a blocker - was my point
>> Also keep in mind we could do the update automatically with asm versioning
>> scheme using our resolver in the mojo.
>> So let's fix issues for most users - once again j > 11 is a play area, not
>> for prod today - and maybe enhance our asm integration layer later.
>>
>> Le sam. 12 oct. 2019 à 11:42, Tibor Digana <ti...@apache.org> a
>> écrit :
>>
>> > all bad, see the stackoverflow. It happens that the users argue that
>> they
>> > have to update our dependencies which is our responsibility!
>> >
>> > On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <
>> rmannibucau@gmail.com
>> > >
>> > wrote:
>> >
>> > > Dont think there is an api version upgrade between 7.0 and 7.2 so can
>> be
>> > > upgraded in user pom so not a blocker for a milestone release
>> IMHO....j13
>> > > and j14 are still not adopted too so all good.
>> > >
>> > > Le sam. 12 oct. 2019 à 11:35, Tibor Digana <ti...@apache.org> a
>> > > écrit :
>> > >
>> > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
>> > > > The support for JDk 13 and 14 is in the version 7.2.
>> > > > We have similar upgrade in
>> > > > https://github.com/apache/maven-shade-plugin/pull/29
>> > > >
>> > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
>> wrote:
>> > > >
>> > > > > Hi,
>> > > > > It's now almost 10 months since last and around 30 issues fixed.
>> > > > > Maybe time for a new release?
>> > > > > Moving issues still open to 3.0.0-M5?
>> > > > >
>> > > > > cheers
>> > > > > --
>> > > > > Olivier Lamy
>> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
>> > > > >
>> > > >
>> > >
>> >
>>
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
Here is the pull request
https://github.com/codehaus-plexus/plexus-languages/pull/29
On Sat, Oct 12, 2019 at 11:49 AM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> I understand and if we can we must do but not a blocker - was my point
> Also keep in mind we could do the update automatically with asm versioning
> scheme using our resolver in the mojo.
> So let's fix issues for most users - once again j > 11 is a play area, not
> for prod today - and maybe enhance our asm integration layer later.
>
> Le sam. 12 oct. 2019 à 11:42, Tibor Digana <ti...@apache.org> a
> écrit :
>
> > all bad, see the stackoverflow. It happens that the users argue that they
> > have to update our dependencies which is our responsibility!
> >
> > On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <
> rmannibucau@gmail.com
> > >
> > wrote:
> >
> > > Dont think there is an api version upgrade between 7.0 and 7.2 so can
> be
> > > upgraded in user pom so not a blocker for a milestone release
> IMHO....j13
> > > and j14 are still not adopted too so all good.
> > >
> > > Le sam. 12 oct. 2019 à 11:35, Tibor Digana <ti...@apache.org> a
> > > écrit :
> > >
> > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > > The support for JDk 13 and 14 is in the version 7.2.
> > > > We have similar upgrade in
> > > > https://github.com/apache/maven-shade-plugin/pull/29
> > > >
> > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> wrote:
> > > >
> > > > > Hi,
> > > > > It's now almost 10 months since last and around 30 issues fixed.
> > > > > Maybe time for a new release?
> > > > > Moving issues still open to 3.0.0-M5?
> > > > >
> > > > > cheers
> > > > > --
> > > > > Olivier Lamy
> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > > >
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
I understand and if we can we must do but not a blocker - was my point
Also keep in mind we could do the update automatically with asm versioning
scheme using our resolver in the mojo.
So let's fix issues for most users - once again j > 11 is a play area, not
for prod today - and maybe enhance our asm integration layer later.
Le sam. 12 oct. 2019 à 11:42, Tibor Digana <ti...@apache.org> a
écrit :
> all bad, see the stackoverflow. It happens that the users argue that they
> have to update our dependencies which is our responsibility!
>
> On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <rmannibucau@gmail.com
> >
> wrote:
>
> > Dont think there is an api version upgrade between 7.0 and 7.2 so can be
> > upgraded in user pom so not a blocker for a milestone release IMHO....j13
> > and j14 are still not adopted too so all good.
> >
> > Le sam. 12 oct. 2019 à 11:35, Tibor Digana <ti...@apache.org> a
> > écrit :
> >
> > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > The support for JDk 13 and 14 is in the version 7.2.
> > > We have similar upgrade in
> > > https://github.com/apache/maven-shade-plugin/pull/29
> > >
> > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> wrote:
> > >
> > > > Hi,
> > > > It's now almost 10 months since last and around 30 issues fixed.
> > > > Maybe time for a new release?
> > > > Moving issues still open to 3.0.0-M5?
> > > >
> > > > cheers
> > > > --
> > > > Olivier Lamy
> > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
all bad, see the stackoverflow. It happens that the users argue that they
have to update our dependencies which is our responsibility!
On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Dont think there is an api version upgrade between 7.0 and 7.2 so can be
> upgraded in user pom so not a blocker for a milestone release IMHO....j13
> and j14 are still not adopted too so all good.
>
> Le sam. 12 oct. 2019 à 11:35, Tibor Digana <ti...@apache.org> a
> écrit :
>
> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > The support for JDk 13 and 14 is in the version 7.2.
> > We have similar upgrade in
> > https://github.com/apache/maven-shade-plugin/pull/29
> >
> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> wrote:
> >
> > > Hi,
> > > It's now almost 10 months since last and around 30 issues fixed.
> > > Maybe time for a new release?
> > > Moving issues still open to 3.0.0-M5?
> > >
> > > cheers
> > > --
> > > Olivier Lamy
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Dont think there is an api version upgrade between 7.0 and 7.2 so can be
upgraded in user pom so not a blocker for a milestone release IMHO....j13
and j14 are still not adopted too so all good.
Le sam. 12 oct. 2019 à 11:35, Tibor Digana <ti...@apache.org> a
écrit :
> We still use plexus-java:1.0.3 which depends on ASM 7.0.
> The support for JDk 13 and 14 is in the version 7.2.
> We have similar upgrade in
> https://github.com/apache/maven-shade-plugin/pull/29
>
> On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> wrote:
>
> > Hi,
> > It's now almost 10 months since last and around 30 issues fixed.
> > Maybe time for a new release?
> > Moving issues still open to 3.0.0-M5?
> >
> > cheers
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
This is not the point Tibor and I'll just repeat it a last time: there are
fixes in this version - rerun is not one - and we agreed one month ago to
let it be released as a milestone. There is no real way to excuse the fact
we missed it cause of other feature....this is exactly why it is milestones
and not final releases.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 11 nov. 2019 à 18:08, Tibor Digana <ti...@apache.org> a
écrit :
> Romain, You have to understand also me, users, contributors. You are not
> alone. Olivier is also not alone.
> See the others, e.g. Enrico, Jonathan, Matt, etc. They are greatly
> communicating, understanding, and they are petitioned what it means to
> accept requirements from others and making a compromises!
> I think Olivier undeerstood it very well on Slack and he made a compromise.
> We all understand that he needs to use this version in Jenkins project and
> he understands that the issue SUREFIRE-1584 is incomplete and that's what
> we are fixing right now because it is worth to spend a day to say that the
> rerun works for parameterized tests as well. The users want it and it is
> not so time spending issue acctualy.
>
> On Mon, Nov 11, 2019 at 5:50 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > @Tibor: I'd like to gently remind you that we - asf - are community
> driven
> > and holding a release is generally bad if it does not bite us after which
> > is the case there. As mentionned by Olivier we already agreed to release
> > and it got delayed for no reason compared to the original agreement.
> Please
> > understand this is not about the work you are doing - we can discuss it
> at
> > another moment since, as you mentionned we don't fully agree here, but
> the
> > point there was totally different and user centric. Please take care to
> > re-read and see you just forked that thread alone. No big deal while the
> > release pops up next week but no need to start an argument too ;).
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le lun. 11 nov. 2019 à 17:26, Tibor Digana <ti...@apache.org> a
> > écrit :
> >
> > > Roman, it does not make sense to continue with you because you do not
> > > understand the whole track with this project, and again nobody said
> > > anything about architecture. It's your permanent opinions and very bad
> > > attitude. So it is waste of the time to continue to explain the same
> > things
> > > over rand over again to You.
> > > Read emails and understand them first or or just watch the ML if you do
> > not
> > > want to understand it.
> > >
> > > On Mon, Nov 11, 2019 at 5:21 PM Romain Manni-Bucau <
> > rmannibucau@gmail.com>
> > > wrote:
> > >
> > > > @Tibor: point is more that we don't need to hold a milestone for a
> > > feature,
> > > > we can just release and let fixes get out and get this huge
> > architectural
> > > > change in another milestone. Only valid reason to delay a release is
> > IMO
> > > a
> > > > regression or a major change we can't revert later (3.0.0 would be in
> > > this
> > > > bucket, not a milestone).
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > <
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > > >
> > > > Le lun. 11 nov. 2019 à 16:54, Tibor Digana <ti...@apache.org>
> a
> > > > écrit :
> > > >
> > > > > The reason of M4 was to introduce TCP communication.
> > > > > Meanwhile first we wanted to cut the release one month ago but we
> > > > postponed
> > > > > it and we were waiting for clarifying license issues and fixed J13
> > > issue
> > > > > yesterday.
> > > > > I was working on TCP/Pipes together with Jonathan Bell and we
> wanted
> > to
> > > > > make it in M4 which was our plan but we still have only 35% of the
> > > total
> > > > > work and there are several things which are too detailed to
> mention.
> > So
> > > > > this has to continue and my estimation is that we need to spend 20
> > > days.
> > > > We
> > > > > were working on it quite intensively in the background created few
> > PRs
> > > > and
> > > > > moved the code from one PR to another and clarified it.
> > > > > Yesterday I proposed to Jonathan that it does not make sense to
> work
> > on
> > > > our
> > > > > taks like a hell because it would prolong the development which
> would
> > > > take
> > > > > too long.
> > > > > So this is the whole reason, otherwise we could already include
> > > TCP/Pipes
> > > > > into M4.
> > > > > T
> > > > >
> > > > >
> > > > >
> > > > > On Mon, Nov 11, 2019 at 2:29 PM Romain Manni-Bucau <
> > > > rmannibucau@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > +1 to release next week, no reason to wait since it is another
> "m"
> > > > > release
> > > > > > IMHO
> > > > > >
> > > > > > Le lun. 11 nov. 2019 à 12:44, Olivier Lamy <ol...@apache.org> a
> > > écrit
> > > > :
> > > > > >
> > > > > > > That will be great.
> > > > > > > If you don't have time before end of the week. I'm happy to
> help
> > > and
> > > > do
> > > > > > it.
> > > > > > > cheers
> > > > > > > Olivier
> > > > > > >
> > > > > > > On Mon, 11 Nov 2019 at 21:35, Tibor Digana <
> > tibordigana@apache.org
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > @Olivier as we clarified this Slack. The release will be
> fast.
> > No
> > > > > > delay!
> > > > > > > >
> > > > > > > > On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <
> > olamy@apache.org>
> > > > > > wrote:
> > > > > > > >
> > > > > > > > > Why? delay again
> > > > > > > > > I thought 1 month ago we agreed ago to move non finished
> > stuff
> > > to
> > > > > > > > 3.0.0-M5
> > > > > > > > > and release 3.0.0-M5 later.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <
> > > > tibordigana@apache.org
> > > > > >
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Pls don't do it.
> > > > > > > > > > I will cut it and move some issues to M5 but I need Matt
> to
> > > > > finish
> > > > > > > his
> > > > > > > > > > work. I am in contact with Mat.
> > > > > > > > > > I talked about it with the contributor Jonathan Bell
> about
> > > > > > reasoning.
> > > > > > > > > > T
> > > > > > > > > >
> > > > > > > > > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <
> > > > olamy@apache.org>
> > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Hi
> > > > > > > > > > > Starting again this thread as we agreed but I didn't do
> > it.
> > > > > > > > > > > So I'd like to cut release 3.0.0-M4 by the end of this
> > > week.
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <
> > > > > > tibordigana@apache.org
> > > > > > > >
> > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > > The SUREFIRE-1689 progress has been finished until
> the
> > CI
> > > > > build
> > > > > > > > > > succeeds.
> > > > > > > > > > > > T
> > > > > > > > > > > >
> > > > > > > > > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > > > > > > > > rfscholte@apache.org>
> > > > > > > > > > > > wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > > Ah, there it is :)
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain
> > Manni-Bucau
> > > > > > > > > > > > > <rm...@gmail.com> wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > > Didnt expect my comment about shade to take so
> much
> > > > space
> > > > > > in
> > > > > > > > this
> > > > > > > > > > > > thread
> > > > > > > > > > > > > > but yes we rely on asm for relocation:
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > > > > > > > > rfscholte@apache.org
> > > > > > > > > > >
> > > > > > > > > > > a
> > > > > > > > > > > > > > écrit :
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain
> > > Manni-Bucau
> > > > > > > > > > > > > >> <rm...@gmail.com> wrote:
> > > > > > > > > > > > > >>
> > > > > > > > > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > > > > > > > > rfscholte@apache.org>
> > > > > > > > > > > > a
> > > > > > > > > > > > > >> > écrit :
> > > > > > > > > > > > > >> >
> > > > > > > > > > > > > >> >> As far as I know, surefire won't touch the
> > Plexus
> > > > > Java
> > > > > > > code
> > > > > > > > > > that
> > > > > > > > > > > > > >> >> requires
> > > > > > > > > > > > > >> >> ASM.
> > > > > > > > > > > > > >> >> It is ONLY required when the runtime is Java
> 8
> > or
> > > > > lower
> > > > > > > AND
> > > > > > > > > you
> > > > > > > > > > > > > need
> > > > > > > > > > > > > >> to
> > > > > > > > > > > > > >> >> read the module descriptors.
> > > > > > > > > > > > > >> >>
> > > > > > > > > > > > > >> >> Maven Shade is a different case: it must
> parse
> > > the
> > > > > Java
> > > > > > > > > > bytecode
> > > > > > > > > > > > (and
> > > > > > > > > > > > > >> >> only
> > > > > > > > > > > > > >> >> when using minifyJar), hence it needs the
> > latest
> > > > ASM.
> > > > > > > > > > > > > >> >>
> > > > > > > > > > > > > >> >
> > > > > > > > > > > > > >> > + Relocation ;)
> > > > > > > > > > > > > >>
> > > > > > > > > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > > > > > > > > >>
> > > > > > > > > > > > > >>
> > > > > > > > > > > > > >>
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > > > > > > > > >>
> > > > > > > > > > > > > >> (but it might be better to do so...)
> > > > > > > > > > > > > >>
> > > > > > > > > > > > > >> >
> > > > > > > > > > > > > >> >
> > > > > > > > > > > > > >> >> Robert
> > > > > > > > > > > > > >> >>
> > > > > > > > > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor
> > Digana
> > > > > > > > > > > > > >> >> <ti...@apache.org>
> > > > > > > > > > > > > >> >>
> > > > > > > > > > > > > >> >> wrote:
> > > > > > > > > > > > > >> >>
> > > > > > > > > > > > > >> >> > We still use plexus-java:1.0.3 which
> depends
> > on
> > > > ASM
> > > > > > > 7.0.
> > > > > > > > > > > > > >> >> > The support for JDk 13 and 14 is in the
> > version
> > > > > 7.2.
> > > > > > > > > > > > > >> >> > We have similar upgrade in
> > > > > > > > > > > > > >> >> >
> > > > > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > > > > > > > > >> >> >
> > > > > > > > > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier
> Lamy
> > <
> > > > > > > > > > olamy@apache.org
> > > > > > > > > > > >
> > > > > > > > > > > > > >> wrote:
> > > > > > > > > > > > > >> >> >
> > > > > > > > > > > > > >> >> >> Hi,
> > > > > > > > > > > > > >> >> >> It's now almost 10 months since last and
> > > around
> > > > 30
> > > > > > > > issues
> > > > > > > > > > > fixed.
> > > > > > > > > > > > > >> >> >> Maybe time for a new release?
> > > > > > > > > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > > > > > > > > >> >> >>
> > > > > > > > > > > > > >> >> >> cheers
> > > > > > > > > > > > > >> >> >> --
> > > > > > > > > > > > > >> >> >> Olivier Lamy
> > > > > > > > > > > > > >> >>
> > > > > > > > > > > > > >> >>
> > > > > > > > > > > >
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > > > > > > >> >> To unsubscribe, e-mail:
> > > > > > dev-unsubscribe@maven.apache.org
> > > > > > > > > > > > > >> >> For additional commands, e-mail:
> > > > > > > dev-help@maven.apache.org
> > > > > > > > > > > > > >> >>
> > > > > > > > > > > > > >>
> > > > > > > > > > > > > >>
> > > > > > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > > > > > > > >> To unsubscribe, e-mail:
> > > > > dev-unsubscribe@maven.apache.org
> > > > > > > > > > > > > >> For additional commands, e-mail:
> > > > > > dev-help@maven.apache.org
> > > > > > > > > > > > > >>
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > > > > > > > > > To unsubscribe, e-mail:
> > > dev-unsubscribe@maven.apache.org
> > > > > > > > > > > > > For additional commands, e-mail:
> > > > dev-help@maven.apache.org
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
Romain, You have to understand also me, users, contributors. You are not
alone. Olivier is also not alone.
See the others, e.g. Enrico, Jonathan, Matt, etc. They are greatly
communicating, understanding, and they are petitioned what it means to
accept requirements from others and making a compromises!
I think Olivier undeerstood it very well on Slack and he made a compromise.
We all understand that he needs to use this version in Jenkins project and
he understands that the issue SUREFIRE-1584 is incomplete and that's what
we are fixing right now because it is worth to spend a day to say that the
rerun works for parameterized tests as well. The users want it and it is
not so time spending issue acctualy.
On Mon, Nov 11, 2019 at 5:50 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> @Tibor: I'd like to gently remind you that we - asf - are community driven
> and holding a release is generally bad if it does not bite us after which
> is the case there. As mentionned by Olivier we already agreed to release
> and it got delayed for no reason compared to the original agreement. Please
> understand this is not about the work you are doing - we can discuss it at
> another moment since, as you mentionned we don't fully agree here, but the
> point there was totally different and user centric. Please take care to
> re-read and see you just forked that thread alone. No big deal while the
> release pops up next week but no need to start an argument too ;).
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 11 nov. 2019 à 17:26, Tibor Digana <ti...@apache.org> a
> écrit :
>
> > Roman, it does not make sense to continue with you because you do not
> > understand the whole track with this project, and again nobody said
> > anything about architecture. It's your permanent opinions and very bad
> > attitude. So it is waste of the time to continue to explain the same
> things
> > over rand over again to You.
> > Read emails and understand them first or or just watch the ML if you do
> not
> > want to understand it.
> >
> > On Mon, Nov 11, 2019 at 5:21 PM Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > wrote:
> >
> > > @Tibor: point is more that we don't need to hold a milestone for a
> > feature,
> > > we can just release and let fixes get out and get this huge
> architectural
> > > change in another milestone. Only valid reason to delay a release is
> IMO
> > a
> > > regression or a major change we can't revert later (3.0.0 would be in
> > this
> > > bucket, not a milestone).
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le lun. 11 nov. 2019 à 16:54, Tibor Digana <ti...@apache.org> a
> > > écrit :
> > >
> > > > The reason of M4 was to introduce TCP communication.
> > > > Meanwhile first we wanted to cut the release one month ago but we
> > > postponed
> > > > it and we were waiting for clarifying license issues and fixed J13
> > issue
> > > > yesterday.
> > > > I was working on TCP/Pipes together with Jonathan Bell and we wanted
> to
> > > > make it in M4 which was our plan but we still have only 35% of the
> > total
> > > > work and there are several things which are too detailed to mention.
> So
> > > > this has to continue and my estimation is that we need to spend 20
> > days.
> > > We
> > > > were working on it quite intensively in the background created few
> PRs
> > > and
> > > > moved the code from one PR to another and clarified it.
> > > > Yesterday I proposed to Jonathan that it does not make sense to work
> on
> > > our
> > > > taks like a hell because it would prolong the development which would
> > > take
> > > > too long.
> > > > So this is the whole reason, otherwise we could already include
> > TCP/Pipes
> > > > into M4.
> > > > T
> > > >
> > > >
> > > >
> > > > On Mon, Nov 11, 2019 at 2:29 PM Romain Manni-Bucau <
> > > rmannibucau@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 to release next week, no reason to wait since it is another "m"
> > > > release
> > > > > IMHO
> > > > >
> > > > > Le lun. 11 nov. 2019 à 12:44, Olivier Lamy <ol...@apache.org> a
> > écrit
> > > :
> > > > >
> > > > > > That will be great.
> > > > > > If you don't have time before end of the week. I'm happy to help
> > and
> > > do
> > > > > it.
> > > > > > cheers
> > > > > > Olivier
> > > > > >
> > > > > > On Mon, 11 Nov 2019 at 21:35, Tibor Digana <
> tibordigana@apache.org
> > >
> > > > > wrote:
> > > > > >
> > > > > > > @Olivier as we clarified this Slack. The release will be fast.
> No
> > > > > delay!
> > > > > > >
> > > > > > > On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <
> olamy@apache.org>
> > > > > wrote:
> > > > > > >
> > > > > > > > Why? delay again
> > > > > > > > I thought 1 month ago we agreed ago to move non finished
> stuff
> > to
> > > > > > > 3.0.0-M5
> > > > > > > > and release 3.0.0-M5 later.
> > > > > > > >
> > > > > > > >
> > > > > > > > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <
> > > tibordigana@apache.org
> > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Pls don't do it.
> > > > > > > > > I will cut it and move some issues to M5 but I need Matt to
> > > > finish
> > > > > > his
> > > > > > > > > work. I am in contact with Mat.
> > > > > > > > > I talked about it with the contributor Jonathan Bell about
> > > > > reasoning.
> > > > > > > > > T
> > > > > > > > >
> > > > > > > > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <
> > > olamy@apache.org>
> > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Hi
> > > > > > > > > > Starting again this thread as we agreed but I didn't do
> it.
> > > > > > > > > > So I'd like to cut release 3.0.0-M4 by the end of this
> > week.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <
> > > > > tibordigana@apache.org
> > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > The SUREFIRE-1689 progress has been finished until the
> CI
> > > > build
> > > > > > > > > succeeds.
> > > > > > > > > > > T
> > > > > > > > > > >
> > > > > > > > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > > > > > > > rfscholte@apache.org>
> > > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > > Ah, there it is :)
> > > > > > > > > > > >
> > > > > > > > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain
> Manni-Bucau
> > > > > > > > > > > > <rm...@gmail.com> wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > > Didnt expect my comment about shade to take so much
> > > space
> > > > > in
> > > > > > > this
> > > > > > > > > > > thread
> > > > > > > > > > > > > but yes we rely on asm for relocation:
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > > > > > > > >
> > > > > > > > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > > > > > > > rfscholte@apache.org
> > > > > > > > > >
> > > > > > > > > > a
> > > > > > > > > > > > > écrit :
> > > > > > > > > > > > >
> > > > > > > > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain
> > Manni-Bucau
> > > > > > > > > > > > >> <rm...@gmail.com> wrote:
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > > > > > > > rfscholte@apache.org>
> > > > > > > > > > > a
> > > > > > > > > > > > >> > écrit :
> > > > > > > > > > > > >> >
> > > > > > > > > > > > >> >> As far as I know, surefire won't touch the
> Plexus
> > > > Java
> > > > > > code
> > > > > > > > > that
> > > > > > > > > > > > >> >> requires
> > > > > > > > > > > > >> >> ASM.
> > > > > > > > > > > > >> >> It is ONLY required when the runtime is Java 8
> or
> > > > lower
> > > > > > AND
> > > > > > > > you
> > > > > > > > > > > > need
> > > > > > > > > > > > >> to
> > > > > > > > > > > > >> >> read the module descriptors.
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >> Maven Shade is a different case: it must parse
> > the
> > > > Java
> > > > > > > > > bytecode
> > > > > > > > > > > (and
> > > > > > > > > > > > >> >> only
> > > > > > > > > > > > >> >> when using minifyJar), hence it needs the
> latest
> > > ASM.
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >
> > > > > > > > > > > > >> > + Relocation ;)
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > > > > > > > >>
> > > > > > > > > > > > >>
> > > > > > > > > > > > >>
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> (but it might be better to do so...)
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> >
> > > > > > > > > > > > >> >
> > > > > > > > > > > > >> >> Robert
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor
> Digana
> > > > > > > > > > > > >> >> <ti...@apache.org>
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >> wrote:
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >> > We still use plexus-java:1.0.3 which depends
> on
> > > ASM
> > > > > > 7.0.
> > > > > > > > > > > > >> >> > The support for JDk 13 and 14 is in the
> version
> > > > 7.2.
> > > > > > > > > > > > >> >> > We have similar upgrade in
> > > > > > > > > > > > >> >> >
> > > > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > > > > > > > >> >> >
> > > > > > > > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy
> <
> > > > > > > > > olamy@apache.org
> > > > > > > > > > >
> > > > > > > > > > > > >> wrote:
> > > > > > > > > > > > >> >> >
> > > > > > > > > > > > >> >> >> Hi,
> > > > > > > > > > > > >> >> >> It's now almost 10 months since last and
> > around
> > > 30
> > > > > > > issues
> > > > > > > > > > fixed.
> > > > > > > > > > > > >> >> >> Maybe time for a new release?
> > > > > > > > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > > > > > > > >> >> >>
> > > > > > > > > > > > >> >> >> cheers
> > > > > > > > > > > > >> >> >> --
> > > > > > > > > > > > >> >> >> Olivier Lamy
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >>
> > > > > > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > > > > > > >> >> To unsubscribe, e-mail:
> > > > > dev-unsubscribe@maven.apache.org
> > > > > > > > > > > > >> >> For additional commands, e-mail:
> > > > > > dev-help@maven.apache.org
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >>
> > > > > > > > > > > > >>
> > > > > > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > > > > > > > >> To unsubscribe, e-mail:
> > > > dev-unsubscribe@maven.apache.org
> > > > > > > > > > > > >> For additional commands, e-mail:
> > > > > dev-help@maven.apache.org
> > > > > > > > > > > > >>
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > > > > > To unsubscribe, e-mail:
> > dev-unsubscribe@maven.apache.org
> > > > > > > > > > > > For additional commands, e-mail:
> > > dev-help@maven.apache.org
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
@Tibor: I'd like to gently remind you that we - asf - are community driven
and holding a release is generally bad if it does not bite us after which
is the case there. As mentionned by Olivier we already agreed to release
and it got delayed for no reason compared to the original agreement. Please
understand this is not about the work you are doing - we can discuss it at
another moment since, as you mentionned we don't fully agree here, but the
point there was totally different and user centric. Please take care to
re-read and see you just forked that thread alone. No big deal while the
release pops up next week but no need to start an argument too ;).
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 11 nov. 2019 à 17:26, Tibor Digana <ti...@apache.org> a
écrit :
> Roman, it does not make sense to continue with you because you do not
> understand the whole track with this project, and again nobody said
> anything about architecture. It's your permanent opinions and very bad
> attitude. So it is waste of the time to continue to explain the same things
> over rand over again to You.
> Read emails and understand them first or or just watch the ML if you do not
> want to understand it.
>
> On Mon, Nov 11, 2019 at 5:21 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > @Tibor: point is more that we don't need to hold a milestone for a
> feature,
> > we can just release and let fixes get out and get this huge architectural
> > change in another milestone. Only valid reason to delay a release is IMO
> a
> > regression or a major change we can't revert later (3.0.0 would be in
> this
> > bucket, not a milestone).
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le lun. 11 nov. 2019 à 16:54, Tibor Digana <ti...@apache.org> a
> > écrit :
> >
> > > The reason of M4 was to introduce TCP communication.
> > > Meanwhile first we wanted to cut the release one month ago but we
> > postponed
> > > it and we were waiting for clarifying license issues and fixed J13
> issue
> > > yesterday.
> > > I was working on TCP/Pipes together with Jonathan Bell and we wanted to
> > > make it in M4 which was our plan but we still have only 35% of the
> total
> > > work and there are several things which are too detailed to mention. So
> > > this has to continue and my estimation is that we need to spend 20
> days.
> > We
> > > were working on it quite intensively in the background created few PRs
> > and
> > > moved the code from one PR to another and clarified it.
> > > Yesterday I proposed to Jonathan that it does not make sense to work on
> > our
> > > taks like a hell because it would prolong the development which would
> > take
> > > too long.
> > > So this is the whole reason, otherwise we could already include
> TCP/Pipes
> > > into M4.
> > > T
> > >
> > >
> > >
> > > On Mon, Nov 11, 2019 at 2:29 PM Romain Manni-Bucau <
> > rmannibucau@gmail.com>
> > > wrote:
> > >
> > > > +1 to release next week, no reason to wait since it is another "m"
> > > release
> > > > IMHO
> > > >
> > > > Le lun. 11 nov. 2019 à 12:44, Olivier Lamy <ol...@apache.org> a
> écrit
> > :
> > > >
> > > > > That will be great.
> > > > > If you don't have time before end of the week. I'm happy to help
> and
> > do
> > > > it.
> > > > > cheers
> > > > > Olivier
> > > > >
> > > > > On Mon, 11 Nov 2019 at 21:35, Tibor Digana <tibordigana@apache.org
> >
> > > > wrote:
> > > > >
> > > > > > @Olivier as we clarified this Slack. The release will be fast. No
> > > > delay!
> > > > > >
> > > > > > On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <ol...@apache.org>
> > > > wrote:
> > > > > >
> > > > > > > Why? delay again
> > > > > > > I thought 1 month ago we agreed ago to move non finished stuff
> to
> > > > > > 3.0.0-M5
> > > > > > > and release 3.0.0-M5 later.
> > > > > > >
> > > > > > >
> > > > > > > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <
> > tibordigana@apache.org
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > Pls don't do it.
> > > > > > > > I will cut it and move some issues to M5 but I need Matt to
> > > finish
> > > > > his
> > > > > > > > work. I am in contact with Mat.
> > > > > > > > I talked about it with the contributor Jonathan Bell about
> > > > reasoning.
> > > > > > > > T
> > > > > > > >
> > > > > > > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <
> > olamy@apache.org>
> > > > > > wrote:
> > > > > > > >
> > > > > > > > > Hi
> > > > > > > > > Starting again this thread as we agreed but I didn't do it.
> > > > > > > > > So I'd like to cut release 3.0.0-M4 by the end of this
> week.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <
> > > > tibordigana@apache.org
> > > > > >
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > The SUREFIRE-1689 progress has been finished until the CI
> > > build
> > > > > > > > succeeds.
> > > > > > > > > > T
> > > > > > > > > >
> > > > > > > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > > > > > > rfscholte@apache.org>
> > > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Ah, there it is :)
> > > > > > > > > > >
> > > > > > > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > > > > > > > > > <rm...@gmail.com> wrote:
> > > > > > > > > > >
> > > > > > > > > > > > Didnt expect my comment about shade to take so much
> > space
> > > > in
> > > > > > this
> > > > > > > > > > thread
> > > > > > > > > > > > but yes we rely on asm for relocation:
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > > > > > > >
> > > > > > > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > > > > > > rfscholte@apache.org
> > > > > > > > >
> > > > > > > > > a
> > > > > > > > > > > > écrit :
> > > > > > > > > > > >
> > > > > > > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain
> Manni-Bucau
> > > > > > > > > > > >> <rm...@gmail.com> wrote:
> > > > > > > > > > > >>
> > > > > > > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > > > > > > rfscholte@apache.org>
> > > > > > > > > > a
> > > > > > > > > > > >> > écrit :
> > > > > > > > > > > >> >
> > > > > > > > > > > >> >> As far as I know, surefire won't touch the Plexus
> > > Java
> > > > > code
> > > > > > > > that
> > > > > > > > > > > >> >> requires
> > > > > > > > > > > >> >> ASM.
> > > > > > > > > > > >> >> It is ONLY required when the runtime is Java 8 or
> > > lower
> > > > > AND
> > > > > > > you
> > > > > > > > > > > need
> > > > > > > > > > > >> to
> > > > > > > > > > > >> >> read the module descriptors.
> > > > > > > > > > > >> >>
> > > > > > > > > > > >> >> Maven Shade is a different case: it must parse
> the
> > > Java
> > > > > > > > bytecode
> > > > > > > > > > (and
> > > > > > > > > > > >> >> only
> > > > > > > > > > > >> >> when using minifyJar), hence it needs the latest
> > ASM.
> > > > > > > > > > > >> >>
> > > > > > > > > > > >> >
> > > > > > > > > > > >> > + Relocation ;)
> > > > > > > > > > > >>
> > > > > > > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > > > > > > >>
> > > > > > > > > > > >>
> > > > > > > > > > > >>
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > > > > > > >>
> > > > > > > > > > > >> (but it might be better to do so...)
> > > > > > > > > > > >>
> > > > > > > > > > > >> >
> > > > > > > > > > > >> >
> > > > > > > > > > > >> >> Robert
> > > > > > > > > > > >> >>
> > > > > > > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > > > > > > > > > >> >> <ti...@apache.org>
> > > > > > > > > > > >> >>
> > > > > > > > > > > >> >> wrote:
> > > > > > > > > > > >> >>
> > > > > > > > > > > >> >> > We still use plexus-java:1.0.3 which depends on
> > ASM
> > > > > 7.0.
> > > > > > > > > > > >> >> > The support for JDk 13 and 14 is in the version
> > > 7.2.
> > > > > > > > > > > >> >> > We have similar upgrade in
> > > > > > > > > > > >> >> >
> > > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > > > > > > >> >> >
> > > > > > > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> > > > > > > > olamy@apache.org
> > > > > > > > > >
> > > > > > > > > > > >> wrote:
> > > > > > > > > > > >> >> >
> > > > > > > > > > > >> >> >> Hi,
> > > > > > > > > > > >> >> >> It's now almost 10 months since last and
> around
> > 30
> > > > > > issues
> > > > > > > > > fixed.
> > > > > > > > > > > >> >> >> Maybe time for a new release?
> > > > > > > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > > > > > > >> >> >>
> > > > > > > > > > > >> >> >> cheers
> > > > > > > > > > > >> >> >> --
> > > > > > > > > > > >> >> >> Olivier Lamy
> > > > > > > > > > > >> >>
> > > > > > > > > > > >> >>
> > > > > > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > > > > > > >> >> To unsubscribe, e-mail:
> > > > dev-unsubscribe@maven.apache.org
> > > > > > > > > > > >> >> For additional commands, e-mail:
> > > > > dev-help@maven.apache.org
> > > > > > > > > > > >> >>
> > > > > > > > > > > >>
> > > > > > > > > > > >>
> > > > > > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > > > > > > > >> To unsubscribe, e-mail:
> > > dev-unsubscribe@maven.apache.org
> > > > > > > > > > > >> For additional commands, e-mail:
> > > > dev-help@maven.apache.org
> > > > > > > > > > > >>
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > > > > > To unsubscribe, e-mail:
> dev-unsubscribe@maven.apache.org
> > > > > > > > > > > For additional commands, e-mail:
> > dev-help@maven.apache.org
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
Roman, it does not make sense to continue with you because you do not
understand the whole track with this project, and again nobody said
anything about architecture. It's your permanent opinions and very bad
attitude. So it is waste of the time to continue to explain the same things
over rand over again to You.
Read emails and understand them first or or just watch the ML if you do not
want to understand it.
On Mon, Nov 11, 2019 at 5:21 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> @Tibor: point is more that we don't need to hold a milestone for a feature,
> we can just release and let fixes get out and get this huge architectural
> change in another milestone. Only valid reason to delay a release is IMO a
> regression or a major change we can't revert later (3.0.0 would be in this
> bucket, not a milestone).
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 11 nov. 2019 à 16:54, Tibor Digana <ti...@apache.org> a
> écrit :
>
> > The reason of M4 was to introduce TCP communication.
> > Meanwhile first we wanted to cut the release one month ago but we
> postponed
> > it and we were waiting for clarifying license issues and fixed J13 issue
> > yesterday.
> > I was working on TCP/Pipes together with Jonathan Bell and we wanted to
> > make it in M4 which was our plan but we still have only 35% of the total
> > work and there are several things which are too detailed to mention. So
> > this has to continue and my estimation is that we need to spend 20 days.
> We
> > were working on it quite intensively in the background created few PRs
> and
> > moved the code from one PR to another and clarified it.
> > Yesterday I proposed to Jonathan that it does not make sense to work on
> our
> > taks like a hell because it would prolong the development which would
> take
> > too long.
> > So this is the whole reason, otherwise we could already include TCP/Pipes
> > into M4.
> > T
> >
> >
> >
> > On Mon, Nov 11, 2019 at 2:29 PM Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > wrote:
> >
> > > +1 to release next week, no reason to wait since it is another "m"
> > release
> > > IMHO
> > >
> > > Le lun. 11 nov. 2019 à 12:44, Olivier Lamy <ol...@apache.org> a écrit
> :
> > >
> > > > That will be great.
> > > > If you don't have time before end of the week. I'm happy to help and
> do
> > > it.
> > > > cheers
> > > > Olivier
> > > >
> > > > On Mon, 11 Nov 2019 at 21:35, Tibor Digana <ti...@apache.org>
> > > wrote:
> > > >
> > > > > @Olivier as we clarified this Slack. The release will be fast. No
> > > delay!
> > > > >
> > > > > On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <ol...@apache.org>
> > > wrote:
> > > > >
> > > > > > Why? delay again
> > > > > > I thought 1 month ago we agreed ago to move non finished stuff to
> > > > > 3.0.0-M5
> > > > > > and release 3.0.0-M5 later.
> > > > > >
> > > > > >
> > > > > > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <
> tibordigana@apache.org
> > >
> > > > > wrote:
> > > > > >
> > > > > > > Pls don't do it.
> > > > > > > I will cut it and move some issues to M5 but I need Matt to
> > finish
> > > > his
> > > > > > > work. I am in contact with Mat.
> > > > > > > I talked about it with the contributor Jonathan Bell about
> > > reasoning.
> > > > > > > T
> > > > > > >
> > > > > > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <
> olamy@apache.org>
> > > > > wrote:
> > > > > > >
> > > > > > > > Hi
> > > > > > > > Starting again this thread as we agreed but I didn't do it.
> > > > > > > > So I'd like to cut release 3.0.0-M4 by the end of this week.
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <
> > > tibordigana@apache.org
> > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > The SUREFIRE-1689 progress has been finished until the CI
> > build
> > > > > > > succeeds.
> > > > > > > > > T
> > > > > > > > >
> > > > > > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > > > > > rfscholte@apache.org>
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Ah, there it is :)
> > > > > > > > > >
> > > > > > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > > > > > > > > <rm...@gmail.com> wrote:
> > > > > > > > > >
> > > > > > > > > > > Didnt expect my comment about shade to take so much
> space
> > > in
> > > > > this
> > > > > > > > > thread
> > > > > > > > > > > but yes we rely on asm for relocation:
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > > > > > >
> > > > > > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > > > > > rfscholte@apache.org
> > > > > > > >
> > > > > > > > a
> > > > > > > > > > > écrit :
> > > > > > > > > > >
> > > > > > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > > > > > > > > > >> <rm...@gmail.com> wrote:
> > > > > > > > > > >>
> > > > > > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > > > > > rfscholte@apache.org>
> > > > > > > > > a
> > > > > > > > > > >> > écrit :
> > > > > > > > > > >> >
> > > > > > > > > > >> >> As far as I know, surefire won't touch the Plexus
> > Java
> > > > code
> > > > > > > that
> > > > > > > > > > >> >> requires
> > > > > > > > > > >> >> ASM.
> > > > > > > > > > >> >> It is ONLY required when the runtime is Java 8 or
> > lower
> > > > AND
> > > > > > you
> > > > > > > > > > need
> > > > > > > > > > >> to
> > > > > > > > > > >> >> read the module descriptors.
> > > > > > > > > > >> >>
> > > > > > > > > > >> >> Maven Shade is a different case: it must parse the
> > Java
> > > > > > > bytecode
> > > > > > > > > (and
> > > > > > > > > > >> >> only
> > > > > > > > > > >> >> when using minifyJar), hence it needs the latest
> ASM.
> > > > > > > > > > >> >>
> > > > > > > > > > >> >
> > > > > > > > > > >> > + Relocation ;)
> > > > > > > > > > >>
> > > > > > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > > > > > >>
> > > > > > > > > > >> (but it might be better to do so...)
> > > > > > > > > > >>
> > > > > > > > > > >> >
> > > > > > > > > > >> >
> > > > > > > > > > >> >> Robert
> > > > > > > > > > >> >>
> > > > > > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > > > > > > > > >> >> <ti...@apache.org>
> > > > > > > > > > >> >>
> > > > > > > > > > >> >> wrote:
> > > > > > > > > > >> >>
> > > > > > > > > > >> >> > We still use plexus-java:1.0.3 which depends on
> ASM
> > > > 7.0.
> > > > > > > > > > >> >> > The support for JDk 13 and 14 is in the version
> > 7.2.
> > > > > > > > > > >> >> > We have similar upgrade in
> > > > > > > > > > >> >> >
> > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > > > > > >> >> >
> > > > > > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> > > > > > > olamy@apache.org
> > > > > > > > >
> > > > > > > > > > >> wrote:
> > > > > > > > > > >> >> >
> > > > > > > > > > >> >> >> Hi,
> > > > > > > > > > >> >> >> It's now almost 10 months since last and around
> 30
> > > > > issues
> > > > > > > > fixed.
> > > > > > > > > > >> >> >> Maybe time for a new release?
> > > > > > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > > > > > >> >> >>
> > > > > > > > > > >> >> >> cheers
> > > > > > > > > > >> >> >> --
> > > > > > > > > > >> >> >> Olivier Lamy
> > > > > > > > > > >> >>
> > > > > > > > > > >> >>
> > > > > > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > > > > > > >> >> To unsubscribe, e-mail:
> > > dev-unsubscribe@maven.apache.org
> > > > > > > > > > >> >> For additional commands, e-mail:
> > > > dev-help@maven.apache.org
> > > > > > > > > > >> >>
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > > > >> To unsubscribe, e-mail:
> > dev-unsubscribe@maven.apache.org
> > > > > > > > > > >> For additional commands, e-mail:
> > > dev-help@maven.apache.org
> > > > > > > > > > >>
> > > > > > > > > >
> > > > > > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > > > > For additional commands, e-mail:
> dev-help@maven.apache.org
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
@Tibor: point is more that we don't need to hold a milestone for a feature,
we can just release and let fixes get out and get this huge architectural
change in another milestone. Only valid reason to delay a release is IMO a
regression or a major change we can't revert later (3.0.0 would be in this
bucket, not a milestone).
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 11 nov. 2019 à 16:54, Tibor Digana <ti...@apache.org> a
écrit :
> The reason of M4 was to introduce TCP communication.
> Meanwhile first we wanted to cut the release one month ago but we postponed
> it and we were waiting for clarifying license issues and fixed J13 issue
> yesterday.
> I was working on TCP/Pipes together with Jonathan Bell and we wanted to
> make it in M4 which was our plan but we still have only 35% of the total
> work and there are several things which are too detailed to mention. So
> this has to continue and my estimation is that we need to spend 20 days. We
> were working on it quite intensively in the background created few PRs and
> moved the code from one PR to another and clarified it.
> Yesterday I proposed to Jonathan that it does not make sense to work on our
> taks like a hell because it would prolong the development which would take
> too long.
> So this is the whole reason, otherwise we could already include TCP/Pipes
> into M4.
> T
>
>
>
> On Mon, Nov 11, 2019 at 2:29 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > +1 to release next week, no reason to wait since it is another "m"
> release
> > IMHO
> >
> > Le lun. 11 nov. 2019 à 12:44, Olivier Lamy <ol...@apache.org> a écrit :
> >
> > > That will be great.
> > > If you don't have time before end of the week. I'm happy to help and do
> > it.
> > > cheers
> > > Olivier
> > >
> > > On Mon, 11 Nov 2019 at 21:35, Tibor Digana <ti...@apache.org>
> > wrote:
> > >
> > > > @Olivier as we clarified this Slack. The release will be fast. No
> > delay!
> > > >
> > > > On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <ol...@apache.org>
> > wrote:
> > > >
> > > > > Why? delay again
> > > > > I thought 1 month ago we agreed ago to move non finished stuff to
> > > > 3.0.0-M5
> > > > > and release 3.0.0-M5 later.
> > > > >
> > > > >
> > > > > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <tibordigana@apache.org
> >
> > > > wrote:
> > > > >
> > > > > > Pls don't do it.
> > > > > > I will cut it and move some issues to M5 but I need Matt to
> finish
> > > his
> > > > > > work. I am in contact with Mat.
> > > > > > I talked about it with the contributor Jonathan Bell about
> > reasoning.
> > > > > > T
> > > > > >
> > > > > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <ol...@apache.org>
> > > > wrote:
> > > > > >
> > > > > > > Hi
> > > > > > > Starting again this thread as we agreed but I didn't do it.
> > > > > > > So I'd like to cut release 3.0.0-M4 by the end of this week.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <
> > tibordigana@apache.org
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > The SUREFIRE-1689 progress has been finished until the CI
> build
> > > > > > succeeds.
> > > > > > > > T
> > > > > > > >
> > > > > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > > > > rfscholte@apache.org>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Ah, there it is :)
> > > > > > > > >
> > > > > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > > > > > > > <rm...@gmail.com> wrote:
> > > > > > > > >
> > > > > > > > > > Didnt expect my comment about shade to take so much space
> > in
> > > > this
> > > > > > > > thread
> > > > > > > > > > but yes we rely on asm for relocation:
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > > > > >
> > > > > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > > > > rfscholte@apache.org
> > > > > > >
> > > > > > > a
> > > > > > > > > > écrit :
> > > > > > > > > >
> > > > > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > > > > > > > > >> <rm...@gmail.com> wrote:
> > > > > > > > > >>
> > > > > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > > > > rfscholte@apache.org>
> > > > > > > > a
> > > > > > > > > >> > écrit :
> > > > > > > > > >> >
> > > > > > > > > >> >> As far as I know, surefire won't touch the Plexus
> Java
> > > code
> > > > > > that
> > > > > > > > > >> >> requires
> > > > > > > > > >> >> ASM.
> > > > > > > > > >> >> It is ONLY required when the runtime is Java 8 or
> lower
> > > AND
> > > > > you
> > > > > > > > > need
> > > > > > > > > >> to
> > > > > > > > > >> >> read the module descriptors.
> > > > > > > > > >> >>
> > > > > > > > > >> >> Maven Shade is a different case: it must parse the
> Java
> > > > > > bytecode
> > > > > > > > (and
> > > > > > > > > >> >> only
> > > > > > > > > >> >> when using minifyJar), hence it needs the latest ASM.
> > > > > > > > > >> >>
> > > > > > > > > >> >
> > > > > > > > > >> > + Relocation ;)
> > > > > > > > > >>
> > > > > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > > > > >>
> > > > > > > > > >> (but it might be better to do so...)
> > > > > > > > > >>
> > > > > > > > > >> >
> > > > > > > > > >> >
> > > > > > > > > >> >> Robert
> > > > > > > > > >> >>
> > > > > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > > > > > > > >> >> <ti...@apache.org>
> > > > > > > > > >> >>
> > > > > > > > > >> >> wrote:
> > > > > > > > > >> >>
> > > > > > > > > >> >> > We still use plexus-java:1.0.3 which depends on ASM
> > > 7.0.
> > > > > > > > > >> >> > The support for JDk 13 and 14 is in the version
> 7.2.
> > > > > > > > > >> >> > We have similar upgrade in
> > > > > > > > > >> >> >
> https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > > > > >> >> >
> > > > > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> > > > > > olamy@apache.org
> > > > > > > >
> > > > > > > > > >> wrote:
> > > > > > > > > >> >> >
> > > > > > > > > >> >> >> Hi,
> > > > > > > > > >> >> >> It's now almost 10 months since last and around 30
> > > > issues
> > > > > > > fixed.
> > > > > > > > > >> >> >> Maybe time for a new release?
> > > > > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > > > > >> >> >>
> > > > > > > > > >> >> >> cheers
> > > > > > > > > >> >> >> --
> > > > > > > > > >> >> >> Olivier Lamy
> > > > > > > > > >> >>
> > > > > > > > > >> >>
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > > >> >> To unsubscribe, e-mail:
> > dev-unsubscribe@maven.apache.org
> > > > > > > > > >> >> For additional commands, e-mail:
> > > dev-help@maven.apache.org
> > > > > > > > > >> >>
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > > > >> To unsubscribe, e-mail:
> dev-unsubscribe@maven.apache.org
> > > > > > > > > >> For additional commands, e-mail:
> > dev-help@maven.apache.org
> > > > > > > > > >>
> > > > > > > > >
> > > > > > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
The reason of M4 was to introduce TCP communication.
Meanwhile first we wanted to cut the release one month ago but we postponed
it and we were waiting for clarifying license issues and fixed J13 issue
yesterday.
I was working on TCP/Pipes together with Jonathan Bell and we wanted to
make it in M4 which was our plan but we still have only 35% of the total
work and there are several things which are too detailed to mention. So
this has to continue and my estimation is that we need to spend 20 days. We
were working on it quite intensively in the background created few PRs and
moved the code from one PR to another and clarified it.
Yesterday I proposed to Jonathan that it does not make sense to work on our
taks like a hell because it would prolong the development which would take
too long.
So this is the whole reason, otherwise we could already include TCP/Pipes
into M4.
T
On Mon, Nov 11, 2019 at 2:29 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> +1 to release next week, no reason to wait since it is another "m" release
> IMHO
>
> Le lun. 11 nov. 2019 à 12:44, Olivier Lamy <ol...@apache.org> a écrit :
>
> > That will be great.
> > If you don't have time before end of the week. I'm happy to help and do
> it.
> > cheers
> > Olivier
> >
> > On Mon, 11 Nov 2019 at 21:35, Tibor Digana <ti...@apache.org>
> wrote:
> >
> > > @Olivier as we clarified this Slack. The release will be fast. No
> delay!
> > >
> > > On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <ol...@apache.org>
> wrote:
> > >
> > > > Why? delay again
> > > > I thought 1 month ago we agreed ago to move non finished stuff to
> > > 3.0.0-M5
> > > > and release 3.0.0-M5 later.
> > > >
> > > >
> > > > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <ti...@apache.org>
> > > wrote:
> > > >
> > > > > Pls don't do it.
> > > > > I will cut it and move some issues to M5 but I need Matt to finish
> > his
> > > > > work. I am in contact with Mat.
> > > > > I talked about it with the contributor Jonathan Bell about
> reasoning.
> > > > > T
> > > > >
> > > > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <ol...@apache.org>
> > > wrote:
> > > > >
> > > > > > Hi
> > > > > > Starting again this thread as we agreed but I didn't do it.
> > > > > > So I'd like to cut release 3.0.0-M4 by the end of this week.
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <
> tibordigana@apache.org
> > >
> > > > > wrote:
> > > > > >
> > > > > > > The SUREFIRE-1689 progress has been finished until the CI build
> > > > > succeeds.
> > > > > > > T
> > > > > > >
> > > > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > > > rfscholte@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Ah, there it is :)
> > > > > > > >
> > > > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > > > > > > <rm...@gmail.com> wrote:
> > > > > > > >
> > > > > > > > > Didnt expect my comment about shade to take so much space
> in
> > > this
> > > > > > > thread
> > > > > > > > > but yes we rely on asm for relocation:
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > > > >
> > > > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > > > rfscholte@apache.org
> > > > > >
> > > > > > a
> > > > > > > > > écrit :
> > > > > > > > >
> > > > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > > > > > > > >> <rm...@gmail.com> wrote:
> > > > > > > > >>
> > > > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > > > rfscholte@apache.org>
> > > > > > > a
> > > > > > > > >> > écrit :
> > > > > > > > >> >
> > > > > > > > >> >> As far as I know, surefire won't touch the Plexus Java
> > code
> > > > > that
> > > > > > > > >> >> requires
> > > > > > > > >> >> ASM.
> > > > > > > > >> >> It is ONLY required when the runtime is Java 8 or lower
> > AND
> > > > you
> > > > > > > > need
> > > > > > > > >> to
> > > > > > > > >> >> read the module descriptors.
> > > > > > > > >> >>
> > > > > > > > >> >> Maven Shade is a different case: it must parse the Java
> > > > > bytecode
> > > > > > > (and
> > > > > > > > >> >> only
> > > > > > > > >> >> when using minifyJar), hence it needs the latest ASM.
> > > > > > > > >> >>
> > > > > > > > >> >
> > > > > > > > >> > + Relocation ;)
> > > > > > > > >>
> > > > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > > > >>
> > > > > > > > >> (but it might be better to do so...)
> > > > > > > > >>
> > > > > > > > >> >
> > > > > > > > >> >
> > > > > > > > >> >> Robert
> > > > > > > > >> >>
> > > > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > > > > > > >> >> <ti...@apache.org>
> > > > > > > > >> >>
> > > > > > > > >> >> wrote:
> > > > > > > > >> >>
> > > > > > > > >> >> > We still use plexus-java:1.0.3 which depends on ASM
> > 7.0.
> > > > > > > > >> >> > The support for JDk 13 and 14 is in the version 7.2.
> > > > > > > > >> >> > We have similar upgrade in
> > > > > > > > >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > > > >> >> >
> > > > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> > > > > olamy@apache.org
> > > > > > >
> > > > > > > > >> wrote:
> > > > > > > > >> >> >
> > > > > > > > >> >> >> Hi,
> > > > > > > > >> >> >> It's now almost 10 months since last and around 30
> > > issues
> > > > > > fixed.
> > > > > > > > >> >> >> Maybe time for a new release?
> > > > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > > > >> >> >>
> > > > > > > > >> >> >> cheers
> > > > > > > > >> >> >> --
> > > > > > > > >> >> >> Olivier Lamy
> > > > > > > > >> >>
> > > > > > > > >> >>
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > > >> >> To unsubscribe, e-mail:
> dev-unsubscribe@maven.apache.org
> > > > > > > > >> >> For additional commands, e-mail:
> > dev-help@maven.apache.org
> > > > > > > > >> >>
> > > > > > > > >>
> > > > > > > > >>
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > > >> For additional commands, e-mail:
> dev-help@maven.apache.org
> > > > > > > > >>
> > > > > > > >
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1 to release next week, no reason to wait since it is another "m" release
IMHO
Le lun. 11 nov. 2019 à 12:44, Olivier Lamy <ol...@apache.org> a écrit :
> That will be great.
> If you don't have time before end of the week. I'm happy to help and do it.
> cheers
> Olivier
>
> On Mon, 11 Nov 2019 at 21:35, Tibor Digana <ti...@apache.org> wrote:
>
> > @Olivier as we clarified this Slack. The release will be fast. No delay!
> >
> > On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <ol...@apache.org> wrote:
> >
> > > Why? delay again
> > > I thought 1 month ago we agreed ago to move non finished stuff to
> > 3.0.0-M5
> > > and release 3.0.0-M5 later.
> > >
> > >
> > > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <ti...@apache.org>
> > wrote:
> > >
> > > > Pls don't do it.
> > > > I will cut it and move some issues to M5 but I need Matt to finish
> his
> > > > work. I am in contact with Mat.
> > > > I talked about it with the contributor Jonathan Bell about reasoning.
> > > > T
> > > >
> > > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <ol...@apache.org>
> > wrote:
> > > >
> > > > > Hi
> > > > > Starting again this thread as we agreed but I didn't do it.
> > > > > So I'd like to cut release 3.0.0-M4 by the end of this week.
> > > > >
> > > > >
> > > > >
> > > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <tibordigana@apache.org
> >
> > > > wrote:
> > > > >
> > > > > > The SUREFIRE-1689 progress has been finished until the CI build
> > > > succeeds.
> > > > > > T
> > > > > >
> > > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > > rfscholte@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > Ah, there it is :)
> > > > > > >
> > > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > > > > > <rm...@gmail.com> wrote:
> > > > > > >
> > > > > > > > Didnt expect my comment about shade to take so much space in
> > this
> > > > > > thread
> > > > > > > > but yes we rely on asm for relocation:
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > > >
> > > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > > rfscholte@apache.org
> > > > >
> > > > > a
> > > > > > > > écrit :
> > > > > > > >
> > > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > > > > > > >> <rm...@gmail.com> wrote:
> > > > > > > >>
> > > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > > rfscholte@apache.org>
> > > > > > a
> > > > > > > >> > écrit :
> > > > > > > >> >
> > > > > > > >> >> As far as I know, surefire won't touch the Plexus Java
> code
> > > > that
> > > > > > > >> >> requires
> > > > > > > >> >> ASM.
> > > > > > > >> >> It is ONLY required when the runtime is Java 8 or lower
> AND
> > > you
> > > > > > > need
> > > > > > > >> to
> > > > > > > >> >> read the module descriptors.
> > > > > > > >> >>
> > > > > > > >> >> Maven Shade is a different case: it must parse the Java
> > > > bytecode
> > > > > > (and
> > > > > > > >> >> only
> > > > > > > >> >> when using minifyJar), hence it needs the latest ASM.
> > > > > > > >> >>
> > > > > > > >> >
> > > > > > > >> > + Relocation ;)
> > > > > > > >>
> > > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > > >>
> > > > > > > >> (but it might be better to do so...)
> > > > > > > >>
> > > > > > > >> >
> > > > > > > >> >
> > > > > > > >> >> Robert
> > > > > > > >> >>
> > > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > > > > > >> >> <ti...@apache.org>
> > > > > > > >> >>
> > > > > > > >> >> wrote:
> > > > > > > >> >>
> > > > > > > >> >> > We still use plexus-java:1.0.3 which depends on ASM
> 7.0.
> > > > > > > >> >> > The support for JDk 13 and 14 is in the version 7.2.
> > > > > > > >> >> > We have similar upgrade in
> > > > > > > >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > > >> >> >
> > > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> > > > olamy@apache.org
> > > > > >
> > > > > > > >> wrote:
> > > > > > > >> >> >
> > > > > > > >> >> >> Hi,
> > > > > > > >> >> >> It's now almost 10 months since last and around 30
> > issues
> > > > > fixed.
> > > > > > > >> >> >> Maybe time for a new release?
> > > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > > >> >> >>
> > > > > > > >> >> >> cheers
> > > > > > > >> >> >> --
> > > > > > > >> >> >> Olivier Lamy
> > > > > > > >> >>
> > > > > > > >> >>
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > > >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > >> >> For additional commands, e-mail:
> dev-help@maven.apache.org
> > > > > > > >> >>
> > > > > > > >>
> > > > > > > >>
> > > > >
> ---------------------------------------------------------------------
> > > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > > >>
> > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Olivier Lamy <ol...@apache.org>.
That will be great.
If you don't have time before end of the week. I'm happy to help and do it.
cheers
Olivier
On Mon, 11 Nov 2019 at 21:35, Tibor Digana <ti...@apache.org> wrote:
> @Olivier as we clarified this Slack. The release will be fast. No delay!
>
> On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <ol...@apache.org> wrote:
>
> > Why? delay again
> > I thought 1 month ago we agreed ago to move non finished stuff to
> 3.0.0-M5
> > and release 3.0.0-M5 later.
> >
> >
> > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <ti...@apache.org>
> wrote:
> >
> > > Pls don't do it.
> > > I will cut it and move some issues to M5 but I need Matt to finish his
> > > work. I am in contact with Mat.
> > > I talked about it with the contributor Jonathan Bell about reasoning.
> > > T
> > >
> > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <ol...@apache.org>
> wrote:
> > >
> > > > Hi
> > > > Starting again this thread as we agreed but I didn't do it.
> > > > So I'd like to cut release 3.0.0-M4 by the end of this week.
> > > >
> > > >
> > > >
> > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <ti...@apache.org>
> > > wrote:
> > > >
> > > > > The SUREFIRE-1689 progress has been finished until the CI build
> > > succeeds.
> > > > > T
> > > > >
> > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > rfscholte@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Ah, there it is :)
> > > > > >
> > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > > > > <rm...@gmail.com> wrote:
> > > > > >
> > > > > > > Didnt expect my comment about shade to take so much space in
> this
> > > > > thread
> > > > > > > but yes we rely on asm for relocation:
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > >
> > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > rfscholte@apache.org
> > > >
> > > > a
> > > > > > > écrit :
> > > > > > >
> > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > > > > > >> <rm...@gmail.com> wrote:
> > > > > > >>
> > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > rfscholte@apache.org>
> > > > > a
> > > > > > >> > écrit :
> > > > > > >> >
> > > > > > >> >> As far as I know, surefire won't touch the Plexus Java code
> > > that
> > > > > > >> >> requires
> > > > > > >> >> ASM.
> > > > > > >> >> It is ONLY required when the runtime is Java 8 or lower AND
> > you
> > > > > > need
> > > > > > >> to
> > > > > > >> >> read the module descriptors.
> > > > > > >> >>
> > > > > > >> >> Maven Shade is a different case: it must parse the Java
> > > bytecode
> > > > > (and
> > > > > > >> >> only
> > > > > > >> >> when using minifyJar), hence it needs the latest ASM.
> > > > > > >> >>
> > > > > > >> >
> > > > > > >> > + Relocation ;)
> > > > > > >>
> > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > >>
> > > > > > >> (but it might be better to do so...)
> > > > > > >>
> > > > > > >> >
> > > > > > >> >
> > > > > > >> >> Robert
> > > > > > >> >>
> > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > > > > >> >> <ti...@apache.org>
> > > > > > >> >>
> > > > > > >> >> wrote:
> > > > > > >> >>
> > > > > > >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > > > > >> >> > The support for JDk 13 and 14 is in the version 7.2.
> > > > > > >> >> > We have similar upgrade in
> > > > > > >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > >> >> >
> > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> > > olamy@apache.org
> > > > >
> > > > > > >> wrote:
> > > > > > >> >> >
> > > > > > >> >> >> Hi,
> > > > > > >> >> >> It's now almost 10 months since last and around 30
> issues
> > > > fixed.
> > > > > > >> >> >> Maybe time for a new release?
> > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > >> >> >>
> > > > > > >> >> >> cheers
> > > > > > >> >> >> --
> > > > > > >> >> >> Olivier Lamy
> > > > > > >> >>
> > > > > > >> >>
> > > > >
> ---------------------------------------------------------------------
> > > > > > >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > >> >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >> >>
> > > > > > >>
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >>
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >
> > > > > >
> > > > >
> > > >
> > > >
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
@Olivier as we clarified this Slack. The release will be fast. No delay!
On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <ol...@apache.org> wrote:
> Why? delay again
> I thought 1 month ago we agreed ago to move non finished stuff to 3.0.0-M5
> and release 3.0.0-M5 later.
>
>
> On Mon, 11 Nov 2019 at 20:59, Tibor Digana <ti...@apache.org> wrote:
>
> > Pls don't do it.
> > I will cut it and move some issues to M5 but I need Matt to finish his
> > work. I am in contact with Mat.
> > I talked about it with the contributor Jonathan Bell about reasoning.
> > T
> >
> > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <ol...@apache.org> wrote:
> >
> > > Hi
> > > Starting again this thread as we agreed but I didn't do it.
> > > So I'd like to cut release 3.0.0-M4 by the end of this week.
> > >
> > >
> > >
> > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <ti...@apache.org>
> > wrote:
> > >
> > > > The SUREFIRE-1689 progress has been finished until the CI build
> > succeeds.
> > > > T
> > > >
> > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> rfscholte@apache.org>
> > > > wrote:
> > > >
> > > > > Ah, there it is :)
> > > > >
> > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > > > <rm...@gmail.com> wrote:
> > > > >
> > > > > > Didnt expect my comment about shade to take so much space in this
> > > > thread
> > > > > > but yes we rely on asm for relocation:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > >
> > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> rfscholte@apache.org
> > >
> > > a
> > > > > > écrit :
> > > > > >
> > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > > > > >> <rm...@gmail.com> wrote:
> > > > > >>
> > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > rfscholte@apache.org>
> > > > a
> > > > > >> > écrit :
> > > > > >> >
> > > > > >> >> As far as I know, surefire won't touch the Plexus Java code
> > that
> > > > > >> >> requires
> > > > > >> >> ASM.
> > > > > >> >> It is ONLY required when the runtime is Java 8 or lower AND
> you
> > > > > need
> > > > > >> to
> > > > > >> >> read the module descriptors.
> > > > > >> >>
> > > > > >> >> Maven Shade is a different case: it must parse the Java
> > bytecode
> > > > (and
> > > > > >> >> only
> > > > > >> >> when using minifyJar), hence it needs the latest ASM.
> > > > > >> >>
> > > > > >> >
> > > > > >> > + Relocation ;)
> > > > > >>
> > > > > >> Well, the unexpected answer is actually No, see
> > > > > >>
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > >>
> > > > > >> (but it might be better to do so...)
> > > > > >>
> > > > > >> >
> > > > > >> >
> > > > > >> >> Robert
> > > > > >> >>
> > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > > > >> >> <ti...@apache.org>
> > > > > >> >>
> > > > > >> >> wrote:
> > > > > >> >>
> > > > > >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > > > >> >> > The support for JDk 13 and 14 is in the version 7.2.
> > > > > >> >> > We have similar upgrade in
> > > > > >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > >> >> >
> > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> > olamy@apache.org
> > > >
> > > > > >> wrote:
> > > > > >> >> >
> > > > > >> >> >> Hi,
> > > > > >> >> >> It's now almost 10 months since last and around 30 issues
> > > fixed.
> > > > > >> >> >> Maybe time for a new release?
> > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > >> >> >>
> > > > > >> >> >> cheers
> > > > > >> >> >> --
> > > > > >> >> >> Olivier Lamy
> > > > > >> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > > > >> >>
> > > > > >> >>
> > > > ---------------------------------------------------------------------
> > > > > >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > >> >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >> >>
> > > > > >>
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >>
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > >
> > > > >
> > > >
> > >
> > >
> > > --
> > > Olivier Lamy
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: Surefire 3.0.0-M4 release?
Posted by Olivier Lamy <ol...@apache.org>.
Why? delay again
I thought 1 month ago we agreed ago to move non finished stuff to 3.0.0-M5
and release 3.0.0-M5 later.
On Mon, 11 Nov 2019 at 20:59, Tibor Digana <ti...@apache.org> wrote:
> Pls don't do it.
> I will cut it and move some issues to M5 but I need Matt to finish his
> work. I am in contact with Mat.
> I talked about it with the contributor Jonathan Bell about reasoning.
> T
>
> On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <ol...@apache.org> wrote:
>
> > Hi
> > Starting again this thread as we agreed but I didn't do it.
> > So I'd like to cut release 3.0.0-M4 by the end of this week.
> >
> >
> >
> > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <ti...@apache.org>
> wrote:
> >
> > > The SUREFIRE-1689 progress has been finished until the CI build
> succeeds.
> > > T
> > >
> > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <rf...@apache.org>
> > > wrote:
> > >
> > > > Ah, there it is :)
> > > >
> > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > > <rm...@gmail.com> wrote:
> > > >
> > > > > Didnt expect my comment about shade to take so much space in this
> > > thread
> > > > > but yes we rely on asm for relocation:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > >
> > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <rfscholte@apache.org
> >
> > a
> > > > > écrit :
> > > > >
> > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > > > >> <rm...@gmail.com> wrote:
> > > > >>
> > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > rfscholte@apache.org>
> > > a
> > > > >> > écrit :
> > > > >> >
> > > > >> >> As far as I know, surefire won't touch the Plexus Java code
> that
> > > > >> >> requires
> > > > >> >> ASM.
> > > > >> >> It is ONLY required when the runtime is Java 8 or lower AND you
> > > > need
> > > > >> to
> > > > >> >> read the module descriptors.
> > > > >> >>
> > > > >> >> Maven Shade is a different case: it must parse the Java
> bytecode
> > > (and
> > > > >> >> only
> > > > >> >> when using minifyJar), hence it needs the latest ASM.
> > > > >> >>
> > > > >> >
> > > > >> > + Relocation ;)
> > > > >>
> > > > >> Well, the unexpected answer is actually No, see
> > > > >>
> > > > >>
> > > > >>
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > >>
> > > > >> (but it might be better to do so...)
> > > > >>
> > > > >> >
> > > > >> >
> > > > >> >> Robert
> > > > >> >>
> > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > > >> >> <ti...@apache.org>
> > > > >> >>
> > > > >> >> wrote:
> > > > >> >>
> > > > >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > > >> >> > The support for JDk 13 and 14 is in the version 7.2.
> > > > >> >> > We have similar upgrade in
> > > > >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> > > > >> >> >
> > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> olamy@apache.org
> > >
> > > > >> wrote:
> > > > >> >> >
> > > > >> >> >> Hi,
> > > > >> >> >> It's now almost 10 months since last and around 30 issues
> > fixed.
> > > > >> >> >> Maybe time for a new release?
> > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > >> >> >>
> > > > >> >> >> cheers
> > > > >> >> >> --
> > > > >> >> >> Olivier Lamy
> > > > >> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > > >> >>
> > > > >> >>
> > > ---------------------------------------------------------------------
> > > > >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > >> >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > >> >>
> > > > >>
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > >>
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
Pls don't do it.
I will cut it and move some issues to M5 but I need Matt to finish his
work. I am in contact with Mat.
I talked about it with the contributor Jonathan Bell about reasoning.
T
On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <ol...@apache.org> wrote:
> Hi
> Starting again this thread as we agreed but I didn't do it.
> So I'd like to cut release 3.0.0-M4 by the end of this week.
>
>
>
> On Mon, 14 Oct 2019 at 11:40, Tibor Digana <ti...@apache.org> wrote:
>
> > The SUREFIRE-1689 progress has been finished until the CI build succeeds.
> > T
> >
> > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <rf...@apache.org>
> > wrote:
> >
> > > Ah, there it is :)
> > >
> > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > > <rm...@gmail.com> wrote:
> > >
> > > > Didnt expect my comment about shade to take so much space in this
> > thread
> > > > but yes we rely on asm for relocation:
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > >
> > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <rf...@apache.org>
> a
> > > > écrit :
> > > >
> > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > > >> <rm...@gmail.com> wrote:
> > > >>
> > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> rfscholte@apache.org>
> > a
> > > >> > écrit :
> > > >> >
> > > >> >> As far as I know, surefire won't touch the Plexus Java code that
> > > >> >> requires
> > > >> >> ASM.
> > > >> >> It is ONLY required when the runtime is Java 8 or lower AND you
> > > need
> > > >> to
> > > >> >> read the module descriptors.
> > > >> >>
> > > >> >> Maven Shade is a different case: it must parse the Java bytecode
> > (and
> > > >> >> only
> > > >> >> when using minifyJar), hence it needs the latest ASM.
> > > >> >>
> > > >> >
> > > >> > + Relocation ;)
> > > >>
> > > >> Well, the unexpected answer is actually No, see
> > > >>
> > > >>
> > > >>
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > >>
> > > >> (but it might be better to do so...)
> > > >>
> > > >> >
> > > >> >
> > > >> >> Robert
> > > >> >>
> > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > > >> >> <ti...@apache.org>
> > > >> >>
> > > >> >> wrote:
> > > >> >>
> > > >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > >> >> > The support for JDk 13 and 14 is in the version 7.2.
> > > >> >> > We have similar upgrade in
> > > >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> > > >> >> >
> > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <olamy@apache.org
> >
> > > >> wrote:
> > > >> >> >
> > > >> >> >> Hi,
> > > >> >> >> It's now almost 10 months since last and around 30 issues
> fixed.
> > > >> >> >> Maybe time for a new release?
> > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > >> >> >>
> > > >> >> >> cheers
> > > >> >> >> --
> > > >> >> >> Olivier Lamy
> > > >> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >> >>
> > > >> >>
> > ---------------------------------------------------------------------
> > > >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >> >> For additional commands, e-mail: dev-help@maven.apache.org
> > > >> >>
> > > >>
> > > >>
> ---------------------------------------------------------------------
> > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: Surefire 3.0.0-M4 release?
Posted by Olivier Lamy <ol...@apache.org>.
Hi
Starting again this thread as we agreed but I didn't do it.
So I'd like to cut release 3.0.0-M4 by the end of this week.
On Mon, 14 Oct 2019 at 11:40, Tibor Digana <ti...@apache.org> wrote:
> The SUREFIRE-1689 progress has been finished until the CI build succeeds.
> T
>
> On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <rf...@apache.org>
> wrote:
>
> > Ah, there it is :)
> >
> > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > <rm...@gmail.com> wrote:
> >
> > > Didnt expect my comment about shade to take so much space in this
> thread
> > > but yes we rely on asm for relocation:
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > >
> > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <rf...@apache.org> a
> > > écrit :
> > >
> > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > >> <rm...@gmail.com> wrote:
> > >>
> > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org>
> a
> > >> > écrit :
> > >> >
> > >> >> As far as I know, surefire won't touch the Plexus Java code that
> > >> >> requires
> > >> >> ASM.
> > >> >> It is ONLY required when the runtime is Java 8 or lower AND you
> > need
> > >> to
> > >> >> read the module descriptors.
> > >> >>
> > >> >> Maven Shade is a different case: it must parse the Java bytecode
> (and
> > >> >> only
> > >> >> when using minifyJar), hence it needs the latest ASM.
> > >> >>
> > >> >
> > >> > + Relocation ;)
> > >>
> > >> Well, the unexpected answer is actually No, see
> > >>
> > >>
> > >>
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > >>
> > >> (but it might be better to do so...)
> > >>
> > >> >
> > >> >
> > >> >> Robert
> > >> >>
> > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > >> >> <ti...@apache.org>
> > >> >>
> > >> >> wrote:
> > >> >>
> > >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > >> >> > The support for JDk 13 and 14 is in the version 7.2.
> > >> >> > We have similar upgrade in
> > >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> > >> >> >
> > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> > >> wrote:
> > >> >> >
> > >> >> >> Hi,
> > >> >> >> It's now almost 10 months since last and around 30 issues fixed.
> > >> >> >> Maybe time for a new release?
> > >> >> >> Moving issues still open to 3.0.0-M5?
> > >> >> >>
> > >> >> >> cheers
> > >> >> >> --
> > >> >> >> Olivier Lamy
> > >> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >> >>
> > >> >>
> ---------------------------------------------------------------------
> > >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> >> For additional commands, e-mail: dev-help@maven.apache.org
> > >> >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> For additional commands, e-mail: dev-help@maven.apache.org
> > >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
The SUREFIRE-1689 progress has been finished until the CI build succeeds.
T
On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <rf...@apache.org>
wrote:
> Ah, there it is :)
>
> On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> <rm...@gmail.com> wrote:
>
> > Didnt expect my comment about shade to take so much space in this thread
> > but yes we rely on asm for relocation:
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> >
> > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <rf...@apache.org> a
> > écrit :
> >
> >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> >> <rm...@gmail.com> wrote:
> >>
> >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
> >> > écrit :
> >> >
> >> >> As far as I know, surefire won't touch the Plexus Java code that
> >> >> requires
> >> >> ASM.
> >> >> It is ONLY required when the runtime is Java 8 or lower AND you
> need
> >> to
> >> >> read the module descriptors.
> >> >>
> >> >> Maven Shade is a different case: it must parse the Java bytecode (and
> >> >> only
> >> >> when using minifyJar), hence it needs the latest ASM.
> >> >>
> >> >
> >> > + Relocation ;)
> >>
> >> Well, the unexpected answer is actually No, see
> >>
> >>
> >>
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> >>
> >> (but it might be better to do so...)
> >>
> >> >
> >> >
> >> >> Robert
> >> >>
> >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> >> >> <ti...@apache.org>
> >> >>
> >> >> wrote:
> >> >>
> >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> >> >> > The support for JDk 13 and 14 is in the version 7.2.
> >> >> > We have similar upgrade in
> >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> >> >> >
> >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> >> wrote:
> >> >> >
> >> >> >> Hi,
> >> >> >> It's now almost 10 months since last and around 30 issues fixed.
> >> >> >> Maybe time for a new release?
> >> >> >> Moving issues still open to 3.0.0-M5?
> >> >> >>
> >> >> >> cheers
> >> >> >> --
> >> >> >> Olivier Lamy
> >> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> >> For additional commands, e-mail: dev-help@maven.apache.org
> >> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Surefire 3.0.0-M4 release?
Posted by Robert Scholte <rf...@apache.org>.
Ah, there it is :)
On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
<rm...@gmail.com> wrote:
> Didnt expect my comment about shade to take so much space in this thread
> but yes we rely on asm for relocation:
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
>
> Le dim. 13 oct. 2019 à 00:20, Robert Scholte <rf...@apache.org> a
> écrit :
>
>> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
>> <rm...@gmail.com> wrote:
>>
>> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
>> > écrit :
>> >
>> >> As far as I know, surefire won't touch the Plexus Java code that
>> >> requires
>> >> ASM.
>> >> It is ONLY required when the runtime is Java 8 or lower AND you need
>> to
>> >> read the module descriptors.
>> >>
>> >> Maven Shade is a different case: it must parse the Java bytecode (and
>> >> only
>> >> when using minifyJar), hence it needs the latest ASM.
>> >>
>> >
>> > + Relocation ;)
>>
>> Well, the unexpected answer is actually No, see
>>
>>
>> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
>>
>> (but it might be better to do so...)
>>
>> >
>> >
>> >> Robert
>> >>
>> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
>> >> <ti...@apache.org>
>> >>
>> >> wrote:
>> >>
>> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
>> >> > The support for JDk 13 and 14 is in the version 7.2.
>> >> > We have similar upgrade in
>> >> > https://github.com/apache/maven-shade-plugin/pull/29
>> >> >
>> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
>> wrote:
>> >> >
>> >> >> Hi,
>> >> >> It's now almost 10 months since last and around 30 issues fixed.
>> >> >> Maybe time for a new release?
>> >> >> Moving issues still open to 3.0.0-M5?
>> >> >>
>> >> >> cheers
>> >> >> --
>> >> >> Olivier Lamy
>> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Didnt expect my comment about shade to take so much space in this thread
but yes we rely on asm for relocation:
https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
Le dim. 13 oct. 2019 à 00:20, Robert Scholte <rf...@apache.org> a
écrit :
> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> <rm...@gmail.com> wrote:
>
> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
> > écrit :
> >
> >> As far as I know, surefire won't touch the Plexus Java code that
> >> requires
> >> ASM.
> >> It is ONLY required when the runtime is Java 8 or lower AND you need to
> >> read the module descriptors.
> >>
> >> Maven Shade is a different case: it must parse the Java bytecode (and
> >> only
> >> when using minifyJar), hence it needs the latest ASM.
> >>
> >
> > + Relocation ;)
>
> Well, the unexpected answer is actually No, see
>
>
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
>
> (but it might be better to do so...)
>
> >
> >
> >> Robert
> >>
> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> >> <ti...@apache.org>
> >>
> >> wrote:
> >>
> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> >> > The support for JDk 13 and 14 is in the version 7.2.
> >> > We have similar upgrade in
> >> > https://github.com/apache/maven-shade-plugin/pull/29
> >> >
> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> wrote:
> >> >
> >> >> Hi,
> >> >> It's now almost 10 months since last and around 30 issues fixed.
> >> >> Maybe time for a new release?
> >> >> Moving issues still open to 3.0.0-M5?
> >> >>
> >> >> cheers
> >> >> --
> >> >> Olivier Lamy
> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Surefire 3.0.0-M4 release?
Posted by Robert Scholte <rf...@apache.org>.
On Sun, 13 Oct 2019 00:35:51 +0200, Tibor Digana <ti...@apache.org>
wrote:
>>> It is ONLY required when the runtime is Java 8 or lower AND you need to
>>> read the module descriptors.
>
> thx for clarifying.
>
> Am i right if I say that it would happen with J9/Toolchain used in
> Compiler
> but J8 in the Maven build?
> Is it realistic?
> Maybe some people would do it due to some other plugins unreliable on J9+
> WDYT?
It depends on the purpose. Suppose there's a plugin that wants to do all
kinds of analysis on dependencies where Java 8 is good enough, expect for
the module decriptors, then this feature with ASM makes it possible.
>
>
>
>
>
>
>
> On Sun, Oct 13, 2019 at 12:20 AM Robert Scholte <rf...@apache.org>
> wrote:
>
>> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
>> <rm...@gmail.com> wrote:
>>
>> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
>> > écrit :
>> >
>> >> As far as I know, surefire won't touch the Plexus Java code that
>> >> requires
>> >> ASM.
>> >> It is ONLY required when the runtime is Java 8 or lower AND you need
>> to
>> >> read the module descriptors.
>> >>
>> >> Maven Shade is a different case: it must parse the Java bytecode (and
>> >> only
>> >> when using minifyJar), hence it needs the latest ASM.
>> >>
>> >
>> > + Relocation ;)
>>
>> Well, the unexpected answer is actually No, see
>>
>>
>> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
>>
>> (but it might be better to do so...)
>>
>> >
>> >
>> >> Robert
>> >>
>> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
>> >> <ti...@apache.org>
>> >>
>> >> wrote:
>> >>
>> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
>> >> > The support for JDk 13 and 14 is in the version 7.2.
>> >> > We have similar upgrade in
>> >> > https://github.com/apache/maven-shade-plugin/pull/29
>> >> >
>> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
>> wrote:
>> >> >
>> >> >> Hi,
>> >> >> It's now almost 10 months since last and around 30 issues fixed.
>> >> >> Maybe time for a new release?
>> >> >> Moving issues still open to 3.0.0-M5?
>> >> >>
>> >> >> cheers
>> >> >> --
>> >> >> Olivier Lamy
>> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
>> It is ONLY required when the runtime is Java 8 or lower AND you need to
>> read the module descriptors.
thx for clarifying.
Am i right if I say that it would happen with J9/Toolchain used in Compiler
but J8 in the Maven build?
Is it realistic?
Maybe some people would do it due to some other plugins unreliable on J9+
WDYT?
On Sun, Oct 13, 2019 at 12:20 AM Robert Scholte <rf...@apache.org>
wrote:
> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> <rm...@gmail.com> wrote:
>
> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
> > écrit :
> >
> >> As far as I know, surefire won't touch the Plexus Java code that
> >> requires
> >> ASM.
> >> It is ONLY required when the runtime is Java 8 or lower AND you need to
> >> read the module descriptors.
> >>
> >> Maven Shade is a different case: it must parse the Java bytecode (and
> >> only
> >> when using minifyJar), hence it needs the latest ASM.
> >>
> >
> > + Relocation ;)
>
> Well, the unexpected answer is actually No, see
>
>
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
>
> (but it might be better to do so...)
>
> >
> >
> >> Robert
> >>
> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> >> <ti...@apache.org>
> >>
> >> wrote:
> >>
> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> >> > The support for JDk 13 and 14 is in the version 7.2.
> >> > We have similar upgrade in
> >> > https://github.com/apache/maven-shade-plugin/pull/29
> >> >
> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> wrote:
> >> >
> >> >> Hi,
> >> >> It's now almost 10 months since last and around 30 issues fixed.
> >> >> Maybe time for a new release?
> >> >> Moving issues still open to 3.0.0-M5?
> >> >>
> >> >> cheers
> >> >> --
> >> >> Olivier Lamy
> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Surefire 3.0.0-M4 release?
Posted by Robert Scholte <rf...@apache.org>.
On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
<rm...@gmail.com> wrote:
> Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
> écrit :
>
>> As far as I know, surefire won't touch the Plexus Java code that
>> requires
>> ASM.
>> It is ONLY required when the runtime is Java 8 or lower AND you need to
>> read the module descriptors.
>>
>> Maven Shade is a different case: it must parse the Java bytecode (and
>> only
>> when using minifyJar), hence it needs the latest ASM.
>>
>
> + Relocation ;)
Well, the unexpected answer is actually No, see
https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
(but it might be better to do so...)
>
>
>> Robert
>>
>> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
>> <ti...@apache.org>
>>
>> wrote:
>>
>> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
>> > The support for JDk 13 and 14 is in the version 7.2.
>> > We have similar upgrade in
>> > https://github.com/apache/maven-shade-plugin/pull/29
>> >
>> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> wrote:
>> >
>> >> Hi,
>> >> It's now almost 10 months since last and around 30 issues fixed.
>> >> Maybe time for a new release?
>> >> Moving issues still open to 3.0.0-M5?
>> >>
>> >> cheers
>> >> --
>> >> Olivier Lamy
>> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
Because i understood you talking about relocating ASM within Surefire here
in this thread.
It did not make sense for me since the ASM always has to adapt to a new
bytecode.
So you mean relocating ASM in the m-shade-p, right?
User's dependencies are loaded in a separate classloader, no need to
relocate (plugin's dependency) ASM in Surefire plugin because it is used
only in MOJO and the plugin's dependency is not loaded to user's tests.
On Sat, Oct 12, 2019 at 11:42 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Not sure what you meant Tibor, just completed that relocation can need asm
> upgrade in shade plugin - if we dont want users to do it in the pom which
> is ok/needed if they use new java versions.
>
> Le sam. 12 oct. 2019 à 20:24, Tibor Digana <ti...@apache.org> a
> écrit :
>
> > Relocation is useless. The ASM is changed because of the bytecode
> > compatibility. We always had to upgrade plexus-java in the past;
> otherwise
> > the users reported a bug directly or in the Stackoverflow.
> >
> > On Sat, Oct 12, 2019 at 1:45 PM Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > wrote:
> >
> > > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
> > > écrit :
> > >
> > > > As far as I know, surefire won't touch the Plexus Java code that
> > requires
> > > > ASM.
> > > > It is ONLY required when the runtime is Java 8 or lower AND you need
> to
> > > > read the module descriptors.
> > > >
> > > > Maven Shade is a different case: it must parse the Java bytecode (and
> > > > only
> > > > when using minifyJar), hence it needs the latest ASM.
> > > >
> > >
> > > + Relocation ;)
> > >
> > >
> > > > Robert
> > > >
> > > > On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana <
> > tibordigana@apache.org
> > > >
> > > >
> > > > wrote:
> > > >
> > > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > > > The support for JDk 13 and 14 is in the version 7.2.
> > > > > We have similar upgrade in
> > > > > https://github.com/apache/maven-shade-plugin/pull/29
> > > > >
> > > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> > wrote:
> > > > >
> > > > >> Hi,
> > > > >> It's now almost 10 months since last and around 30 issues fixed.
> > > > >> Maybe time for a new release?
> > > > >> Moving issues still open to 3.0.0-M5?
> > > > >>
> > > > >> cheers
> > > > >> --
> > > > >> Olivier Lamy
> > > > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Not sure what you meant Tibor, just completed that relocation can need asm
upgrade in shade plugin - if we dont want users to do it in the pom which
is ok/needed if they use new java versions.
Le sam. 12 oct. 2019 à 20:24, Tibor Digana <ti...@apache.org> a
écrit :
> Relocation is useless. The ASM is changed because of the bytecode
> compatibility. We always had to upgrade plexus-java in the past; otherwise
> the users reported a bug directly or in the Stackoverflow.
>
> On Sat, Oct 12, 2019 at 1:45 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
> > écrit :
> >
> > > As far as I know, surefire won't touch the Plexus Java code that
> requires
> > > ASM.
> > > It is ONLY required when the runtime is Java 8 or lower AND you need to
> > > read the module descriptors.
> > >
> > > Maven Shade is a different case: it must parse the Java bytecode (and
> > > only
> > > when using minifyJar), hence it needs the latest ASM.
> > >
> >
> > + Relocation ;)
> >
> >
> > > Robert
> > >
> > > On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana <
> tibordigana@apache.org
> > >
> > >
> > > wrote:
> > >
> > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > > The support for JDk 13 and 14 is in the version 7.2.
> > > > We have similar upgrade in
> > > > https://github.com/apache/maven-shade-plugin/pull/29
> > > >
> > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org>
> wrote:
> > > >
> > > >> Hi,
> > > >> It's now almost 10 months since last and around 30 issues fixed.
> > > >> Maybe time for a new release?
> > > >> Moving issues still open to 3.0.0-M5?
> > > >>
> > > >> cheers
> > > >> --
> > > >> Olivier Lamy
> > > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
Relocation is useless. The ASM is changed because of the bytecode
compatibility. We always had to upgrade plexus-java in the past; otherwise
the users reported a bug directly or in the Stackoverflow.
On Sat, Oct 12, 2019 at 1:45 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
> écrit :
>
> > As far as I know, surefire won't touch the Plexus Java code that requires
> > ASM.
> > It is ONLY required when the runtime is Java 8 or lower AND you need to
> > read the module descriptors.
> >
> > Maven Shade is a different case: it must parse the Java bytecode (and
> > only
> > when using minifyJar), hence it needs the latest ASM.
> >
>
> + Relocation ;)
>
>
> > Robert
> >
> > On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana <tibordigana@apache.org
> >
> >
> > wrote:
> >
> > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > The support for JDk 13 and 14 is in the version 7.2.
> > > We have similar upgrade in
> > > https://github.com/apache/maven-shade-plugin/pull/29
> > >
> > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> wrote:
> > >
> > >> Hi,
> > >> It's now almost 10 months since last and around 30 issues fixed.
> > >> Maybe time for a new release?
> > >> Moving issues still open to 3.0.0-M5?
> > >>
> > >> cheers
> > >> --
> > >> Olivier Lamy
> > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
Re: Surefire 3.0.0-M4 release?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rf...@apache.org> a
écrit :
> As far as I know, surefire won't touch the Plexus Java code that requires
> ASM.
> It is ONLY required when the runtime is Java 8 or lower AND you need to
> read the module descriptors.
>
> Maven Shade is a different case: it must parse the Java bytecode (and
> only
> when using minifyJar), hence it needs the latest ASM.
>
+ Relocation ;)
> Robert
>
> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana <ti...@apache.org>
>
> wrote:
>
> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > The support for JDk 13 and 14 is in the version 7.2.
> > We have similar upgrade in
> > https://github.com/apache/maven-shade-plugin/pull/29
> >
> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> wrote:
> >
> >> Hi,
> >> It's now almost 10 months since last and around 30 issues fixed.
> >> Maybe time for a new release?
> >> Moving issues still open to 3.0.0-M5?
> >>
> >> cheers
> >> --
> >> Olivier Lamy
> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Surefire 3.0.0-M4 release?
Posted by Robert Scholte <rf...@apache.org>.
As far as I know, surefire won't touch the Plexus Java code that requires
ASM.
It is ONLY required when the runtime is Java 8 or lower AND you need to
read the module descriptors.
Maven Shade is a different case: it must parse the Java bytecode (and only
when using minifyJar), hence it needs the latest ASM.
Robert
On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana <ti...@apache.org>
wrote:
> We still use plexus-java:1.0.3 which depends on ASM 7.0.
> The support for JDk 13 and 14 is in the version 7.2.
> We have similar upgrade in
> https://github.com/apache/maven-shade-plugin/pull/29
>
> On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> wrote:
>
>> Hi,
>> It's now almost 10 months since last and around 30 issues fixed.
>> Maybe time for a new release?
>> Moving issues still open to 3.0.0-M5?
>>
>> cheers
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Surefire 3.0.0-M4 release?
Posted by Tibor Digana <ti...@apache.org>.
We still use plexus-java:1.0.3 which depends on ASM 7.0.
The support for JDk 13 and 14 is in the version 7.2.
We have similar upgrade in
https://github.com/apache/maven-shade-plugin/pull/29
On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> wrote:
> Hi,
> It's now almost 10 months since last and around 30 issues fixed.
> Maybe time for a new release?
> Moving issues still open to 3.0.0-M5?
>
> cheers
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>