[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429806#comment-16429806 ] 

ASF GitHub Bot commented on CB-13892:
-------------------------------------

jcesarmobile opened a new pull request #67: CB-13892:(all) Remove navigator.notification
URL: https://github.com/apache/cordova-plugin-vibration/pull/67
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   All
   
   ### What does this PR do?
   Removes the old navigator.notification API as it has been deprecated for a long time (not even documented)
   Also removed the tests that used it
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove navigator.notification from vibration plugin
> ---------------------------------------------------
>
>                 Key: CB-13892
>                 URL: https://issues.apache.org/jira/browse/CB-13892
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-vibration
>            Reporter: jcesarmobile
>            Priority: Major
>
> The navigator.notification was deprecated long time ago and also deleted from the docs, but the plugin still have it as merges in the plugin.xml
> We should remove it from plugin.xml and from the manual tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org