You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/10/08 12:19:48 UTC
Review Request 39121: AMBARI-13346 : More relevant error messages
should be provided for Ranger password issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39121/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Bugs: AMBARI-13346
https://issues.apache.org/jira/browse/AMBARI-13346
Repository: ambari
Description
-------
Patch contains corrections in error messages given based on different error responses from Ranger REST calls.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py e4b1744
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 253ee03
Diff: https://reviews.apache.org/r/39121/diff/
Testing
-------
Tested on a cluster having Ranger and HDFS for Error responses of cases like:
1) Ranger Host not reachable
2) Invalid Password
3) Service create failed
----------------------------------------------------------------------
Ran 264 tests in 6.590s
OK
----------------------------------------------------------------------
Total run:838
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 39121: AMBARI-13346 : More relevant error messages
should be provided for Ranger password issues
Posted by Gautam Borad <gb...@gmail.com>.
> On Oct. 9, 2015, 6:53 p.m., Andrew Onischuk wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py, line 185
> > <https://reviews.apache.org/r/39121/diff/1/?file=1092862#file1092862line185>
> >
> > Just currious what symbols are you trying to avoid. This seems to match most of symbols possible
The intention is to avoid all white space characters.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39121/#review102095
-----------------------------------------------------------
On Oct. 8, 2015, 10:19 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39121/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 10:19 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13346
> https://issues.apache.org/jira/browse/AMBARI-13346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains corrections in error messages given based on different error responses from Ranger REST calls.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py e4b1744
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 253ee03
>
> Diff: https://reviews.apache.org/r/39121/diff/
>
>
> Testing
> -------
>
> Tested on a cluster having Ranger and HDFS for Error responses of cases like:
>
> 1) Ranger Host not reachable
> 2) Invalid Password
> 3) Service create failed
>
> ----------------------------------------------------------------------
> Ran 264 tests in 6.590s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 39121: AMBARI-13346 : More relevant error messages
should be provided for Ranger password issues
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39121/#review102095
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py (line 81)
<https://reviews.apache.org/r/39121/#comment159607>
I wonder also if you have tested Ranger install with unicode passwords?
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py (line 169)
<https://reviews.apache.org/r/39121/#comment159606>
Just currious what symbols are you trying to avoid. This seems to match most of symbols possible
- Andrew Onischuk
On Oct. 8, 2015, 10:19 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39121/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 10:19 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13346
> https://issues.apache.org/jira/browse/AMBARI-13346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains corrections in error messages given based on different error responses from Ranger REST calls.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py e4b1744
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 253ee03
>
> Diff: https://reviews.apache.org/r/39121/diff/
>
>
> Testing
> -------
>
> Tested on a cluster having Ranger and HDFS for Error responses of cases like:
>
> 1) Ranger Host not reachable
> 2) Invalid Password
> 3) Service create failed
>
> ----------------------------------------------------------------------
> Ran 264 tests in 6.590s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 39121: AMBARI-13346 : More relevant error messages
should be provided for Ranger password issues
Posted by Gautam Borad <gb...@gmail.com>.
> On Oct. 9, 2015, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py, line 81
> > <https://reviews.apache.org/r/39121/diff/1/?file=1092861#file1092861line81>
> >
> > Please add some pydoc to all of these functions.
Added in the new patch
> On Oct. 9, 2015, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py, line 97
> > <https://reviews.apache.org/r/39121/diff/1/?file=1092861#file1092861line97>
> >
> > Does this need to check that "name" is in repo?
No, not required here since it is handled in the get_repository_by_name_urllib2()
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39121/#review102089
-----------------------------------------------------------
On Oct. 8, 2015, 10:19 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39121/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 10:19 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13346
> https://issues.apache.org/jira/browse/AMBARI-13346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains corrections in error messages given based on different error responses from Ranger REST calls.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py e4b1744
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 253ee03
>
> Diff: https://reviews.apache.org/r/39121/diff/
>
>
> Testing
> -------
>
> Tested on a cluster having Ranger and HDFS for Error responses of cases like:
>
> 1) Ranger Host not reachable
> 2) Invalid Password
> 3) Service create failed
>
> ----------------------------------------------------------------------
> Ran 264 tests in 6.590s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 39121: AMBARI-13346 : More relevant error messages
should be provided for Ranger password issues
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39121/#review102089
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py (line 76)
<https://reviews.apache.org/r/39121/#comment159603>
Please add some pydoc to all of these functions.
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py (line 91)
<https://reviews.apache.org/r/39121/#comment159602>
Does this need to check that "name" is in repo?
- Alejandro Fernandez
On Oct. 8, 2015, 10:19 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39121/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 10:19 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13346
> https://issues.apache.org/jira/browse/AMBARI-13346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains corrections in error messages given based on different error responses from Ranger REST calls.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py e4b1744
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 253ee03
>
> Diff: https://reviews.apache.org/r/39121/diff/
>
>
> Testing
> -------
>
> Tested on a cluster having Ranger and HDFS for Error responses of cases like:
>
> 1) Ranger Host not reachable
> 2) Invalid Password
> 3) Service create failed
>
> ----------------------------------------------------------------------
> Ran 264 tests in 6.590s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 39121: AMBARI-13346 : More relevant error messages
should be provided for Ranger password issues
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39121/#review102272
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 12, 2015, 7:10 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39121/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 7:10 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13346
> https://issues.apache.org/jira/browse/AMBARI-13346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains corrections in error messages given based on different error responses from Ranger REST calls.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py e4b1744
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 253ee03
>
> Diff: https://reviews.apache.org/r/39121/diff/
>
>
> Testing
> -------
>
> Tested on a cluster having Ranger and HDFS for Error responses of cases like:
>
> 1) Ranger Host not reachable
> 2) Invalid Password
> 3) Service create failed
>
> ----------------------------------------------------------------------
> Ran 264 tests in 6.590s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 39121: AMBARI-13346 : More relevant error messages
should be provided for Ranger password issues
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39121/
-----------------------------------------------------------
(Updated Oct. 12, 2015, 7:10 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Bugs: AMBARI-13346
https://issues.apache.org/jira/browse/AMBARI-13346
Repository: ambari
Description
-------
Patch contains corrections in error messages given based on different error responses from Ranger REST calls.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py e4b1744
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 253ee03
Diff: https://reviews.apache.org/r/39121/diff/
Testing
-------
Tested on a cluster having Ranger and HDFS for Error responses of cases like:
1) Ranger Host not reachable
2) Invalid Password
3) Service create failed
----------------------------------------------------------------------
Ran 264 tests in 6.590s
OK
----------------------------------------------------------------------
Total run:838
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad