You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2015/02/13 00:55:59 UTC
Review Request 30956: Reduce ambiguity in grammar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30956/
-----------------------------------------------------------
Review request for hive and John Pullokkaran.
Repository: hive-git
Description
-------
As of today, antlr reports 310 warnings. Need to bring down this number, ideally to 0.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 062e520
contrib/src/test/queries/clientnegative/serde_regex.q 7ad3142
contrib/src/test/queries/clientpositive/serde_regex.q 5c2d2ca
contrib/src/test/results/clientnegative/serde_regex.q.out 988bf10
contrib/src/test/results/clientpositive/serde_regex.q.out dc97cb3
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationReads.java 6f45a59
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java 79cf58b
ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g b72ee5d
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 20c73cd
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 149b788
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g d37f49f
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java a24cad9
ql/src/java/org/apache/hadoop/hive/ql/parse/SelectClauseParser.g eba3689
ql/src/test/org/apache/hadoop/hive/ql/parse/TestIUD.java a8d03a9
ql/src/test/queries/clientnegative/serde_regex.q 13b3f16
ql/src/test/queries/clientnegative/serde_regex2.q d523d03
ql/src/test/queries/clientnegative/serde_regex3.q 5a0295c
ql/src/test/queries/clientpositive/ambiguitycheck.q PRE-CREATION
ql/src/test/queries/clientpositive/array_map_access_nonconstant.q 49c1f54
ql/src/test/queries/clientpositive/decimal_10_0.q 02b547c
ql/src/test/queries/clientpositive/dynamic_partition_pruning.q f12b2c5
ql/src/test/queries/clientpositive/keyword_1.q 2e996af
ql/src/test/queries/clientpositive/nonreserved_keywords_input37.q e33b4bf
ql/src/test/queries/clientpositive/nonreserved_keywords_insert_into1.q 144cfee
ql/src/test/queries/clientpositive/partition_wise_fileformat17.q 3cf488f
ql/src/test/queries/clientpositive/partition_wise_fileformat18.q 40ed258
ql/src/test/queries/clientpositive/ppd_field_garbage.q 23e0778
ql/src/test/queries/clientpositive/serde_regex.q accdb54
ql/src/test/queries/clientpositive/tez_union_group_by.q 56e8583
ql/src/test/queries/clientpositive/union_remove_1.q 0db1743
ql/src/test/queries/clientpositive/union_remove_10.q 1e9c201
ql/src/test/queries/clientpositive/union_remove_11.q 7052c69
ql/src/test/queries/clientpositive/union_remove_12.q 67a1829
ql/src/test/queries/clientpositive/union_remove_13.q 29c164a
ql/src/test/queries/clientpositive/union_remove_14.q ca2f5e5
ql/src/test/queries/clientpositive/union_remove_15.q 72ced75
ql/src/test/queries/clientpositive/union_remove_16.q 72e6cb1
ql/src/test/queries/clientpositive/union_remove_17.q fa68755
ql/src/test/queries/clientpositive/union_remove_18.q 6d2d331
ql/src/test/queries/clientpositive/union_remove_19.q 17b8a0f
ql/src/test/queries/clientpositive/union_remove_2.q 0142325
ql/src/test/queries/clientpositive/union_remove_20.q 1c59ef2
ql/src/test/queries/clientpositive/union_remove_21.q cbaa08b
ql/src/test/queries/clientpositive/union_remove_22.q 982912b
ql/src/test/queries/clientpositive/union_remove_23.q 63e4418
ql/src/test/queries/clientpositive/union_remove_24.q 88c378d
ql/src/test/queries/clientpositive/union_remove_25.q 27d9ebe
ql/src/test/queries/clientpositive/union_remove_3.q 7e1b113
ql/src/test/queries/clientpositive/union_remove_4.q 44b31d6
ql/src/test/queries/clientpositive/union_remove_5.q c5c0b7f
ql/src/test/queries/clientpositive/union_remove_6.q 6990ed2
ql/src/test/queries/clientpositive/union_remove_6_subq.q 8bcac6f
ql/src/test/queries/clientpositive/union_remove_7.q c254aba
ql/src/test/queries/clientpositive/union_remove_8.q 8dfb8e8
ql/src/test/queries/clientpositive/union_remove_9.q c9a4dc3
ql/src/test/queries/clientpositive/vector_decimal_10_0.q ae93058
ql/src/test/queries/clientpositive/vectorized_date_funcs.q 1fb0dac
ql/src/test/queries/clientpositive/vectorized_dynamic_partition_pruning.q 1197f7d
ql/src/test/results/clientnegative/authorization_cannot_create_all_role.q.out 99f20bd
ql/src/test/results/clientnegative/authorization_cannot_create_none_role.q.out 4808433
ql/src/test/results/clientnegative/lateral_view_join.q.out 8ad1386
ql/src/test/results/clientnegative/serde_regex.q.out fc29724
ql/src/test/results/clientnegative/serde_regex2.q.out 198f79b
ql/src/test/results/clientnegative/serde_regex3.q.out 1df4cd6
ql/src/test/results/clientpositive/ambiguitycheck.q.out PRE-CREATION
ql/src/test/results/clientpositive/array_map_access_nonconstant.q.out d8b88c6
ql/src/test/results/clientpositive/decimal_10_0.q.out ae3426c
ql/src/test/results/clientpositive/keyword_1.q.out 135d8e5
ql/src/test/results/clientpositive/nonreserved_keywords_input37.q.out 819da22
ql/src/test/results/clientpositive/nonreserved_keywords_insert_into1.q.out 9f075f1
ql/src/test/results/clientpositive/partition_wise_fileformat17.q.out e9502e0
ql/src/test/results/clientpositive/partition_wise_fileformat18.q.out 5d75ff8
ql/src/test/results/clientpositive/ppd_field_garbage.q.out 86eca5b
ql/src/test/results/clientpositive/serde_regex.q.out 19187ba
ql/src/test/results/clientpositive/spark/union_remove_1.q.out 581d305
ql/src/test/results/clientpositive/spark/union_remove_10.q.out 629f7ba
ql/src/test/results/clientpositive/spark/union_remove_11.q.out 257d2ff
ql/src/test/results/clientpositive/spark/union_remove_12.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_13.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_14.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_15.q.out 09cd5d3
ql/src/test/results/clientpositive/spark/union_remove_16.q.out 0db279f
ql/src/test/results/clientpositive/spark/union_remove_17.q.out 8f317de
ql/src/test/results/clientpositive/spark/union_remove_18.q.out 96c8c25
ql/src/test/results/clientpositive/spark/union_remove_19.q.out 7049a91
ql/src/test/results/clientpositive/spark/union_remove_2.q.out 298929d
ql/src/test/results/clientpositive/spark/union_remove_20.q.out 328b1ac
ql/src/test/results/clientpositive/spark/union_remove_21.q.out b160397
ql/src/test/results/clientpositive/spark/union_remove_22.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_23.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_24.q.out 8bc748d
ql/src/test/results/clientpositive/spark/union_remove_25.q.out 396a43d
ql/src/test/results/clientpositive/spark/union_remove_3.q.out bac5441
ql/src/test/results/clientpositive/spark/union_remove_4.q.out e83788a
ql/src/test/results/clientpositive/spark/union_remove_5.q.out 0deb03d
ql/src/test/results/clientpositive/spark/union_remove_6.q.out 64c252d
ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_7.q.out 2d350a3
ql/src/test/results/clientpositive/spark/union_remove_8.q.out e6ab825
ql/src/test/results/clientpositive/spark/union_remove_9.q.out 1eef57a
ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 21e0876
ql/src/test/results/clientpositive/tez/orc_vectorization_ppd.q.out 738abc4
ql/src/test/results/clientpositive/tez/tez_union_group_by.q.out 32c961d
ql/src/test/results/clientpositive/tez/vector_decimal_10_0.q.out 6f2b221
ql/src/test/results/clientpositive/tez/vectorized_date_funcs.q.out be782e4
ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 6fde788
ql/src/test/results/clientpositive/union_remove_1.q.out 411f63e
ql/src/test/results/clientpositive/union_remove_10.q.out d80bf32
ql/src/test/results/clientpositive/union_remove_11.q.out 23ab7c6
ql/src/test/results/clientpositive/union_remove_12.q.out f9fd323
ql/src/test/results/clientpositive/union_remove_13.q.out b8913e2
ql/src/test/results/clientpositive/union_remove_14.q.out 28e4bb6
ql/src/test/results/clientpositive/union_remove_15.q.out faf3e58
ql/src/test/results/clientpositive/union_remove_16.q.out 8656c11
ql/src/test/results/clientpositive/union_remove_17.q.out 386b023
ql/src/test/results/clientpositive/union_remove_18.q.out 0ce6e81
ql/src/test/results/clientpositive/union_remove_19.q.out b6d557b
ql/src/test/results/clientpositive/union_remove_2.q.out b9e575b
ql/src/test/results/clientpositive/union_remove_20.q.out b2819ce
ql/src/test/results/clientpositive/union_remove_21.q.out ac20851
ql/src/test/results/clientpositive/union_remove_22.q.out a8257d0
ql/src/test/results/clientpositive/union_remove_23.q.out a2ed7f3
ql/src/test/results/clientpositive/union_remove_24.q.out d0ac662
ql/src/test/results/clientpositive/union_remove_25.q.out 8c93ead
ql/src/test/results/clientpositive/union_remove_3.q.out e210461
ql/src/test/results/clientpositive/union_remove_4.q.out 2291a43
ql/src/test/results/clientpositive/union_remove_5.q.out 26179f5
ql/src/test/results/clientpositive/union_remove_6.q.out ff23e2d
ql/src/test/results/clientpositive/union_remove_6_subq.q.out be15c1f
ql/src/test/results/clientpositive/union_remove_7.q.out f0e59cb
ql/src/test/results/clientpositive/union_remove_8.q.out 2cba717
ql/src/test/results/clientpositive/union_remove_9.q.out 75925ac
ql/src/test/results/clientpositive/vector_decimal_10_0.q.out 1fb0e30
ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 8cde444
Diff: https://reviews.apache.org/r/30956/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 30956: Reduce ambiguity in grammar
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30956/
-----------------------------------------------------------
(Updated March 4, 2015, 10:18 p.m.)
Review request for hive and John Pullokkaran.
Repository: hive-git
Description
-------
As of today, antlr reports 310 warnings. Need to bring down this number, ideally to 0.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a809f17
contrib/src/test/queries/clientnegative/serde_regex.q 7ad3142
contrib/src/test/queries/clientpositive/serde_regex.q 5c2d2ca
contrib/src/test/results/clientnegative/serde_regex.q.out 988bf10
contrib/src/test/results/clientpositive/serde_regex.q.out dc97cb3
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationReads.java 6f45a59
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java 79cf58b
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java c4dccba
ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g b72ee5d
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 90b84ac
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 72b852e
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g cabf971
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java a24cad9
ql/src/java/org/apache/hadoop/hive/ql/parse/SelectClauseParser.g eba3689
ql/src/test/org/apache/hadoop/hive/ql/parse/TestIUD.java eed162b
ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java PRE-CREATION
ql/src/test/queries/clientnegative/serde_regex.q 13b3f16
ql/src/test/queries/clientnegative/serde_regex2.q d523d03
ql/src/test/queries/clientnegative/serde_regex3.q 5a0295c
ql/src/test/queries/clientpositive/ambiguitycheck.q PRE-CREATION
ql/src/test/queries/clientpositive/array_map_access_nonconstant.q 49c1f54
ql/src/test/queries/clientpositive/decimal_10_0.q 02b547c
ql/src/test/queries/clientpositive/dynamic_partition_pruning.q f12b2c5
ql/src/test/queries/clientpositive/keyword_1.q 2e996af
ql/src/test/queries/clientpositive/nonreserved_keywords_input37.q e33b4bf
ql/src/test/queries/clientpositive/nonreserved_keywords_insert_into1.q 144cfee
ql/src/test/queries/clientpositive/partition_wise_fileformat17.q 3cf488f
ql/src/test/queries/clientpositive/partition_wise_fileformat18.q 40ed258
ql/src/test/queries/clientpositive/ppd_field_garbage.q 23e0778
ql/src/test/queries/clientpositive/serde_regex.q accdb54
ql/src/test/queries/clientpositive/tez_union_group_by.q 56e8583
ql/src/test/queries/clientpositive/union_remove_1.q 0db1743
ql/src/test/queries/clientpositive/union_remove_10.q 1e9c201
ql/src/test/queries/clientpositive/union_remove_11.q 7052c69
ql/src/test/queries/clientpositive/union_remove_12.q 67a1829
ql/src/test/queries/clientpositive/union_remove_13.q 29c164a
ql/src/test/queries/clientpositive/union_remove_14.q ca2f5e5
ql/src/test/queries/clientpositive/union_remove_15.q 72ced75
ql/src/test/queries/clientpositive/union_remove_16.q 72e6cb1
ql/src/test/queries/clientpositive/union_remove_17.q fa68755
ql/src/test/queries/clientpositive/union_remove_18.q 6d2d331
ql/src/test/queries/clientpositive/union_remove_19.q 17b8a0f
ql/src/test/queries/clientpositive/union_remove_2.q 0142325
ql/src/test/queries/clientpositive/union_remove_20.q 1c59ef2
ql/src/test/queries/clientpositive/union_remove_21.q cbaa08b
ql/src/test/queries/clientpositive/union_remove_22.q 982912b
ql/src/test/queries/clientpositive/union_remove_23.q 63e4418
ql/src/test/queries/clientpositive/union_remove_24.q 88c378d
ql/src/test/queries/clientpositive/union_remove_25.q 27d9ebe
ql/src/test/queries/clientpositive/union_remove_3.q 7e1b113
ql/src/test/queries/clientpositive/union_remove_4.q 44b31d6
ql/src/test/queries/clientpositive/union_remove_5.q c5c0b7f
ql/src/test/queries/clientpositive/union_remove_6.q 6990ed2
ql/src/test/queries/clientpositive/union_remove_6_subq.q 8bcac6f
ql/src/test/queries/clientpositive/union_remove_7.q c254aba
ql/src/test/queries/clientpositive/union_remove_8.q 8dfb8e8
ql/src/test/queries/clientpositive/union_remove_9.q c9a4dc3
ql/src/test/queries/clientpositive/vector_decimal_10_0.q ae93058
ql/src/test/queries/clientpositive/vectorized_dynamic_partition_pruning.q 1197f7d
ql/src/test/results/clientnegative/authorization_cannot_create_all_role.q.out 99f20bd
ql/src/test/results/clientnegative/authorization_cannot_create_none_role.q.out 4808433
ql/src/test/results/clientnegative/lateral_view_join.q.out 8ad1386
ql/src/test/results/clientnegative/select_charliteral.q.out 09e409b
ql/src/test/results/clientnegative/serde_regex.q.out fc29724
ql/src/test/results/clientnegative/serde_regex2.q.out 198f79b
ql/src/test/results/clientnegative/serde_regex3.q.out 1df4cd6
ql/src/test/results/clientpositive/ambiguitycheck.q.out PRE-CREATION
ql/src/test/results/clientpositive/array_map_access_nonconstant.q.out d8b88c6
ql/src/test/results/clientpositive/decimal_10_0.q.out ae3426c
ql/src/test/results/clientpositive/keyword_1.q.out 135d8e5
ql/src/test/results/clientpositive/nonreserved_keywords_input37.q.out 819da22
ql/src/test/results/clientpositive/nonreserved_keywords_insert_into1.q.out 9f075f1
ql/src/test/results/clientpositive/partition_wise_fileformat17.q.out e9502e0
ql/src/test/results/clientpositive/partition_wise_fileformat18.q.out 5d75ff8
ql/src/test/results/clientpositive/ppd_field_garbage.q.out 86eca5b
ql/src/test/results/clientpositive/serde_regex.q.out 19187ba
ql/src/test/results/clientpositive/spark/union_remove_1.q.out 581d305
ql/src/test/results/clientpositive/spark/union_remove_10.q.out 629f7ba
ql/src/test/results/clientpositive/spark/union_remove_11.q.out 257d2ff
ql/src/test/results/clientpositive/spark/union_remove_12.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_13.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_14.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_15.q.out 09cd5d3
ql/src/test/results/clientpositive/spark/union_remove_16.q.out 0db279f
ql/src/test/results/clientpositive/spark/union_remove_17.q.out 8f317de
ql/src/test/results/clientpositive/spark/union_remove_18.q.out 96c8c25
ql/src/test/results/clientpositive/spark/union_remove_19.q.out 7049a91
ql/src/test/results/clientpositive/spark/union_remove_2.q.out 298929d
ql/src/test/results/clientpositive/spark/union_remove_20.q.out 328b1ac
ql/src/test/results/clientpositive/spark/union_remove_21.q.out b160397
ql/src/test/results/clientpositive/spark/union_remove_22.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_23.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_24.q.out 8bc748d
ql/src/test/results/clientpositive/spark/union_remove_25.q.out 396a43d
ql/src/test/results/clientpositive/spark/union_remove_3.q.out bac5441
ql/src/test/results/clientpositive/spark/union_remove_4.q.out e83788a
ql/src/test/results/clientpositive/spark/union_remove_5.q.out 0deb03d
ql/src/test/results/clientpositive/spark/union_remove_6.q.out 64c252d
ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_7.q.out 2d350a3
ql/src/test/results/clientpositive/spark/union_remove_8.q.out e6ab825
ql/src/test/results/clientpositive/spark/union_remove_9.q.out 1eef57a
ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 21e0876
ql/src/test/results/clientpositive/tez/tez_union_group_by.q.out 32c961d
ql/src/test/results/clientpositive/tez/vector_decimal_10_0.q.out 6f2b221
ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 6fde788
ql/src/test/results/clientpositive/union_remove_1.q.out 411f63e
ql/src/test/results/clientpositive/union_remove_10.q.out d80bf32
ql/src/test/results/clientpositive/union_remove_11.q.out 23ab7c6
ql/src/test/results/clientpositive/union_remove_12.q.out f9fd323
ql/src/test/results/clientpositive/union_remove_13.q.out b8913e2
ql/src/test/results/clientpositive/union_remove_14.q.out 28e4bb6
ql/src/test/results/clientpositive/union_remove_15.q.out faf3e58
ql/src/test/results/clientpositive/union_remove_16.q.out 8656c11
ql/src/test/results/clientpositive/union_remove_17.q.out 386b023
ql/src/test/results/clientpositive/union_remove_18.q.out 0ce6e81
ql/src/test/results/clientpositive/union_remove_19.q.out b6d557b
ql/src/test/results/clientpositive/union_remove_2.q.out b9e575b
ql/src/test/results/clientpositive/union_remove_20.q.out b2819ce
ql/src/test/results/clientpositive/union_remove_21.q.out ac20851
ql/src/test/results/clientpositive/union_remove_22.q.out a8257d0
ql/src/test/results/clientpositive/union_remove_23.q.out a2ed7f3
ql/src/test/results/clientpositive/union_remove_24.q.out d0ac662
ql/src/test/results/clientpositive/union_remove_25.q.out 8c93ead
ql/src/test/results/clientpositive/union_remove_3.q.out e210461
ql/src/test/results/clientpositive/union_remove_4.q.out 2291a43
ql/src/test/results/clientpositive/union_remove_5.q.out 26179f5
ql/src/test/results/clientpositive/union_remove_6.q.out ff23e2d
ql/src/test/results/clientpositive/union_remove_6_subq.q.out 98c0df1
ql/src/test/results/clientpositive/union_remove_7.q.out f0e59cb
ql/src/test/results/clientpositive/union_remove_8.q.out 2cba717
ql/src/test/results/clientpositive/union_remove_9.q.out 75925ac
ql/src/test/results/clientpositive/vector_decimal_10_0.q.out 1fb0e30
Diff: https://reviews.apache.org/r/30956/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 30956: Reduce ambiguity in grammar
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30956/
-----------------------------------------------------------
(Updated Feb. 20, 2015, 6:21 p.m.)
Review request for hive and John Pullokkaran.
Repository: hive-git
Description
-------
As of today, antlr reports 310 warnings. Need to bring down this number, ideally to 0.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e64e8fc
contrib/src/test/queries/clientnegative/serde_regex.q 7ad3142
contrib/src/test/queries/clientpositive/serde_regex.q 5c2d2ca
contrib/src/test/results/clientnegative/serde_regex.q.out 988bf10
contrib/src/test/results/clientpositive/serde_regex.q.out dc97cb3
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationReads.java 6f45a59
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java 79cf58b
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java c4dccba
ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g b72ee5d
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 90b84ac
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 72b852e
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g cabf971
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java a24cad9
ql/src/java/org/apache/hadoop/hive/ql/parse/SelectClauseParser.g eba3689
ql/src/test/org/apache/hadoop/hive/ql/parse/TestIUD.java eed162b
ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11KeyWordsNegative.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11KeyWordsPositive.java PRE-CREATION
ql/src/test/queries/clientnegative/serde_regex.q 13b3f16
ql/src/test/queries/clientnegative/serde_regex2.q d523d03
ql/src/test/queries/clientnegative/serde_regex3.q 5a0295c
ql/src/test/queries/clientpositive/ambiguitycheck.q PRE-CREATION
ql/src/test/queries/clientpositive/array_map_access_nonconstant.q 49c1f54
ql/src/test/queries/clientpositive/decimal_10_0.q 02b547c
ql/src/test/queries/clientpositive/dynamic_partition_pruning.q f12b2c5
ql/src/test/queries/clientpositive/keyword_1.q 2e996af
ql/src/test/queries/clientpositive/nonreserved_keywords_input37.q e33b4bf
ql/src/test/queries/clientpositive/nonreserved_keywords_insert_into1.q 144cfee
ql/src/test/queries/clientpositive/partition_wise_fileformat17.q 3cf488f
ql/src/test/queries/clientpositive/partition_wise_fileformat18.q 40ed258
ql/src/test/queries/clientpositive/ppd_field_garbage.q 23e0778
ql/src/test/queries/clientpositive/serde_regex.q accdb54
ql/src/test/queries/clientpositive/tez_union_group_by.q 56e8583
ql/src/test/queries/clientpositive/union_remove_1.q 0db1743
ql/src/test/queries/clientpositive/union_remove_10.q 1e9c201
ql/src/test/queries/clientpositive/union_remove_11.q 7052c69
ql/src/test/queries/clientpositive/union_remove_12.q 67a1829
ql/src/test/queries/clientpositive/union_remove_13.q 29c164a
ql/src/test/queries/clientpositive/union_remove_14.q ca2f5e5
ql/src/test/queries/clientpositive/union_remove_15.q 72ced75
ql/src/test/queries/clientpositive/union_remove_16.q 72e6cb1
ql/src/test/queries/clientpositive/union_remove_17.q fa68755
ql/src/test/queries/clientpositive/union_remove_18.q 6d2d331
ql/src/test/queries/clientpositive/union_remove_19.q 17b8a0f
ql/src/test/queries/clientpositive/union_remove_2.q 0142325
ql/src/test/queries/clientpositive/union_remove_20.q 1c59ef2
ql/src/test/queries/clientpositive/union_remove_21.q cbaa08b
ql/src/test/queries/clientpositive/union_remove_22.q 982912b
ql/src/test/queries/clientpositive/union_remove_23.q 63e4418
ql/src/test/queries/clientpositive/union_remove_24.q 88c378d
ql/src/test/queries/clientpositive/union_remove_25.q 27d9ebe
ql/src/test/queries/clientpositive/union_remove_3.q 7e1b113
ql/src/test/queries/clientpositive/union_remove_4.q 44b31d6
ql/src/test/queries/clientpositive/union_remove_5.q c5c0b7f
ql/src/test/queries/clientpositive/union_remove_6.q 6990ed2
ql/src/test/queries/clientpositive/union_remove_6_subq.q 8bcac6f
ql/src/test/queries/clientpositive/union_remove_7.q c254aba
ql/src/test/queries/clientpositive/union_remove_8.q 8dfb8e8
ql/src/test/queries/clientpositive/union_remove_9.q c9a4dc3
ql/src/test/queries/clientpositive/vector_decimal_10_0.q ae93058
ql/src/test/queries/clientpositive/vectorized_dynamic_partition_pruning.q 1197f7d
ql/src/test/results/clientnegative/select_charliteral.q.out 09e409b
ql/src/test/results/clientnegative/serde_regex.q.out fc29724
ql/src/test/results/clientnegative/serde_regex2.q.out 198f79b
ql/src/test/results/clientnegative/serde_regex3.q.out 1df4cd6
ql/src/test/results/clientpositive/ambiguitycheck.q.out PRE-CREATION
ql/src/test/results/clientpositive/array_map_access_nonconstant.q.out d8b88c6
ql/src/test/results/clientpositive/decimal_10_0.q.out ae3426c
ql/src/test/results/clientpositive/keyword_1.q.out 135d8e5
ql/src/test/results/clientpositive/nonreserved_keywords_input37.q.out 819da22
ql/src/test/results/clientpositive/nonreserved_keywords_insert_into1.q.out 9f075f1
ql/src/test/results/clientpositive/partition_wise_fileformat17.q.out e9502e0
ql/src/test/results/clientpositive/partition_wise_fileformat18.q.out 5d75ff8
ql/src/test/results/clientpositive/ppd_field_garbage.q.out 86eca5b
ql/src/test/results/clientpositive/serde_regex.q.out 19187ba
ql/src/test/results/clientpositive/spark/union_remove_1.q.out 581d305
ql/src/test/results/clientpositive/spark/union_remove_10.q.out 629f7ba
ql/src/test/results/clientpositive/spark/union_remove_11.q.out 257d2ff
ql/src/test/results/clientpositive/spark/union_remove_12.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_13.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_14.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_15.q.out 09cd5d3
ql/src/test/results/clientpositive/spark/union_remove_16.q.out 0db279f
ql/src/test/results/clientpositive/spark/union_remove_17.q.out 8f317de
ql/src/test/results/clientpositive/spark/union_remove_18.q.out 96c8c25
ql/src/test/results/clientpositive/spark/union_remove_19.q.out 7049a91
ql/src/test/results/clientpositive/spark/union_remove_2.q.out 298929d
ql/src/test/results/clientpositive/spark/union_remove_20.q.out 328b1ac
ql/src/test/results/clientpositive/spark/union_remove_21.q.out b160397
ql/src/test/results/clientpositive/spark/union_remove_22.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_23.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_24.q.out 8bc748d
ql/src/test/results/clientpositive/spark/union_remove_25.q.out 396a43d
ql/src/test/results/clientpositive/spark/union_remove_3.q.out bac5441
ql/src/test/results/clientpositive/spark/union_remove_4.q.out e83788a
ql/src/test/results/clientpositive/spark/union_remove_5.q.out 0deb03d
ql/src/test/results/clientpositive/spark/union_remove_6.q.out 64c252d
ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_7.q.out 2d350a3
ql/src/test/results/clientpositive/spark/union_remove_8.q.out e6ab825
ql/src/test/results/clientpositive/spark/union_remove_9.q.out 1eef57a
ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 21e0876
ql/src/test/results/clientpositive/tez/tez_union_group_by.q.out 32c961d
ql/src/test/results/clientpositive/tez/vector_decimal_10_0.q.out 6f2b221
ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 6fde788
ql/src/test/results/clientpositive/union_remove_1.q.out 411f63e
ql/src/test/results/clientpositive/union_remove_10.q.out d80bf32
ql/src/test/results/clientpositive/union_remove_11.q.out 23ab7c6
ql/src/test/results/clientpositive/union_remove_12.q.out f9fd323
ql/src/test/results/clientpositive/union_remove_13.q.out b8913e2
ql/src/test/results/clientpositive/union_remove_14.q.out 28e4bb6
ql/src/test/results/clientpositive/union_remove_15.q.out faf3e58
ql/src/test/results/clientpositive/union_remove_16.q.out 8656c11
ql/src/test/results/clientpositive/union_remove_17.q.out 386b023
ql/src/test/results/clientpositive/union_remove_18.q.out 0ce6e81
ql/src/test/results/clientpositive/union_remove_19.q.out b6d557b
ql/src/test/results/clientpositive/union_remove_2.q.out b9e575b
ql/src/test/results/clientpositive/union_remove_20.q.out b2819ce
ql/src/test/results/clientpositive/union_remove_21.q.out ac20851
ql/src/test/results/clientpositive/union_remove_22.q.out a8257d0
ql/src/test/results/clientpositive/union_remove_23.q.out a2ed7f3
ql/src/test/results/clientpositive/union_remove_24.q.out d0ac662
ql/src/test/results/clientpositive/union_remove_25.q.out 8c93ead
ql/src/test/results/clientpositive/union_remove_3.q.out e210461
ql/src/test/results/clientpositive/union_remove_4.q.out 2291a43
ql/src/test/results/clientpositive/union_remove_5.q.out 26179f5
ql/src/test/results/clientpositive/union_remove_6.q.out ff23e2d
ql/src/test/results/clientpositive/union_remove_6_subq.q.out 98c0df1
ql/src/test/results/clientpositive/union_remove_7.q.out f0e59cb
ql/src/test/results/clientpositive/union_remove_8.q.out 2cba717
ql/src/test/results/clientpositive/union_remove_9.q.out 75925ac
ql/src/test/results/clientpositive/vector_decimal_10_0.q.out 1fb0e30
Diff: https://reviews.apache.org/r/30956/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 30956: Reduce ambiguity in grammar
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30956/
-----------------------------------------------------------
(Updated Feb. 14, 2015, 4:27 a.m.)
Review request for hive and John Pullokkaran.
Repository: hive-git
Description
-------
As of today, antlr reports 310 warnings. Need to bring down this number, ideally to 0.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 90bcc49
contrib/src/test/queries/clientnegative/serde_regex.q 7ad3142
contrib/src/test/queries/clientpositive/serde_regex.q 5c2d2ca
contrib/src/test/results/clientnegative/serde_regex.q.out 988bf10
contrib/src/test/results/clientpositive/serde_regex.q.out dc97cb3
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationReads.java 6f45a59
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java 79cf58b
ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g b72ee5d
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 90b84ac
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 3ccf893
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g cabf971
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java a24cad9
ql/src/java/org/apache/hadoop/hive/ql/parse/SelectClauseParser.g eba3689
ql/src/test/org/apache/hadoop/hive/ql/parse/TestIUD.java a8d03a9
ql/src/test/queries/clientnegative/serde_regex.q 13b3f16
ql/src/test/queries/clientnegative/serde_regex2.q d523d03
ql/src/test/queries/clientnegative/serde_regex3.q 5a0295c
ql/src/test/queries/clientpositive/ambiguitycheck.q PRE-CREATION
ql/src/test/queries/clientpositive/array_map_access_nonconstant.q 49c1f54
ql/src/test/queries/clientpositive/decimal_10_0.q 02b547c
ql/src/test/queries/clientpositive/dynamic_partition_pruning.q f12b2c5
ql/src/test/queries/clientpositive/keyword_1.q 2e996af
ql/src/test/queries/clientpositive/nonreserved_keywords_input37.q e33b4bf
ql/src/test/queries/clientpositive/nonreserved_keywords_insert_into1.q 144cfee
ql/src/test/queries/clientpositive/partition_wise_fileformat17.q 3cf488f
ql/src/test/queries/clientpositive/partition_wise_fileformat18.q 40ed258
ql/src/test/queries/clientpositive/ppd_field_garbage.q 23e0778
ql/src/test/queries/clientpositive/serde_regex.q accdb54
ql/src/test/queries/clientpositive/tez_union_group_by.q 56e8583
ql/src/test/queries/clientpositive/union_remove_1.q 0db1743
ql/src/test/queries/clientpositive/union_remove_10.q 1e9c201
ql/src/test/queries/clientpositive/union_remove_11.q 7052c69
ql/src/test/queries/clientpositive/union_remove_12.q 67a1829
ql/src/test/queries/clientpositive/union_remove_13.q 29c164a
ql/src/test/queries/clientpositive/union_remove_14.q ca2f5e5
ql/src/test/queries/clientpositive/union_remove_15.q 72ced75
ql/src/test/queries/clientpositive/union_remove_16.q 72e6cb1
ql/src/test/queries/clientpositive/union_remove_17.q fa68755
ql/src/test/queries/clientpositive/union_remove_18.q 6d2d331
ql/src/test/queries/clientpositive/union_remove_19.q 17b8a0f
ql/src/test/queries/clientpositive/union_remove_2.q 0142325
ql/src/test/queries/clientpositive/union_remove_20.q 1c59ef2
ql/src/test/queries/clientpositive/union_remove_21.q cbaa08b
ql/src/test/queries/clientpositive/union_remove_22.q 982912b
ql/src/test/queries/clientpositive/union_remove_23.q 63e4418
ql/src/test/queries/clientpositive/union_remove_24.q 88c378d
ql/src/test/queries/clientpositive/union_remove_25.q 27d9ebe
ql/src/test/queries/clientpositive/union_remove_3.q 7e1b113
ql/src/test/queries/clientpositive/union_remove_4.q 44b31d6
ql/src/test/queries/clientpositive/union_remove_5.q c5c0b7f
ql/src/test/queries/clientpositive/union_remove_6.q 6990ed2
ql/src/test/queries/clientpositive/union_remove_6_subq.q 8bcac6f
ql/src/test/queries/clientpositive/union_remove_7.q c254aba
ql/src/test/queries/clientpositive/union_remove_8.q 8dfb8e8
ql/src/test/queries/clientpositive/union_remove_9.q c9a4dc3
ql/src/test/queries/clientpositive/vector_decimal_10_0.q ae93058
ql/src/test/queries/clientpositive/vectorized_date_funcs.q 1fb0dac
ql/src/test/queries/clientpositive/vectorized_dynamic_partition_pruning.q 1197f7d
ql/src/test/results/clientnegative/authorization_cannot_create_all_role.q.out 99f20bd
ql/src/test/results/clientnegative/authorization_cannot_create_none_role.q.out 4808433
ql/src/test/results/clientnegative/lateral_view_join.q.out 8ad1386
ql/src/test/results/clientnegative/select_charliteral.q.out 09e409b
ql/src/test/results/clientnegative/serde_regex.q.out fc29724
ql/src/test/results/clientnegative/serde_regex2.q.out 198f79b
ql/src/test/results/clientnegative/serde_regex3.q.out 1df4cd6
ql/src/test/results/clientpositive/ambiguitycheck.q.out PRE-CREATION
ql/src/test/results/clientpositive/array_map_access_nonconstant.q.out d8b88c6
ql/src/test/results/clientpositive/decimal_10_0.q.out ae3426c
ql/src/test/results/clientpositive/keyword_1.q.out 135d8e5
ql/src/test/results/clientpositive/nonreserved_keywords_input37.q.out 819da22
ql/src/test/results/clientpositive/nonreserved_keywords_insert_into1.q.out 9f075f1
ql/src/test/results/clientpositive/partition_wise_fileformat17.q.out e9502e0
ql/src/test/results/clientpositive/partition_wise_fileformat18.q.out 5d75ff8
ql/src/test/results/clientpositive/ppd_field_garbage.q.out 86eca5b
ql/src/test/results/clientpositive/serde_regex.q.out 19187ba
ql/src/test/results/clientpositive/spark/union_remove_1.q.out 581d305
ql/src/test/results/clientpositive/spark/union_remove_10.q.out 629f7ba
ql/src/test/results/clientpositive/spark/union_remove_11.q.out 257d2ff
ql/src/test/results/clientpositive/spark/union_remove_12.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_13.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_14.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_15.q.out 09cd5d3
ql/src/test/results/clientpositive/spark/union_remove_16.q.out 0db279f
ql/src/test/results/clientpositive/spark/union_remove_17.q.out 8f317de
ql/src/test/results/clientpositive/spark/union_remove_18.q.out 96c8c25
ql/src/test/results/clientpositive/spark/union_remove_19.q.out 7049a91
ql/src/test/results/clientpositive/spark/union_remove_2.q.out 298929d
ql/src/test/results/clientpositive/spark/union_remove_20.q.out 328b1ac
ql/src/test/results/clientpositive/spark/union_remove_21.q.out b160397
ql/src/test/results/clientpositive/spark/union_remove_22.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_23.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_24.q.out 8bc748d
ql/src/test/results/clientpositive/spark/union_remove_25.q.out 396a43d
ql/src/test/results/clientpositive/spark/union_remove_3.q.out bac5441
ql/src/test/results/clientpositive/spark/union_remove_4.q.out e83788a
ql/src/test/results/clientpositive/spark/union_remove_5.q.out 0deb03d
ql/src/test/results/clientpositive/spark/union_remove_6.q.out 64c252d
ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out PRE-CREATION
ql/src/test/results/clientpositive/spark/union_remove_7.q.out 2d350a3
ql/src/test/results/clientpositive/spark/union_remove_8.q.out e6ab825
ql/src/test/results/clientpositive/spark/union_remove_9.q.out 1eef57a
ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 21e0876
ql/src/test/results/clientpositive/tez/tez_union_group_by.q.out 32c961d
ql/src/test/results/clientpositive/tez/vector_decimal_10_0.q.out 6f2b221
ql/src/test/results/clientpositive/tez/vectorized_date_funcs.q.out be782e4
ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 6fde788
ql/src/test/results/clientpositive/union_remove_1.q.out 411f63e
ql/src/test/results/clientpositive/union_remove_10.q.out d80bf32
ql/src/test/results/clientpositive/union_remove_11.q.out 23ab7c6
ql/src/test/results/clientpositive/union_remove_12.q.out f9fd323
ql/src/test/results/clientpositive/union_remove_13.q.out b8913e2
ql/src/test/results/clientpositive/union_remove_14.q.out 28e4bb6
ql/src/test/results/clientpositive/union_remove_15.q.out faf3e58
ql/src/test/results/clientpositive/union_remove_16.q.out 8656c11
ql/src/test/results/clientpositive/union_remove_17.q.out 386b023
ql/src/test/results/clientpositive/union_remove_18.q.out 0ce6e81
ql/src/test/results/clientpositive/union_remove_19.q.out b6d557b
ql/src/test/results/clientpositive/union_remove_2.q.out b9e575b
ql/src/test/results/clientpositive/union_remove_20.q.out b2819ce
ql/src/test/results/clientpositive/union_remove_21.q.out ac20851
ql/src/test/results/clientpositive/union_remove_22.q.out a8257d0
ql/src/test/results/clientpositive/union_remove_23.q.out a2ed7f3
ql/src/test/results/clientpositive/union_remove_24.q.out d0ac662
ql/src/test/results/clientpositive/union_remove_25.q.out 8c93ead
ql/src/test/results/clientpositive/union_remove_3.q.out e210461
ql/src/test/results/clientpositive/union_remove_4.q.out 2291a43
ql/src/test/results/clientpositive/union_remove_5.q.out 26179f5
ql/src/test/results/clientpositive/union_remove_6.q.out ff23e2d
ql/src/test/results/clientpositive/union_remove_6_subq.q.out be15c1f
ql/src/test/results/clientpositive/union_remove_7.q.out f0e59cb
ql/src/test/results/clientpositive/union_remove_8.q.out 2cba717
ql/src/test/results/clientpositive/union_remove_9.q.out 75925ac
ql/src/test/results/clientpositive/vector_decimal_10_0.q.out 1fb0e30
ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 8cde444
Diff: https://reviews.apache.org/r/30956/diff/
Testing
-------
Thanks,
pengcheng xiong