[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16228: [improve][java client] No need print exception stack when DLQ send failed.

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #16228:
URL: https://github.com/apache/pulsar/pull/16228#discussion_r908633381


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2001,15 +2001,15 @@ private CompletableFuture<Boolean> processPossibleToDLQ(MessageIdImpl messageId)
                                 acknowledgeAsync(finalMessageId).whenComplete((v, ex) -> {
                                     if (ex != null) {
                                         log.warn("[{}] [{}] [{}] Failed to acknowledge the message {} of the original"
-                                                        + " topic but send to the DLQ successfully.",
-                                                topicName, subscription, consumerName, finalMessageId, ex);
+                                                        + " topic but send to the DLQ successfully {}.",
+                                                topicName, subscription, consumerName, finalMessageId, ex.getMessage());

Review Comment:
   Oh sorry, we should only skip the stacktrace for QueueFullException, not for all exceptions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org