[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

[kiszk <gi...@git.apache.org>]

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23154#discussion_r236919395
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ---
    @@ -204,10 +204,10 @@ case class UnresolvedGenerator(name: FunctionIdentifier, children: Seq[Expressio
         throw new UnsupportedOperationException(s"Cannot evaluate expression: $this")
     
       override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode =
    -    throw new UnsupportedOperationException(s"Cannot evaluate expression: $this")
    +    throw new UnsupportedOperationException(s"Cannot generate code expression: $this")
    --- End diff --
    
    Is it better to use `generate code for expression` or others rather than `generate code expression`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org