You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/18 09:54:50 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request, #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Pearl1594 opened a new pull request, #6279:
URL: https://github.com/apache/cloudstack/pull/6279
### Description
This PR removes the requirement to pass a root disk controller while either registering a template or while updating a template
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Legacy UI did not enforce root disk controller to be passed:
### How Has This Been Tested?
Registered / Attempted editing a template without passing root disk controller & deployed VM with the template
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6279:
URL: https://github.com/apache/cloudstack/pull/6279#issuecomment-1101282304
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6279 (SL-JID-1390)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6279:
URL: https://github.com/apache/cloudstack/pull/6279#issuecomment-1101278449
yes @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Posted by GitBox <gi...@apache.org>.
rohityadavcloud closed pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
URL: https://github.com/apache/cloudstack/pull/6279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6279:
URL: https://github.com/apache/cloudstack/pull/6279#issuecomment-1101278757
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6279:
URL: https://github.com/apache/cloudstack/pull/6279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6279:
URL: https://github.com/apache/cloudstack/pull/6279#issuecomment-1101279072
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Posted by GitBox <gi...@apache.org>.
rohityadavcloud closed pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
URL: https://github.com/apache/cloudstack/pull/6279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6279: ui: remove mandatory rule on root disk controller field while registering / updating a template
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6279:
URL: https://github.com/apache/cloudstack/pull/6279#issuecomment-1101289782
(testing new github actions integration that will automate some actions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org