You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2013/09/27 16:03:14 UTC

svn commit: r1526907 - /tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ooxml/OOXMLParserTest.java

Author: tallison
Date: Fri Sep 27 14:03:14 2013
New Revision: 1526907

URL: http://svn.apache.org/r1526907
Log:
second attempt to add test for detecting missing ooxml bean. Builds successfully locally.  Jenkins failed last time.  Stack traces didn't point to this test; but redirecting stderr may be the culprit.

Modified:
    tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ooxml/OOXMLParserTest.java

Modified: tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ooxml/OOXMLParserTest.java
URL: http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ooxml/OOXMLParserTest.java?rev=1526907&r1=1526906&r2=1526907&view=diff
==============================================================================
--- tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ooxml/OOXMLParserTest.java (original)
+++ tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ooxml/OOXMLParserTest.java Fri Sep 27 14:03:14 2013
@@ -1001,10 +1001,7 @@ public class OOXMLParserTest extends Tik
         String content = handler.toString();
         assertContains("some autoshape", content);    
     }    
-/*
-    Jenkins failed to build after adding this.
-    Need to determine if this is the cause, and, if so, how to test for
-    missing beans.
+
     //TIKA-792; with room for future missing bean tests
     public void testWordMissingOOXMLBeans() throws Exception{
         //If a bean is missing, POI prints stack trace to stderr 
@@ -1013,18 +1010,22 @@ public class OOXMLParserTest extends Tik
         };
         PrintStream origErr = System.err;
         for (String fileName : fileNames){
-            ByteArrayOutputStream errContent = new ByteArrayOutputStream();
-            System.setErr(new PrintStream(errContent));
             Metadata metadata = new Metadata(); 
             ContentHandler handler = new BodyContentHandler();
             ParseContext context = new ParseContext();
             InputStream input = getTestDocument(fileName);
+            
+            //grab stderr
+            ByteArrayOutputStream errContent = new ByteArrayOutputStream();
+            System.setErr(new PrintStream(errContent));
             parser.parse(input, handler, metadata, context);
-    
+            
+            //return stderr
+            System.setErr(origErr);
+            
             String err = errContent.toString();
             assertTrue(err.length() == 0);
             input.close();
         }
-        System.setErr(origErr);
-    }*/
+    }
 }