You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/12 21:54:09 UTC
[I] [docs] the link to the incubator svg in our footer is broken on some pages [incubator-pekko-http]
pjfanning opened a new issue, #482:
URL: https://github.com/apache/incubator-pekko-http/issues/482
https://pekko.apache.org/docs/pekko-http/current/introduction.html is fine
it links to
https://pekko.apache.org/docs/pekko-http/current/assets/images/apache-incubator.svg
https://pekko.apache.org/docs/pekko-http/current/client-side/http2.html has wrong link
it links to
https://pekko.apache.org/docs/pekko-http/current/client-side/assets/images/apache-incubator.svg
Note the stray `/client-side` in the image URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] [docs] the link to the incubator svg in our footer is broken on some pages [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #482:
URL: https://github.com/apache/incubator-pekko-http/issues/482#issuecomment-1948307163
My hope is that we can win a vote to become a TLP. We would then need to remove the Incubator references and release the paradox code. Even if we fail, we should do a paradox release - I just want to wait to see if can win the vote first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] [docs] the link to the incubator svg in our footer is broken on some pages [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #482:
URL: https://github.com/apache/incubator-pekko-http/issues/482#issuecomment-1948069238
I will retry 1.0.0+10-9676045b-SNAPSHOT but it did not seem to work as expected for me. I will double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] [docs] the link to the incubator svg in our footer is broken on some pages [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #482:
URL: https://github.com/apache/incubator-pekko-http/issues/482#issuecomment-1939656821
@samueleresca this might be a pre-existing issue but is there a chance that the recent changes to our pekko-sbt-paradox and pekko-site setup could be an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] [docs] the link to the incubator svg in our footer is broken on some pages [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #482:
URL: https://github.com/apache/incubator-pekko-http/issues/482#issuecomment-1939735662
I suspect that this is a long running issue. I tried building with the pekko-http docs locally using the latest pekko-sbt-paradox snapshot but had the same issue.
I would like to change the link in footer.st to be an absolute URL to avoid the need to worry about the nesting of the docs.
Just link to https://pekko.apache.org/assets/images/apache-incubator.svg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] [docs] the link to the incubator svg in our footer is broken on some pages [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #482:
URL: https://github.com/apache/incubator-pekko-http/issues/482#issuecomment-1948130964
@samueleresca I tried that again and it worked. I'll close my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] [docs] the link to the incubator svg in our footer is broken on some pages [incubator-pekko-http]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on issue #482:
URL: https://github.com/apache/incubator-pekko-http/issues/482#issuecomment-1948298787
@pjfanning Do we have any plan for kicking off the release of `pekko-sbt-paradox`? I can help in case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] [docs] the link to the incubator svg in our footer is broken on some pages [incubator-pekko-http]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on issue #482:
URL: https://github.com/apache/incubator-pekko-http/issues/482#issuecomment-1948065952
Yes the problem is that the path is relative in the source: `assets/images/apache-incubator.svg`.
> I suspect that this is a long running issue. I tried building with the pekko-http docs locally using the latest pekko-sbt-paradox snapshot but had the same issue.
>
> I would like to change the link in footer.st to be an absolute URL to avoid the need to worry about the nesting of the docs.
>
> Just link to https://pekko.apache.org/assets/images/apache-incubator.svg
Could you please double check? I tried to update `pekko-sbt-paradox` at the `1.0.0+10-9676045b-SNAPSHOT` snapshot locally and it seems producing the right URL for the image in the HTML source: `https://pekko.apache.org/assets/images/apache-incubator.svg` after building the doc with `sbt docs/paradox`:
```
<img src="https://pekko.apache.org/assets/images/apache-incubator.svg" alt="Apache Incubator logo" id="incubator__logo">
```
If the local build is working correctly I don't think [incubator-pekko-sbt-paradox/#101](https://github.com/apache/incubator-pekko-sbt-paradox/pull/101) is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] [docs] the link to the incubator svg in our footer is broken on some pages [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #482: [docs] the link to the incubator svg in our footer is broken on some pages
URL: https://github.com/apache/pekko-http/issues/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org