[GitHub] [tinkerpop] tkolanko commented on a diff in pull request #1837: TINKERPOP-2806 Provide method for provider plugins to get notified on script/query processing

[GitBox <gi...@apache.org>]

tkolanko commented on code in PR #1837:
URL: https://github.com/apache/tinkerpop/pull/1837#discussion_r1003326161


##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java:
##########
@@ -231,9 +233,18 @@ protected void evalOpInternal(final Context ctx, final Supplier<GremlinExecutor>
         final GremlinExecutor.LifeCycle lifeCycle = GremlinExecutor.LifeCycle.build()
                 .evaluationTimeoutOverride(seto)
                 .afterFailure((b,t) -> {
+                    graphManager.onQueryError(msg, t);
                     if (managedTransactionsForRequest) attemptRollback(msg, ctx.getGraphManager(), settings.strictTransactionManagement);
                 })
+                .afterTimeout(b -> {

Review Comment:
   In https://github.com/apache/tinkerpop/pull/1837/commits/3e5a38c2a8f1553898418015560c6f6d42654101 I refactored all instances of afterTimeout to switch from a Consumer to a BiConsumer so that it can be called with the original exception. It was a smallish change, however, I'm not sure the best way to update the docs to indiciate the signature change and given that this is now a breaking change I think it should be targetted for the next major. I'm not sure how prevalent lifecycle usages are in the wild 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org