You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2024/05/28 19:17:26 UTC
[I] Reuse previous `CometDictionary` Java arrays [datafusion-comet]
viirya opened a new issue, #488:
URL: https://github.com/apache/datafusion-comet/issues/488
### Describe the bug
After #474, `ColumnReader.loadVector` initiates `CometDictionary` after re-import arrays. It is reported by @andygrove (https://github.com/apache/datafusion-comet/pull/473#issuecomment-2133964232) that after the patch, there is obvious regression when comparing with Spark.
It is because, although re-importing dictionary values is fast, `CometDictionary` has an initialization step to copy values from imported dictionary values to an internal Java array. We need to re-use previous `CometDictionary`'s copied Java arrays.
### Steps to reproduce
_No response_
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Reuse previous `CometDictionary` Java arrays [datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed issue #488: Reuse previous `CometDictionary` Java arrays
URL: https://github.com/apache/datafusion-comet/issues/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org