[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #126: [MPLUGIN-410] Create implementation attribute for @Parameter

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-plugin-tools/pull/126#discussion_r928574065


##########
maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Parameter.java:
##########
@@ -72,6 +72,13 @@
      */
     String defaultValue() default "";
 
+    /**
+     * Defines the implementation in the case the parameter type is an interface.
+     *
+     * @return the implementation class name
+     */
+    Class<?> implementation() default Object.class;

Review Comment:
   When user uses annotation in their code, they have access to all classes. 
   
   In plugin-tools we operate on Type from asm, and finally on class name as string, so we needn't access to class.
   
   I hope that define property as class will be less error-prone from user perspective.
   
   The previous implementation was only for javadoc tags ... so must be string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org