You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Jie Yu (JIRA)" <ji...@apache.org> on 2015/11/07 01:48:10 UTC
[jira] [Commented] (MESOS-3847) Root tests for
LinuxFilesystemIsolatorTest are broken
[ https://issues.apache.org/jira/browse/MESOS-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994792#comment-14994792 ]
Jie Yu commented on MESOS-3847:
-------------------------------
commit 5f8c7dc0918204d234698a1f963244e3f6d05d39
Author: Joseph Wu <jo...@mesosphere.io>
Date: Fri Nov 6 16:15:10 2015 -0800
TemporaryDirectoryTest Merge: Remove non-Stout version of
`TemporaryDirectoryTest`.
The special cleanup in the non-Stout `TemporaryDirectoryTest` was moved
into `LinuxFilesystemIsolatorTest`. `LinuxFilesystemIsolatorTest`
creates additional mounts as part of its tests. No other tests require
the special cleanup logic to pass.
Review: https://reviews.apache.org/r/40001
commit 2d066793cc0dd060a7ca4a7d329d4da11c576adb
Author: Joseph Wu <jo...@mesosphere.io>
Date: Fri Nov 6 16:14:52 2015 -0800
TemporaryDirectoryTest Merge: Point tests to the Stout version of the
`TemporaryDirectoryTest`.
We have two `TemporaryDirectoryTest` classes, which have almost
identical contents.
Note: The `LinuxFilesystemIsolatorTest` will be changed separately, as
it requires some special cleanup.
Review: https://reviews.apache.org/r/40000
commit c10391f67b0aa6fc975c887880dfe3cbb865b79c
Author: Joseph Wu <jo...@mesosphere.io>
Date: Fri Nov 6 16:14:36 2015 -0800
TemporaryDirectoryTest Merge: Elevate `TemporaryDirectoryTest::sandbox`
from private to protected.
Some tests, such as those in `provisioner_backend_tests.cpp`, need to
refer to the `sandbox` variable during their tear down.
Review: https://reviews.apache.org/r/40035
> Root tests for LinuxFilesystemIsolatorTest are broken
> -----------------------------------------------------
>
> Key: MESOS-3847
> URL: https://issues.apache.org/jira/browse/MESOS-3847
> Project: Mesos
> Issue Type: Bug
> Reporter: Joseph Wu
> Assignee: Joseph Wu
> Priority: Minor
> Labels: mesosphere
> Fix For: 0.26.0
>
>
> The refactor in [MESOS-3762] ended up exposing some differences in the {{TemporaryDirectoryTest}} classes (one in Stout, one in Mesos-proper).
> The tests that broke (during tear down):
> {code}
> LinuxFilesystemIsolatorTest.ROOT_PersistentVolumeWithRootFilesystem
> LinuxFilesystemIsolatorTest.ROOT_PersistentVolumeWithoutRootFilesystem
> LinuxFilesystemIsolatorTest.ROOT_MultipleContainers
> {code}
> As per an offline discussion between [~jvanremoortere] and [~jieyu], the solution is to merge the two {{TemporaryDirectoryTest}} classes and to fix the tear down of {{LinuxFilesystemIsolatorTest}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)