[GitHub] [hadoop] amahussein commented on a change in pull request #2408: HDFS-15643. TestFileChecksumCompositeCrc is flaky

[GitBox <gi...@apache.org>]

amahussein commented on a change in pull request #2408:
URL: https://github.com/apache/hadoop/pull/2408#discussion_r511163105



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileChecksum.java
##########
@@ -487,9 +497,7 @@ public void testStripedFileChecksumWithMissedDataBlocksRangeQuery16()
   @Test(timeout = 90000)
   public void testStripedFileChecksumWithMissedDataBlocksRangeQuery17()
       throws Exception {
-    int fileLength = 100;
     String stripedFile3 = ecDir + "/stripedFileChecksum3";
-    prepareTestFiles(fileLength, new String[] {stripedFile3});

Review comment:
       Hey @goiri 
   I was scratching my head too. `testStripedFileChecksumWithMissedDataBlocksRangeQuery` takes a file path, then it calls  `prepareTestFiles(fileSize, new String[] {stripedFile});`. Surprisingly, `TestFileChecksum#fileSize` is constant. It seems the test was creating the file twice..
   I assume this is a result of a copy-paste thing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org