You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "thomas-gantenbein-tga (via GitHub)" <gi...@apache.org> on 2024/01/06 08:55:31 UTC

[PR] CAMEL-20264: Removed unused `AvailablePortFinder`, simplified another… [camel]

thomas-gantenbein-tga opened a new pull request, #12680:
URL: https://github.com/apache/camel/pull/12680

   I got rid of one `AvailablePortFinder` in `camel-management` and simplified the `AvailablePortFinder` in `camel-jbang-core`.
   
   I haven't, however, merged `/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/AvailablePortFinder.java` and `dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/AvailablePortFinder.java` into a single class, as suggested in CAMEL-20264. 
   
   Why? The `AvailablePortFinder` in `camel-test-junit5` is using annotations from `junit-jupiter-api` and the `AvailablePortFinder` in `camel-jbang-core` is not a test class. So I'd have to include `junit-jupiter-api` with compile scope to make it work for both `camel-jbang-core` and for the zillion of components that make use of `camel-test-junit5` and its inner class `Port`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20264: Removed unused `AvailablePortFinder`, simplified another… [camel]

Posted by "orpiske (via GitHub)" <gi...@apache.org>.

orpiske merged PR #12680:
URL: https://github.com/apache/camel/pull/12680


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20264: Removed unused `AvailablePortFinder`, simplified another… [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #12680:
URL: https://github.com/apache/camel/pull/12680#issuecomment-1879598344

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions to run
   
   * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org