[GitHub] [yunikorn-core] craigcondit commented on a diff in pull request #507: [YUNIKORN-1385] To provide visibility to application's aggregated resource consumption

["craigcondit (via GitHub)" <gi...@apache.org>]

craigcondit commented on code in PR #507:
URL: https://github.com/apache/yunikorn-core/pull/507#discussion_r1188920805


##########
pkg/metrics/init.go:
##########
@@ -229,3 +236,7 @@ func formatMetricName(metricName string) string {
 	}
 	return string(newBytes)
 }
+
+func (m *Metrics) LogAppSummary(appSummary string) {
+	log.Println(AppSummaryHeader + appSummary)
+}

Review Comment:
   This needs to go through the zap Logger or we risk corrupting output. The standard log package goes directly to stdout/stderr and does not use a consistent format. The AppSummaryHeader should be a zap.String("key", "value") as well, this allows for JSON-filtering of the resulting message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org