You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2014/12/29 14:38:45 UTC

[GitHub] thrift pull request: THRIFT-2878 - Go validation support of requir...

Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/304#issuecomment-68257838
  
    Hi @cvlchinet, 
    
    good work! Just one thing: What about changing the test case to use the existing OptionalRequiredTest.thrift IDL instead of adding a new IDL file? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---