You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/13 03:33:53 UTC
[GitHub] [apisix] tzssangglass opened a new pull request #5046: chore(debug-mode): move 'enable_debug' form config.yaml to debug.yaml
tzssangglass opened a new pull request #5046:
URL: https://github.com/apache/apisix/pull/5046
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
move 'enable_debug' form config.yaml to debug.yaml, make the configuration of debug mode clear and central
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5046: chore(debug-mode): move 'enable_debug' form config.yaml to debug.yaml
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #5046:
URL: https://github.com/apache/apisix/pull/5046#discussion_r707874607
##########
File path: conf/debug.yaml
##########
@@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+enable_debug: false
Review comment:
Looks better, but this `enable` will conflict with https://github.com/apache/apisix/blob/b52f95b53c689cfd2fd0f4cbf0fefedd4cce9b5e/t/debug/hook.t#L34
I don't know how to modify this with perl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5046: chore(debug-mode): move 'enable_debug' form config.yaml to debug.yaml
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5046:
URL: https://github.com/apache/apisix/pull/5046#discussion_r707867827
##########
File path: conf/debug.yaml
##########
@@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+enable_debug: false
Review comment:
```suggestion
basic:
enable: false
```
would be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5046: chore(debug-mode): move 'enable_debug' form config.yaml to debug.yaml
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5046:
URL: https://github.com/apache/apisix/pull/5046#discussion_r707832150
##########
File path: docs/zh/latest/architecture-design/debug-mode.md
##########
@@ -23,7 +23,7 @@ title: Debug Mode
### 基本调试模式
-设置 `conf/config.yaml` 中的 `apisix.enable_debug` 为 `true`，即可开启基本调试模式。
+设置 `conf/debug.yaml` 中的 `enable_debug` 为 `true`，即可开启基本调试模式。
Review comment:
Hi, for those who using apisix versions before 2.9.0, this document may be confused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5046: chore(debug-mode): move 'enable_debug' form config.yaml to debug.yaml
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5046:
URL: https://github.com/apache/apisix/pull/5046#discussion_r707876544
##########
File path: conf/debug.yaml
##########
@@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+enable_debug: false
Review comment:
Let me do it for you 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5046: chore(debug-mode): move 'enable_debug' form config.yaml to debug.yaml
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5046:
URL: https://github.com/apache/apisix/pull/5046#discussion_r707840296
##########
File path: docs/zh/latest/architecture-design/debug-mode.md
##########
@@ -23,7 +23,7 @@ title: Debug Mode
### 基本调试模式
-设置 `conf/config.yaml` 中的 `apisix.enable_debug` 为 `true`，即可开启基本调试模式。
+设置 `conf/debug.yaml` 中的 `enable_debug` 为 `true`，即可开启基本调试模式。
Review comment:
We can add a note for the version before 2.10.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5046: change(debug): move 'enable_debug' form config.yaml to debug.yaml
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5046:
URL: https://github.com/apache/apisix/pull/5046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org