You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ivan A. Veselovsky (JIRA)" <ji...@apache.org> on 2012/11/14 17:04:11 UTC
[jira] [Created] (HADOOP-9038) provide unit-test coverage of class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Ivan A. Veselovsky created HADOOP-9038:
------------------------------------------
Summary: provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Key: HADOOP-9038
URL: https://issues.apache.org/jira/browse/HADOOP-9038
Project: Hadoop Common
Issue Type: Test
Reporter: Ivan A. Veselovsky
Assignee: Ivan A. Veselovsky
Priority: Minor
The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9038) provide unit-test coverage of
class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503987#comment-13503987 ]
Hudson commented on HADOOP-9038:
--------------------------------
Integrated in Hadoop-trunk-Commit #3058 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3058/])
HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9038) provide unit-test coverage of class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Ivan A. Veselovsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan A. Veselovsky updated HADOOP-9038:
---------------------------------------
Attachment: HADOOP-9038.patch
attached patch "HADOOP-9038" adds a new unit test to check the mentioned functionality, + makes one correction in method PathIterator#next() implementation.
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9038) provide unit-test coverage of
class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504583#comment-13504583 ]
Hudson commented on HADOOP-9038:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #448 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/448/])
svn merge -c 1413776 FIXES: HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413779)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413779
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9038) provide unit-test coverage of
class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504609#comment-13504609 ]
Hudson commented on HADOOP-9038:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1270 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1270/])
HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9038) provide unit-test coverage of class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Ivan A. Veselovsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan A. Veselovsky updated HADOOP-9038:
---------------------------------------
Status: Patch Available (was: Open)
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9038) provide unit-test coverage of
class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503975#comment-13503975 ]
Robert Joseph Evans commented on HADOOP-9038:
---------------------------------------------
The changes look fine to me. I like that we are now conforming correctly to the Iterable interface. +1
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9038) provide unit-test coverage of
class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504524#comment-13504524 ]
Hudson commented on HADOOP-9038:
--------------------------------
Integrated in Hadoop-Yarn-trunk #49 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/49/])
HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9038) provide unit-test coverage of class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-9038:
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.6
2.0.3-alpha
3.0.0
Status: Resolved (was: Patch Available)
Thanks Ivan,
I put this into trunk, branch-2, and branch-0.23
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9038) provide unit-test coverage of
class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498017#comment-13498017 ]
Hadoop QA commented on HADOOP-9038:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553652/HADOOP-9038.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1750//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1750//console
This message is automatically generated.
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9038) provide unit-test coverage of
class
org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504592#comment-13504592 ]
Hudson commented on HADOOP-9038:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1239 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1239/])
HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
> provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator
> -----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9038
> URL: https://issues.apache.org/jira/browse/HADOOP-9038
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
> Attachments: HADOOP-9038.patch
>
>
> The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira