You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ptgoetz <gi...@git.apache.org> on 2016/10/25 19:09:54 UTC
[GitHub] storm pull request #1745: STORM-2174: Initial Base for Storm Beam Runner
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/1745
STORM-2174: Initial Base for Storm Beam Runner
This is an (very) initial pass at laying the foundation for a Beam runner for Storm. It currently only supports local mode, and is incomplete (and likely wrong in places) in terms of supporting the basic word count pipeline example.
The goal of getting this committed into a feature branch is to enable others to collaborate and contribute to the effort.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/storm beam-runner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1745
----
commit c64313eb8b89551ab1bbd4267c70e406ee1b5bea
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2016-10-25T18:39:55Z
STORM-2174: Initial commit for beam runner.
commit 7de6eedb455e3916aebaf561b180dbc9247ee4b6
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2016-10-25T18:45:43Z
STORM-2174: Apply ALv2 license headers
commit 6516defc0e83c12a4aaf147b3c81bc74ec364f72
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2016-10-25T18:58:37Z
STORM-2174: update beam dependency to released version 0.2.0-incubating
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1745: STORM-2174: Initial Base for Storm Beam Runner
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1745
@revans2 @arunmahadevan Thanks for the review. I will merge this to the beam runner feature branch so others can submit pull requests against it.
@arunmahadevan Yes, the GBK implementation is wrong. It's a WIP to get data moving between components.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1745: STORM-2174: Initial Base for Storm Beam Runner
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1745
Looks good overall. Didn't spend a lot of time digging in to all the details but it looks like a really nice start.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1745: STORM-2174: Initial Base for Storm Beam Runner
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1745
@ptgoetz I had tried to run the word count with the storm runner when the patch was posted, but there were some issues with the way grouping is implemented. I didn't get time to dig in further. Overall its a good start and may be we should merge it in as is and refactor it to use the proposed streams api once that gets merged which would simplify a lot of things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1745: STORM-2174: Initial Base for Storm Beam Runner
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---