You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2011/02/16 16:11:57 UTC
[jira] Created: (MATH-514) Replace the "ParametricGaussianFunction"
class
Replace the "ParametricGaussianFunction" class
----------------------------------------------
Key: MATH-514
URL: https://issues.apache.org/jira/browse/MATH-514
Project: Commons Math
Issue Type: Improvement
Reporter: Gilles
Assignee: Gilles
Priority: Minor
Fix For: 3.0
The "ParametricGaussianFunction" is defined in package "optimization.fitting" whereas it is not specific to the fitting concept. It would be more logical to have that functionality provided as an inner class of the "Gaussian" class (in package "analysis.function").
Moreover, no unit test in "ParametricGaussianFunctionTest" actually tests the code of the "value" and "gradient" methods, while tests in that class duplicate some of the tests in "GaussianFitterTest" (thus testing the fitting code instead of the function).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (MATH-514) Replace the
"ParametricGaussianFunction" class
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles resolved MATH-514.
-------------------------
Resolution: Fixed
Class removed in revision 1072207.
> Replace the "ParametricGaussianFunction" class
> ----------------------------------------------
>
> Key: MATH-514
> URL: https://issues.apache.org/jira/browse/MATH-514
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
>
> The "ParametricGaussianFunction" is defined in package "optimization.fitting" whereas it is not specific to the fitting concept. It would be more logical to have that functionality provided as an inner class of the "Gaussian" class (in package "analysis.function").
> Moreover, no unit test in "ParametricGaussianFunctionTest" actually tests the code of the "value" and "gradient" methods, while tests in that class duplicate some of the tests in "GaussianFitterTest" (thus testing the fitting code instead of the function).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MATH-514) Replace the
"ParametricGaussianFunction" class
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995562#comment-12995562 ]
Gilles commented on MATH-514:
-----------------------------
A "Parametric" inner is class has been defined in class "Gaussian" (in revision 1071430).
The "ParametricGaussianFunction" will not be deleted until MATH-512 is resolved (among other things by using "Gaussian.Parametric" instead of "ParametricGaussianFunction").
> Replace the "ParametricGaussianFunction" class
> ----------------------------------------------
>
> Key: MATH-514
> URL: https://issues.apache.org/jira/browse/MATH-514
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
>
> The "ParametricGaussianFunction" is defined in package "optimization.fitting" whereas it is not specific to the fitting concept. It would be more logical to have that functionality provided as an inner class of the "Gaussian" class (in package "analysis.function").
> Moreover, no unit test in "ParametricGaussianFunctionTest" actually tests the code of the "value" and "gradient" methods, while tests in that class duplicate some of the tests in "GaussianFitterTest" (thus testing the fitting code instead of the function).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira