You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/08 18:55:52 UTC

[GitHub] [airflow] jpyen commented on a change in pull request #16318: Fix API List DAGs inconsistent with UI/CLI

jpyen commented on a change in pull request #16318:
URL: https://github.com/apache/airflow/pull/16318#discussion_r647713834



##########
File path: tests/api_connexion/endpoints/test_dag_endpoint.py
##########
@@ -387,6 +396,7 @@ def test_should_raise_404_when_dag_is_not_found(self):
 class TestGetDags(TestDagEndpoint):
     def test_should_respond_200(self):
         self._create_dag_models(2)
+        self._create_deactivated_dag()

Review comment:
       Number of DAGs in DagModel should exclude inactive DAGs, as far as I understand. In my opinion are inactive DAGs `.trash` and play no significant role.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org