[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2797: Make maxConcurrentZkRequests for gc configurable

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #2797:
URL: https://github.com/apache/bookkeeper/pull/2797#discussion_r711518760



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java
##########
@@ -101,14 +101,16 @@ public ScanAndCompareGarbageCollector(LedgerManager ledgerManager, CompactableLe
         if (gcOverReplicatedLedgerIntervalMillis > 0) {
             this.enableGcOverReplicatedLedger = true;
         }
+        this.maxConcurrentRequests = conf.getGcOverreplicatedLedgerMaxConcurrentRequests();
         this.zkServers = ZKMetadataDriverBase.resolveZkServers(conf);
         this.zkLedgersRootPath = ZKMetadataDriverBase.resolveZkLedgersRootPath(conf);
-        LOG.info("Over Replicated Ledger Deletion : enabled=" + enableGcOverReplicatedLedger + ", interval="
-                + gcOverReplicatedLedgerIntervalMillis);
+        LOG.info("Over Replicated Ledger Deletion : enabled={}, interval={}, maxConcurrentRequest={}",

Review comment:
       Typo: maxConcurrentRequest > maxConcurrentRequests




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org