You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/08/26 01:49:12 UTC
Review Request 37779: Added labels documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-2413
https://issues.apache.org/jira/browse/MESOS-2413
Repository: mesos
Description
-------
Added labels documentation to the framework development guide.
Diffs
-----
docs/app-framework-development-guide.md db0181c0b82fded1860ef636747e70d80e3884f2
Diff: https://reviews.apache.org/r/37779/diff/
Testing
-------
Rendered in Marked2
Thanks,
Niklas Nielsen
Re: Review Request 37779: Added labels documentation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96473
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37779]
All tests passed.
- Mesos ReviewBot
On Aug. 26, 2015, 12:42 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 12:42 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added labels documentation to the framework development guide.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md db0181c0b82fded1860ef636747e70d80e3884f2
>
> Diff: https://reviews.apache.org/r/37779/diff/
>
>
> Testing
> -------
>
> Rendered in Marked2
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 37779: Added labels documentation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96502
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 26, 2015, 12:42 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 12:42 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added labels documentation to the framework development guide.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md db0181c0b82fded1860ef636747e70d80e3884f2
>
> Diff: https://reviews.apache.org/r/37779/diff/
>
>
> Testing
> -------
>
> Rendered in Marked2
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 37779: Added labels documentation.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 5:42 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Ignore previous patch; needed rebase
Bugs: MESOS-2413
https://issues.apache.org/jira/browse/MESOS-2413
Repository: mesos
Description
-------
Added labels documentation to the framework development guide.
Diffs (updated)
-----
docs/app-framework-development-guide.md db0181c0b82fded1860ef636747e70d80e3884f2
Diff: https://reviews.apache.org/r/37779/diff/
Testing
-------
Rendered in Marked2
Thanks,
Niklas Nielsen
Re: Review Request 37779: Added labels documentation.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Aug. 25, 2015, 5:38 p.m., Kapil Arya wrote:
> > Looks like you got some unwanted diffs in there :-).
Whoops - should be updated now
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96464
-----------------------------------------------------------
On Aug. 25, 2015, 5:42 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added labels documentation to the framework development guide.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md db0181c0b82fded1860ef636747e70d80e3884f2
>
> Diff: https://reviews.apache.org/r/37779/diff/
>
>
> Testing
> -------
>
> Rendered in Marked2
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 37779: Added labels documentation.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96464
-----------------------------------------------------------
Looks like you got some unwanted diffs in there :-).
- Kapil Arya
On Aug. 25, 2015, 8:34 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 8:34 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added labels documentation to the framework development guide.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eb34251d24b1e5d1540151b59cf1062ca85aeb03
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp db5e33220844d20ef08a7324f641eeb1ff6d2052
> 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 4010ad961b5e0cd6b26bfddd6f8761e2d6586c2b
> 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp fdd33512c8d8752093f72f597a7d647eb5e3c285
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 657aaef95e6969e07e94a47d9e868e2bc5cd703d
> 3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp f109e97936a00c6a5503d354c1682850786e026d
> 3rdparty/libprocess/3rdparty/stout/tests/try_tests.cpp 0a126397b74c441ec1c06711cb80a144ed8a7f63
> 3rdparty/libprocess/Makefile.am 7ef515848508c2e84ab7607595f635f67e24b19b
> 3rdparty/libprocess/include/process/future.hpp 9006b8a83d03eab6e67de12a954110029b7d150e
> 3rdparty/libprocess/src/tests/future_tests.cpp bd33a5af7bc7b1d5b0c70cbe09c2cd369d9cba76
> docs/app-framework-development-guide.md db0181c0b82fded1860ef636747e70d80e3884f2
> docs/committers.md a44333e652ccfde57f97b5b9ede2765a26a4abb3
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99
> src/slave/containerizer/provisioners/appc/paths.hpp 41e3bf79da0854406c488855f953111e67353829
> src/slave/containerizer/provisioners/appc/paths.cpp 3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7
> src/slave/containerizer/provisioners/backend.hpp a25b4eaa1894178d4816cfbf1d9da2690bbe24bd
> src/slave/containerizer/provisioners/backend.cpp 2f7c335f62fdeb27526ab9a38a07c097422ae92b
> src/slave/containerizer/provisioners/backends/bind.hpp 61a883898ec170e7a61d04f78650f357de52ff0f
> src/slave/containerizer/provisioners/backends/bind.cpp 1cdae61786790dc6a475ae5f73c8cc92d2bbf739
> src/slave/paths.hpp 35b0439e89193b0933b33b67450008b0da9bbae7
> src/slave/paths.cpp f5697fb5bbb40064a55c4465210dcbdcd8630c87
> src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0
> src/tests/containerizer/provisioner_backend_tests.cpp 096bd4d4bbd602913796c5e542e033bdd9e04964
> src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b
> src/tests/utils.hpp d4fc6ac96e0cfd6924304dfa1e9e454a113f46f7
>
> Diff: https://reviews.apache.org/r/37779/diff/
>
>
> Testing
> -------
>
> Rendered in Marked2
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 37779: Added labels documentation.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 5:34 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Addressed comments from Kapil
Bugs: MESOS-2413
https://issues.apache.org/jira/browse/MESOS-2413
Repository: mesos
Description
-------
Added labels documentation to the framework development guide.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am eb34251d24b1e5d1540151b59cf1062ca85aeb03
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp db5e33220844d20ef08a7324f641eeb1ff6d2052
3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 4010ad961b5e0cd6b26bfddd6f8761e2d6586c2b
3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp fdd33512c8d8752093f72f597a7d647eb5e3c285
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 657aaef95e6969e07e94a47d9e868e2bc5cd703d
3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp f109e97936a00c6a5503d354c1682850786e026d
3rdparty/libprocess/3rdparty/stout/tests/try_tests.cpp 0a126397b74c441ec1c06711cb80a144ed8a7f63
3rdparty/libprocess/Makefile.am 7ef515848508c2e84ab7607595f635f67e24b19b
3rdparty/libprocess/include/process/future.hpp 9006b8a83d03eab6e67de12a954110029b7d150e
3rdparty/libprocess/src/tests/future_tests.cpp bd33a5af7bc7b1d5b0c70cbe09c2cd369d9cba76
docs/app-framework-development-guide.md db0181c0b82fded1860ef636747e70d80e3884f2
docs/committers.md a44333e652ccfde57f97b5b9ede2765a26a4abb3
include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99
src/slave/containerizer/provisioners/appc/paths.hpp 41e3bf79da0854406c488855f953111e67353829
src/slave/containerizer/provisioners/appc/paths.cpp 3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7
src/slave/containerizer/provisioners/backend.hpp a25b4eaa1894178d4816cfbf1d9da2690bbe24bd
src/slave/containerizer/provisioners/backend.cpp 2f7c335f62fdeb27526ab9a38a07c097422ae92b
src/slave/containerizer/provisioners/backends/bind.hpp 61a883898ec170e7a61d04f78650f357de52ff0f
src/slave/containerizer/provisioners/backends/bind.cpp 1cdae61786790dc6a475ae5f73c8cc92d2bbf739
src/slave/paths.hpp 35b0439e89193b0933b33b67450008b0da9bbae7
src/slave/paths.cpp f5697fb5bbb40064a55c4465210dcbdcd8630c87
src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0
src/tests/containerizer/provisioner_backend_tests.cpp 096bd4d4bbd602913796c5e542e033bdd9e04964
src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b
src/tests/utils.hpp d4fc6ac96e0cfd6924304dfa1e9e454a113f46f7
Diff: https://reviews.apache.org/r/37779/diff/
Testing
-------
Rendered in Marked2
Thanks,
Niklas Nielsen
Re: Review Request 37779: Added labels documentation.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96456
-----------------------------------------------------------
We should also mention that Labels are supposed to be "light-weight" so that the framework writers don't abuse them. Another point worth mentioning would be namespacing of labels to avoid conflicts. Finally, should we add pointers to the hook modules documentation so as to make the documentation complete?
docs/app-framework-development-guide.md (line 216)
<https://reviews.apache.org/r/37779/#comment151848>
s/StatusUpdate/TaskStatus
docs/app-framework-development-guide.md (line 217)
<https://reviews.apache.org/r/37779/#comment151849>
Can we make it a more explicit? i.e. "module writers use Labels to tag and ..."
docs/app-framework-development-guide.md (line 218)
<https://reviews.apache.org/r/37779/#comment151850>
s/key value/key-value
docs/app-framework-development-guide.md (line 219)
<https://reviews.apache.org/r/37779/#comment151851>
s/decorators/label decorator hooks
- Kapil Arya
On Aug. 25, 2015, 7:49 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 7:49 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added labels documentation to the framework development guide.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md db0181c0b82fded1860ef636747e70d80e3884f2
>
> Diff: https://reviews.apache.org/r/37779/diff/
>
>
> Testing
> -------
>
> Rendered in Marked2
>
>
> Thanks,
>
> Niklas Nielsen
>
>