You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/18 07:38:57 UTC
[GitHub] [kafka] hudeqi opened a new pull request #10716: optimize offset reset strategy and fix lose data when add partition
hudeqi opened a new pull request #10716:
URL: https://github.com/apache/kafka/pull/10716
1. besides `latest` and `earliest`, we also add `nearest`: reset to either latest or earliest depending on the current offset (i.e. this policy won't trigger under the scenario when we see a partition for the first time, without committed offsets; it will only trigger for out-of-range).
2. `latest-on-start`, `earliest-on-start`: reset to either latest or earliest only when we see the partition for the first time without committed offset; when out-of-range default to `none`, i.e. throw exception.
3. an additional `limitTimeStamp` limit used for `latest/earliest/latest-on-start/earliest-on-start`: it means we only reset to latest / earliest if its partition's first record timestamp is smaller / larger than the given `limitTimeStamp` parameter, otherwise, reset to earliest / latest. set the `limitTimeStamp` value to the consumer group started timestamp, when new partitions are added it would reset to `earliest` to avoid losing data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #10716: optimize offset reset strategy and fix lose data when add partition
Posted by GitBox <gi...@apache.org>.
hudeqi commented on pull request #10716:
URL: https://github.com/apache/kafka/pull/10716#issuecomment-843984547
> Also, there are code conflict with `trunk` branch. Please merge `trunk` and push again. Thanks.
Sorry, I didn’t notice that it was developed in an older branch, and it has been submitted based on the latest branch, in addition, I will go through a KIP process recently to illustrate this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi closed pull request #10716: optimize offset reset strategy and fix lose data when add partition
Posted by GitBox <gi...@apache.org>.
hudeqi closed pull request #10716:
URL: https://github.com/apache/kafka/pull/10716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10716: optimize offset reset strategy and fix lose data when add partition
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10716:
URL: https://github.com/apache/kafka/pull/10716#issuecomment-843693354
Also, there are code conflict with `trunk` branch. Please merge `trunk` and push again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org