You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/07/28 05:52:16 UTC
[GitHub] [superset] john-bodley opened a new pull request, #24832: fix: Alembic migration head
john-bodley opened a new pull request, #24832:
URL: https://github.com/apache/superset/pull/24832
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This PR fixes an issue where previously there were two Alembic heads.
#### BEFORE
```
$ FLASK_DEBUG=true superset db heads
e0f6f91c2055 (head)
ee179a490af9 (head)
```
i.e., the history of the two heads were,
```
e0f6f91c2055 <- bf646a0c1501 <- a23c6f8b1280 <- 863adcf72773
ee179a490af9 <- a23c6f8b1280
```
#### AFTER
```
$ FLASK_DEBUG=true superset db heads
ee179a490af9 (head)
```
whereas after the change, i.e, making the down revision of `ee179a490af9` to be `e0f6f91c2055` the history is:
```
ee179a490af9 <- e0f6f91c2055 <- bf646a0c1501 <- a23c6f8b1280 <- 863adcf72773
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24832: fix: Alembic migration head
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24832:
URL: https://github.com/apache/superset/pull/24832#issuecomment-1655070200
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24832?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24832](https://app.codecov.io/gh/apache/superset/pull/24832?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f7bfd63) into [master](https://app.codecov.io/gh/apache/superset/commit/7cd317fe2e56f00ed9c21f9233e92aa19eb62ae7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7cd317f) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head f7bfd63 differs from pull request most recent head a9f2647. Consider uploading reports for the commit a9f2647 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24832 +/- ##
=======================================
Coverage 55.43% 55.43%
=======================================
Files 1903 1903
Lines 74077 74077
Branches 8194 8194
=======================================
Hits 41064 41064
Misses 30892 30892
Partials 2121 2121
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `54.99% <ø> (ø)` | |
| unit | `54.99% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24832: fix: Alembic migration head
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24832:
URL: https://github.com/apache/superset/pull/24832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org