You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Syed Albiz <s....@gmail.com> on 2011/08/19 10:10:32 UTC
Review Request: HIVE-1953: Hive should process comments in CliDriver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1587/
-----------------------------------------------------------
Review request for hive and Yongqiang He.
Summary
-------
skip comments in cliDriver.main() instead of passing down to command processors.
This addresses bug HIVE-1953.
https://issues.apache.org/jira/browse/HIVE-1953
Diffs
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5
Diff: https://reviews.apache.org/r/1587/diff
Testing
-------
tested build, since the test suite goes through driver, adding a query file test case did not work.
Thanks,
Syed
Re: Review Request: HIVE-1953: Hive should process comments in CliDriver
Posted by Syed Albiz <s....@gmail.com>.
> On 2011-08-19 21:08:09, Charles Chen wrote:
> > Currently if you type something like
> >
> > EXPLAIN SELECT "abcd
> > --
> > efgh" as field from invites;
> >
> > the string "abcd\n--\nefgh"with the newlines is accepted--this diff removes the line with the "--" which seems incorrect.
Good point. Similarly, if you try something like EXPLAIN SELECT "abcd;
it fails right now because the cliDriver tokenizes end of statements on semi-colons. The problem here is that cliDriver only partially tokenizes the input before passing it to the Driver which tokenizes things correctly. There is a workaround here which is to add a recognized escape before the --, but that should not be necessary.
- Syed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1587/#review1564
-----------------------------------------------------------
On 2011-08-19 08:10:32, Syed Albiz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1587/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 08:10:32)
>
>
> Review request for hive and Yongqiang He.
>
>
> Summary
> -------
>
> skip comments in cliDriver.main() instead of passing down to command processors.
>
>
> This addresses bug HIVE-1953.
> https://issues.apache.org/jira/browse/HIVE-1953
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5
>
> Diff: https://reviews.apache.org/r/1587/diff
>
>
> Testing
> -------
>
> tested build, since the test suite goes through driver, adding a query file test case did not work.
>
>
> Thanks,
>
> Syed
>
>
Re: Review Request: HIVE-1953: Hive should process comments in CliDriver
Posted by Charles Chen <ch...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1587/#review1564
-----------------------------------------------------------
Currently if you type something like
EXPLAIN SELECT "abcd
--
efgh" as field from invites;
the string "abcd\n--\nefgh"with the newlines is accepted--this diff removes the line with the "--" which seems incorrect.
- Charles
On 2011-08-19 08:10:32, Syed Albiz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1587/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 08:10:32)
>
>
> Review request for hive and Yongqiang He.
>
>
> Summary
> -------
>
> skip comments in cliDriver.main() instead of passing down to command processors.
>
>
> This addresses bug HIVE-1953.
> https://issues.apache.org/jira/browse/HIVE-1953
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5
>
> Diff: https://reviews.apache.org/r/1587/diff
>
>
> Testing
> -------
>
> tested build, since the test suite goes through driver, adding a query file test case did not work.
>
>
> Thanks,
>
> Syed
>
>