You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by riknoll <gi...@git.apache.org> on 2016/02/25 20:32:34 UTC
[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-medic/pull/83
CB-10671 and CB-10699: Android Windows CI fixes for logging and run
This addresses two JIRAs: [CB-10671](https://issues.apache.org/jira/browse/CB-10671) and [CB-10699](https://issues.apache.org/jira/browse/CB-10699). I am submitting this as one PR rather than two because CB-10699 was somewhat blocked on CB-10671.
The CB-10671 fix adds the command `adb kill-server` to medic-kill for Android so as to clear out all of the mysterious "host" emulators that have been cropping up and causing medic-log to fail. Not sure what is causing those entries to appear (and only on Windows), but this seems to get rid of them
The CB-10699 fix tries to uninstall mobilespec before using `cordova run` because the command that `cordova run` uses to install the app sometimes fails if the app will not uninstall. That causes the run step to fail (and every run step thereafter until someone uninstalls the app).
@sarangan12 @dblotsky please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic CB-10699
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit e583d860204fe02f633fcbfde6e5be2f29cc2e55
Author: riknoll <ri...@gmail.com>
Date: 2016-02-25T19:17:52Z
CB-10671: Killing adb server as part of Android medic-kill step
commit cea6c852e39766aa54032e75879b50912f1541ba
Author: riknoll <ri...@gmail.com>
Date: 2016-02-25T19:18:43Z
CB-10699: Attempt to uninstall mobilespec on Android emulator before run
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/83#issuecomment-189059097
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/83#issuecomment-188944883
Also, the Android emulator medic-run code really needs to be refactored, but I didn't want to add that to this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/83#issuecomment-189490637
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org