You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "fuchanghai (via GitHub)" <gi...@apache.org> on 2023/05/11 09:42:23 UTC
[GitHub] [dolphinscheduler] fuchanghai opened a new pull request, #14087: [fix-#14086]The subprocess type node is always in the ready stop state
fuchanghai opened a new pull request, #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087
## Purpose of the pull request
this close:
- #14086
## Brief change log
## Verify this pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1543769939
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14087)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG) [25 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY) [14 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL) [804 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_coverage&view=list) [35.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_duplicated_lines_density&view=list) [5.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1548927271
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14087)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG) [25 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY) [14 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL) [804 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_coverage&view=list) [35.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_duplicated_lines_density&view=list) [5.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1544035027
does it exists in dev branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1544973402
> does it exists in dev branch?
> As far as I know, first of all, the latest code branch structure has changed, and it does not judge whether the sub-process instance is finished before stopping the task in the parent workflow
<img width="877" alt="image" src="https://github.com/apache/dolphinscheduler/assets/33984497/d36571a8-412e-46c0-9575-c01518a5c4c8">
<img width="825" alt="image" src="https://github.com/apache/dolphinscheduler/assets/33984497/b1119744-ab58-4812-b6c8-096874eaf3eb">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1544977536
BTW ，I think we should stop the remote execution of the task first. Then judge the status of the remote task, and finally update the task status in the parent process WDYT@zhongjiajie @ruanwenjun
```
killRemoteSubprocessInstanc()
if(subprocessInstance.getState.typeisFinish){
currentTask.setState(subprocessInstance.getState)
updateCurrentTaskById
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1552347846
> @fuchanghai BTW, next time you can use `close #14086`to let pr close references issue when pr merged
thanks for your reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1548928889
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14087)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG) [25 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY) [14 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL) [804 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_coverage&view=list) [35.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_duplicated_lines_density&view=list) [5.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1543771398
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14087)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG) [25 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY) [14 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL) [804 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14087&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_coverage&view=list) [35.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_duplicated_lines_density&view=list) [5.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14087&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie merged PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1543678499
@ruanwenjun @zhuangchong PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1543763180
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`3.0.6-prepare@565bc97`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 11f2764 differs from pull request most recent head b84d044. Consider uploading reports for the commit b84d044 to get more accurate results
```diff
@@ Coverage Diff @@
## 3.0.6-prepare #14087 +/- ##
================================================
Coverage ? 40.31%
Complexity ? 4641
================================================
Files ? 889
Lines ? 35252
Branches ? 3901
================================================
Hits ? 14212
Misses ? 19651
Partials ? 1389
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1552346016
BTW, next time you can use `close #14086`to let pr close references issue when pr merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #14087: [fix-#14086]The subprocess type node is always in the ready stop state
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #14087:
URL: https://github.com/apache/dolphinscheduler/pull/14087#issuecomment-1548874693
@zhuangchong @zhongjiajie PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org