You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alastair Maw (JIRA)" <ji...@apache.org> on 2007/06/20 18:24:26 UTC

[jira] Resolved: (WICKET-671) InlineFrame page constructor doesn't behave as expected

     [ https://issues.apache.org/jira/browse/WICKET-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw resolved WICKET-671.
---------------------------------

    Resolution: Fixed

Fixed in r549147.

I've removed the IPageMap param from the constructor with the Page instance, because once you've constructed the Page, it's already in a page map, so that constructor didn't make any sense.

I've added an extra constructor that lets you specify PageParameters for the Class-based constructor.

> InlineFrame page constructor doesn't behave as expected
> -------------------------------------------------------
>
>                 Key: WICKET-671
>                 URL: https://issues.apache.org/jira/browse/WICKET-671
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>         Environment: win32 (xp sp2)
> jdk 1.5.0_11
> Tomcat 5.5
>            Reporter: Tom Desmet
>            Assignee: Alastair Maw
>            Priority: Minor
>             Fix For: 1.3.0-beta2
>
>
> Please refer to following mail ...
> http://www.mail-archive.com/wicket-user@lists.sourceforge.net/msg29775.html
> InlineFrame takes 3 constructors:
> 1:	public InlineFrame(final String id, final IPageMap pageMap, final Class c)
> 2:	public InlineFrame(final String id, final IPageMap pageMap, final Page page)
> 3:	public InlineFrame(final String id, final IPageMap pageMap, IPageLink pageLink)
> The idea is to pass PageParameters in the URL of the InlineFrame ... The first can't be used at is creates the page itself.
> The second constructor takes a custom created page. If used, it ignores the pagemap in the Iframe itself (Is this expected behaviour or a bug ???????)
> The third constructor is rather not too straightforward to use.
> If possible  following constructor could do the trick ... public InlineFrame(final String id, final IPageMap pageMap, final Class c, final PageParameters parameters)
> Is it an option to add this new constructor to the InlineFrame? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.