You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/02 08:58:58 UTC
[jira] [Commented] (EAGLE-719) configuration bug in applications
[ https://issues.apache.org/jira/browse/EAGLE-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628266#comment-15628266 ]
ASF GitHub Bot commented on EAGLE-719:
--------------------------------------
GitHub user anyway1021 opened a pull request:
https://github.com/apache/incubator-eagle/pull/598
[EAGLE-719] fix configuration bug in applications
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anyway1021/incubator-eagle EAGLE-719
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/598.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #598
----
commit 56628e5a1a0919b5af06766fa6f657f261199ffb
Author: anyway1021 <mw...@apache.org>
Date: 2016-11-02T03:18:17Z
refactor config class of hadoop-queue-monitoring
commit 33044a5e5d534c9b542545bb841cc009adada6ea
Author: anyway1021 <mw...@apache.org>
Date: 2016-11-02T03:29:40Z
refactor config class of rm-running-job-monitoring
commit eeb0142c620d6e829bed9987d4de7ddb8fd6a32b
Author: anyway1021 <mw...@apache.org>
Date: 2016-11-02T05:47:27Z
refactor config class of topology-health-check
commit f33c1727399d57e9fe0f7b902a9132c252618774
Author: anyway1021 <mw...@apache.org>
Date: 2016-11-02T05:50:17Z
refactor config class of spark-history-job-app
commit c4451850c7894655584e62f5fc52c23f098c06cc
Author: anyway1021 <mw...@apache.org>
Date: 2016-11-02T08:17:05Z
refactor config class of mr-history-job-monitoring
commit 79ae9e223d9b5e5ca3c55edfff5c1cb09d77311d
Author: anyway1021 <mw...@apache.org>
Date: 2016-11-02T08:45:10Z
refactor config class of eagle-jpm-aggregation
----
> configuration bug in applications
> ---------------------------------
>
> Key: EAGLE-719
> URL: https://issues.apache.org/jira/browse/EAGLE-719
> Project: Eagle
> Issue Type: Bug
> Affects Versions: v0.5.0
> Reporter: wujinhu
> Assignee: Michael Wu
> Fix For: v0.5.0
>
>
> In eagle-hadoop-queue/eagle-jpm-mr-history/eagle-jpm-mr-running/eagle-jpm-spark-history/eagle-jpm-aggregation applications, there is an xxxAppConfig class in each application. But they have a static member like manager, which could not initialize twice
> --------------------------------------------------------------------
> public static xxxxConfig getInstance(Config config) {
> if (config != null && manager.config == null) {
> manager.init(config);
> }
> return manager;
> }
> --------------------------------------------------------------------
> But we have many sites in production, and will call method getInstance many times. So it will cause we may get the configuration of first site for remaining sites.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)