You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jjz921024 (via GitHub)" <gi...@apache.org> on 2023/02/28 04:25:13 UTC
[GitHub] [incubator-kvrocks] jjz921024 opened a new pull request, #1286: Fix type command bug
jjz921024 opened a new pull request, #1286:
URL: https://github.com/apache/incubator-kvrocks/pull/1286
1. fix #1278
2. For compatibility with the redis command format, the type command should return simpleString instead of bulkString
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1286: Fix type command bug
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #1286:
URL: https://github.com/apache/incubator-kvrocks/pull/1286#discussion_r1119562518
##########
src/storage/redis_db.cc:
##########
@@ -441,7 +442,12 @@ rocksdb::Status Database::Type(const Slice &user_key, RedisType *type) {
Metadata metadata(kRedisNone, false);
metadata.Decode(value);
- *type = metadata.Type();
+ if (metadata.Expired()) {
+ value.clear();
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1286: Fix outdated result in type command for expired keys
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1286:
URL: https://github.com/apache/incubator-kvrocks/pull/1286#issuecomment-1447767838
@jjz921024 Merged. Thanks for your contribution again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1286: Fix outdated result in type command for expired keys
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1286:
URL: https://github.com/apache/incubator-kvrocks/pull/1286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org