[GitHub] [superset] rusackas commented on pull request #12497: fix: list filters vertical alignment

[GitBox <gi...@apache.org>]

rusackas commented on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759673730


   @michael-s-molina I see another route to fixing this that may make sense. Just have to track down the `styled` instances, since Emotion source maps still aren't working :P
   
   In `Base.ts` add `align-items` to `FilterContainer`, i.e.:
   ```
   export const FilterContainer = styled.div`
     display: inline-flex;
     margin-right: 2em;
     font-size: ${({ theme }) => theme.typography.sizes.s}px;
     align-items: center;
   `;
   ```
   ... and in `FilterTitle` remove the `line-height`, i.e.:
   ```
     font-weight: bold;
     margin: 0 0.4em 0 0;
   `;
   ```
   then you should come out clean without having to nudge any pixels around.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org