[jira] [Commented] (LUCENE-3459) Change ChainedFilter to use FixedBitSet

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896308#comment-13896308 ] 

Uwe Schindler commented on LUCENE-3459:
---------------------------------------

Cool, thanks! I wanted to do this since 4.0 :( Many thanks!

> Change ChainedFilter to use FixedBitSet
> ---------------------------------------
>
>                 Key: LUCENE-3459
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3459
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/other
>    Affects Versions: 3.4, 4.0-ALPHA
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>
> ChainedFilter also uses OpenBitSet(DISI) at the moment. It should also be changed to use FixedBitSet. There are two issues:
> - It exposes sometimes OpenBitSetDISI to it's public API - we should remove those methods like in BooleanFilter and break backwards
> - It allows a XOR operation. This is not yet supported by FixedBitSet, but it's easy to add (like for BooleanFilter). On the other hand, this XOR operation is bogus, as it may mark documents in the BitSet that are deleted, breaking new features like applying Filters down-low (LUCENE-1536). We should remove the XOR operation maybe or force it to use IR.validDocs() (trunk) or IR.isDeleted()



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org