[GitHub] [skywalking] hanahmily opened a new issue, #10472: [Feature] [BanyanDB] Some improvements on TopNAggregation

["hanahmily (via GitHub)" <gi...@apache.org>]

hanahmily opened a new issue, #10472:
URL: https://github.com/apache/skywalking/issues/10472

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   In the process of plugging TopNAggregation into OAP, we found some flaws:
   
   Flow’s identity should be the SeriesID instead of a combination of grouping tags. 
   
   ## Plain aggregation
   The result of a plain aggregation(without grouping) would be like `endpoint1:100, endpoint2:90...`
   
   ## Grouping aggregation
   Grouping operations should output a hierarchical structure. If the group tag is service id, a typical intermediate result is `null:[service1:200...],service1:[endpoint1:100...], service2:[endpoint2:90]...`
   
   `TopNRequest{condition:service_id=service1}` will return the group of `service1`
   
   ## NULL group
   The `null` group collects data points without tags specified in `group_by_tag_names`. The `null` group will help OAP to generate global and sub scopes with a single schema specification.
   
   `TopNRequest{condition:service_id=null(google.protobuf.NullValue)}` will return the group of `null`. 
   
   If you don't want to generate such a group, `TopNAggregation{criteria:service_id!=null}`. `!=` is the `BINARY_OP_NE`. The result would be like this: `service1:[endpoint1:100...], service2:[endpoint2:90]...`
   
   ## Ad-hoc aggregation on all groups
   `TopNRequest{condition:null}` will aggregate on all groups result: `endpoint1(service1):100,endpoint2(service2):90...`
   
   The result is similar to "Plain aggregation", but such intermediate data could support w/o group at the same time.
   
   
   
   
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hanahmily closed issue #10472: [Feature] [BanyanDB] Some improvements on TopNAggregation

["hanahmily (via GitHub)" <gi...@apache.org>]

hanahmily closed issue #10472: [Feature] [BanyanDB] Some improvements on TopNAggregation
URL: https://github.com/apache/skywalking/issues/10472


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org