You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2017/02/24 21:11:36 UTC
[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.
David Knupp has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6144
Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network.
......................................................................
IMPALA-4987: Skip test_rows_availability when testing over a network.
Running this test against a remote cluster introduces network based
timing irregularities that make it difficult to assert passing status.
This is a test that only makes sense when the impalad is local.
Change-Id: I4449d82ccd86fcf22ea96b36618c6de87458ffce
---
M tests/query_test/test_rows_availability.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/6144/1
--
To view, visit http://gerrit.cloudera.org:8080/6144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4449d82ccd86fcf22ea96b36618c6de87458ffce
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network.
......................................................................
Patch Set 1:
I have some questions, but they're about the bug, not this fix, so the questions are on the Jira.
--
To view, visit http://gerrit.cloudera.org:8080/6144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4449d82ccd86fcf22ea96b36618c6de87458ffce
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
seems like a flaky test in general...
http://gerrit.cloudera.org:8080/#/c/6144/1/tests/query_test/test_rows_availability.py
File tests/query_test/test_rows_availability.py:
PS1, Line 24: Similar to concurrent testing,
nit: remove this first part of the sentence; when this gets printed in the terminal it will be out of context
--
To view, visit http://gerrit.cloudera.org:8080/6144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4449d82ccd86fcf22ea96b36618c6de87458ffce
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has abandoned this change.
Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network.
......................................................................
Abandoned
Not the right fix, see JIRA
--
To view, visit http://gerrit.cloudera.org:8080/6144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4449d82ccd86fcf22ea96b36618c6de87458ffce
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network.
......................................................................
Patch Set 1:
Ping?
--
To view, visit http://gerrit.cloudera.org:8080/6144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4449d82ccd86fcf22ea96b36618c6de87458ffce
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network.
......................................................................
Patch Set 1:
This test has actually been broken for some time. See my comments on the JIRA. Let's discuss next week what to do with this.
--
To view, visit http://gerrit.cloudera.org:8080/6144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4449d82ccd86fcf22ea96b36618c6de87458ffce
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No