[GitHub] [druid] jihoonson commented on a change in pull request #6974: sql support for dynamic parameters

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #6974: sql support for dynamic parameters
URL: https://github.com/apache/druid/pull/6974#discussion_r381033771
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/avatica/DruidStatement.java
 ##########
 @@ -350,6 +357,32 @@ public void close()
     }
   }
 
+  private AvaticaParameter createParameter(RelDataTypeField field, RelDataType type)
+  {
+    return new AvaticaParameter(
+        false,
 
 Review comment:
   Would you add a comment on why this is always false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org