You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Yubing Yin (Created) (JIRA)" <ji...@apache.org> on 2012/04/01 10:16:41 UTC
[jira] [Created] (ZOOKEEPER-1439) c sdk: core in log_env for lack
of checking the output argument *pwp* of getpwuid_r
c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r
-----------------------------------------------------------------------------------
Key: ZOOKEEPER-1439
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1439
Project: ZooKeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.3.5, 3.4.3
Environment: linux
Reporter: Yubing Yin
Man of getpwuid_r "return a pointer to a passwd structure, or NULL if the matching entry is not found or an error occurs",
"The getpwnam_r() and getpwuid_r() functions return zero on success.", it means entry may not be found when getpwuid_r success.
In log_env of zookeeper.c in c sdk:
{{if (!getpwuid_r(uid, &pw, buf, sizeof(buf), &pwp)) {}}
{{LOG_INFO(("Client environment:user.home=%s", pw.pw_dir));}}
{{}}}
pwp is not checked to ensure entry is found, pw.pw_dir is not initialized in this case, core happens in LOG_INFO.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1439) c sdk: core in log_env for lack
of checking the output argument *pwp* of getpwuid_r
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1439:
---------------------------------------
Assignee: Yubing Yin
> c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r
> -----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1439
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1439
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Environment: linux
> Reporter: Yubing Yin
> Assignee: Yubing Yin
> Labels: zookeeper
> Attachments: ZOOKEEPER-1439.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Man of getpwuid_r "return a pointer to a passwd structure, or NULL if the matching entry is not found or an error occurs",
> "The getpwnam_r() and getpwuid_r() functions return zero on success.", it means entry may not be found when getpwuid_r success.
> In log_env of zookeeper.c in c sdk:
> {{if (!getpwuid_r(uid, &pw, buf, sizeof(buf), &pwp)) {}}
> {{LOG_INFO(("Client environment:user.home=%s", pw.pw_dir));}}
> {{}}}
> pwp is not checked to ensure entry is found, pw.pw_dir is not initialized in this case, core happens in LOG_INFO.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1439) c sdk: core in log_env for lack
of checking the output argument *pwp* of getpwuid_r
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263573#comment-13263573 ]
Hudson commented on ZOOKEEPER-1439:
-----------------------------------
Integrated in ZooKeeper-trunk #1539 (See [https://builds.apache.org/job/ZooKeeper-trunk/1539/])
ZOOKEEPER-1439. c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r (Yubing Yin via michim) (Revision 1330769)
Result = SUCCESS
michim : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330769
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/c/src/zookeeper.c
> c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r
> -----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1439
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1439
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Environment: linux
> Reporter: Yubing Yin
> Assignee: Yubing Yin
> Labels: zookeeper
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1439.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Man of getpwuid_r "return a pointer to a passwd structure, or NULL if the matching entry is not found or an error occurs",
> "The getpwnam_r() and getpwuid_r() functions return zero on success.", it means entry may not be found when getpwuid_r success.
> In log_env of zookeeper.c in c sdk:
> {{if (!getpwuid_r(uid, &pw, buf, sizeof(buf), &pwp)) {}}
> {{LOG_INFO(("Client environment:user.home=%s", pw.pw_dir));}}
> {{}}}
> pwp is not checked to ensure entry is found, pw.pw_dir is not initialized in this case, core happens in LOG_INFO.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1439) c sdk: core in log_env for lack
of checking the output argument *pwp* of getpwuid_r
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243852#comment-13243852 ]
Hadoop QA commented on ZOOKEEPER-1439:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520815/ZOOKEEPER-1439.patch
against trunk revision 1307644.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//console
This message is automatically generated.
> c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r
> -----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1439
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1439
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Environment: linux
> Reporter: Yubing Yin
> Labels: zookeeper
> Attachments: ZOOKEEPER-1439.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Man of getpwuid_r "return a pointer to a passwd structure, or NULL if the matching entry is not found or an error occurs",
> "The getpwnam_r() and getpwuid_r() functions return zero on success.", it means entry may not be found when getpwuid_r success.
> In log_env of zookeeper.c in c sdk:
> {{if (!getpwuid_r(uid, &pw, buf, sizeof(buf), &pwp)) {}}
> {{LOG_INFO(("Client environment:user.home=%s", pw.pw_dir));}}
> {{}}}
> pwp is not checked to ensure entry is found, pw.pw_dir is not initialized in this case, core happens in LOG_INFO.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1439) c sdk: core in log_env for lack
of checking the output argument *pwp* of getpwuid_r
Posted by "Yubing Yin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yubing Yin updated ZOOKEEPER-1439:
----------------------------------
Attachment: ZOOKEEPER-1439.patch
check pwp to ensure passwd entry is found, after getpwuid_r, fix core in log_env.
> c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r
> -----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1439
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1439
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Environment: linux
> Reporter: Yubing Yin
> Labels: zookeeper
> Attachments: ZOOKEEPER-1439.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Man of getpwuid_r "return a pointer to a passwd structure, or NULL if the matching entry is not found or an error occurs",
> "The getpwnam_r() and getpwuid_r() functions return zero on success.", it means entry may not be found when getpwuid_r success.
> In log_env of zookeeper.c in c sdk:
> {{if (!getpwuid_r(uid, &pw, buf, sizeof(buf), &pwp)) {}}
> {{LOG_INFO(("Client environment:user.home=%s", pw.pw_dir));}}
> {{}}}
> pwp is not checked to ensure entry is found, pw.pw_dir is not initialized in this case, core happens in LOG_INFO.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira