You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/01 19:52:24 UTC
[GitHub] [beam] benWize commented on a change in pull request #15174: [BEAM-12100][BEAM-10379][BEAM-9514][BEAM-12647][BEAM-12099] AssertionError type mismatch from AggregateScanConverter
benWize commented on a change in pull request #15174:
URL: https://github.com/apache/beam/pull/15174#discussion_r700527449
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Group.java
##########
@@ -364,13 +369,29 @@
}
}
+ public interface AggregateCombinerInterface<InputT> {
Review comment:
Changed
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Group.java
##########
@@ -364,13 +369,29 @@
}
}
+ public interface AggregateCombinerInterface<InputT> {
+ <CombineInputT, AccumT, CombineOutputT> AggregateCombinerInterface<InputT> aggregateField(
+ int inputFielId, CombineFn<CombineInputT, AccumT, CombineOutputT> fn, Field outputField);
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org