You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/05/08 05:42:36 UTC

[GitHub] [thrift] Jimexist commented on a diff in pull request #2601: java lib to upgrade to gradle 7 and migrate from `maven` to `maven-publish` plugin

Jimexist commented on code in PR #2601:
URL: https://github.com/apache/thrift/pull/2601#discussion_r867438354


##########
lib/java/Makefile.am:
##########
@@ -26,7 +26,7 @@ all-local:
 		--console=plain
 
 install-exec-hook:
-	$(GRADLE) $(GRADLE_OPTS) install \
+	$(GRADLE) $(GRADLE_OPTS) publishToMavenLocal \

Review Comment:
   i agree with your preference on consistency.
   
   here our hands are tied because `publishToMavenLocal` is provided by the `maven-publish` plugin:
   
   https://docs.gradle.org/current/userguide/publishing_maven.html#publishing_maven:tasks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org