You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Geoffrey Young <ge...@modperlcookbook.org> on 2004/01/23 02:45:11 UTC
Re: cvs commit: modperl-2.0/t/response/TestAPI server_util.pm
> ok t_cmp(qr/server_root_relative.*no .* key/,
> - $@,
> + canonpath($@),
> "Apache::Server::server_root_relative(\$obj, 'conf')");
I don't understand this change. not only does it not make sense to me
(using canonpath on a non-path string?), but according to steve's report,
this test passed on windows ok
> # testing : Apache::Server::server_root_relative($obj, 'conf')
> # expected: (?-xism:server_root_relative.*no .* key)
> # received: method `server_root_relative' invoked by a `Apache::Foo'
> object with
> no `r' key! at C:\Temp\modperl-2.0\t\response/TestAPI/server_util.pm
> line 90.
> ok 14
as for the rest, sorry about that :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/t/response/TestAPI server_util.pm
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>> ok t_cmp(qr/server_root_relative.*no .* key/,
>> - $@,
>> + canonpath($@),
>> "Apache::Server::server_root_relative(\$obj, 'conf')");
>
>
> I don't understand this change. not only does it not make sense to me
> (using canonpath on a non-path string?), but according to steve's report,
> this test passed on windows ok
Hmm, I wondered about it too, but thought that may be canonpath is smart
enough to find just the path ;) But looking at Steve's report this sub-test
wasn't failing at all:
# testing : Apache::Server::server_root_relative($obj, 'conf')
# expected: (?-xism:server_root_relative.*no .* key)
# received: method `server_root_relative' invoked by a `Apache::Foo'
object with
no `r' key! at C:\Temp\modperl-2.0\t\response/TestAPI/server_util.pm
line 90.
ok 14
so I'll revert that change.
>># testing : Apache::Server::server_root_relative($obj, 'conf')
>># expected: (?-xism:server_root_relative.*no .* key)
>># received: method `server_root_relative' invoked by a `Apache::Foo'
>>object with
>> no `r' key! at C:\Temp\modperl-2.0\t\response/TestAPI/server_util.pm
>>line 90.
>>ok 14
>
>
> as for the rest, sorry about that :)
Not much to be sorry about ;) I never remember that on other OS's Apache calls
return a different path ;) Thanks to Randy and Steve we get those
unintentional bugs of ours to get fixed.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org