You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Tobias Weingartner <we...@tepid.org> on 2014/01/17 11:20:07 UTC

Review Request 17042: Add a web interface to the zookeeper instance.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17042/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

Add a web interface to the zookeeper instance.


Diffs
-----

  examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 

Diff: https://reviews.apache.org/r/17042/diff/


Testing
-------

$ vagrant up zookeeper

# point web browser at 192.168.33.2:8080


Thanks,

Tobias Weingartner


Re: Review Request 17042: Add a web interface to the zookeeper instance.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17042/#review32198
-----------------------------------------------------------



examples/vagrant/provision-zookeeper.sh
<https://reviews.apache.org/r/17042/#comment60913>

    you can get a few seconds of speedup if you collapse into a single apt-get invocation
    
    apt-get -y install zookeeper git python-django python-zookeeper



examples/vagrant/provision-zookeeper.sh
<https://reviews.apache.org/r/17042/#comment60914>

    Can simplify to
    
    pushd ~vagrant
      sudo -H -u vagrant git clone https://github.com/phunt/zookeeper_dashboard
    popd
    


- Kevin Sweeney


On Jan. 17, 2014, 11:21 a.m., Tobias Weingartner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17042/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 11:21 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a web interface to the zookeeper instance.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 
> 
> Diff: https://reviews.apache.org/r/17042/diff/
> 
> 
> Testing
> -------
> 
> $ vagrant up zookeeper
> 
> # point web browser at 192.168.33.2:8080
> 
> 
> Thanks,
> 
> Tobias Weingartner
> 
>


Re: Review Request 17042: Add a web interface to the zookeeper instance.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17042/#review38366
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Feb. 9, 2014, 10:40 p.m., Tobias Weingartner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17042/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2014, 10:40 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a web interface to the zookeeper instance.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 
> 
> Diff: https://reviews.apache.org/r/17042/diff/
> 
> 
> Testing
> -------
> 
> $ vagrant up zookeeper
> 
> # point web browser at 192.168.33.2:8080
> 
> 
> Thanks,
> 
> Tobias Weingartner
> 
>


Re: Review Request 17042: Add a web interface to the zookeeper instance.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17042/#review40915
-----------------------------------------------------------


I propose we discard this review in the interest of keeping the vagrant image simpler.  While a useful debugging tool, zkCli.sh should be able to stand in for this.

- Bill Farner


On Feb. 10, 2014, 6:40 a.m., Tobias Weingartner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17042/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 6:40 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a web interface to the zookeeper instance.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 
> 
> Diff: https://reviews.apache.org/r/17042/diff/
> 
> 
> Testing
> -------
> 
> $ vagrant up zookeeper
> 
> # point web browser at 192.168.33.2:8080
> 
> 
> Thanks,
> 
> Tobias Weingartner
> 
>


Re: Review Request 17042: Add a web interface to the zookeeper instance.

Posted by Tobias Weingartner <we...@tepid.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17042/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 6:40 a.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

Add a web interface to the zookeeper instance.


Diffs (updated)
-----

  examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 

Diff: https://reviews.apache.org/r/17042/diff/


Testing
-------

$ vagrant up zookeeper

# point web browser at 192.168.33.2:8080


Thanks,

Tobias Weingartner


Re: Review Request 17042: Add a web interface to the zookeeper instance.

Posted by Tobias Weingartner <we...@tepid.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17042/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 7:21 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

Add a web interface to the zookeeper instance.


Diffs
-----

  examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 

Diff: https://reviews.apache.org/r/17042/diff/


Testing
-------

$ vagrant up zookeeper

# point web browser at 192.168.33.2:8080


Thanks,

Tobias Weingartner


Re: Review Request 17042: Add a web interface to the zookeeper instance.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17042/#review32154
-----------------------------------------------------------


Mind putting kevints on the People line?  That way it will land in his inbox.

- Bill Farner


On Jan. 17, 2014, 10:20 a.m., Tobias Weingartner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17042/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 10:20 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a web interface to the zookeeper instance.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 
> 
> Diff: https://reviews.apache.org/r/17042/diff/
> 
> 
> Testing
> -------
> 
> $ vagrant up zookeeper
> 
> # point web browser at 192.168.33.2:8080
> 
> 
> Thanks,
> 
> Tobias Weingartner
> 
>