You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "deepakpanda93 (via GitHub)" <gi...@apache.org> on 2025/10/16 05:46:40 UTC
[PR] feat: Add script to build and push Docker images [hudi]
deepakpanda93 opened a new pull request, #14101:
URL: https://github.com/apache/hudi/pull/14101
### Describe the issue this Pull Request addresses
This PR introduces a script to streamline the process of building and pushing Docker images.
### Summary and Changelog
This PR adds shell scripts that:
- Builds a Docker image using a specified Dockerfile.
- Pushes the tagged image(s) to a specified Docker registry.
### Impact
None
### Risk Level
none
### Documentation Update
Script includes inline comments and usage help. No updates needed on the Hudi website.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3412519726
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
}, {
"hash" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206",
"triggerID" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c28dab0d5759db4c2c123cfe0867f911c2f46d03 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3409266470
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 132b6570e47c2a2421b8d4ce9fb9191ac687dc5d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3411741690
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 132b6570e47c2a2421b8d4ce9fb9191ac687dc5d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189)
* 10d0d787ba4bc340257f2e7d38ec11d28a76aca5 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3411736731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 132b6570e47c2a2421b8d4ce9fb9191ac687dc5d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189)
* 10d0d787ba4bc340257f2e7d38ec11d28a76aca5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on code in PR #14101:
URL: https://github.com/apache/hudi/pull/14101#discussion_r2476556370
##########
docker/push_docker_images.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+TAGS=("latest" "4e6ebba26cb097cb26cddcbb3958d99dda476320")
+
+IMAGE_NAMES=(
+ "apachehudi/hudi-hadoop_3.3.4-base"
+ "apachehudi/hudi-hadoop_3.3.4-namenode"
+ "apachehudi/hudi-hadoop_3.3.4-datanode"
+ "apachehudi/hudi-hadoop_3.3.4-history"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3-sparkbase_3.5.3"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3-sparkmaster_3.5.3"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3-sparkworker_3.5.3"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3-sparkadhoc_3.5.3"
Review Comment:
@xushiyan
Merged the build and push script into one and tested too. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3455626753
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
}, {
"hash" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206",
"triggerID" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"triggerType" : "PUSH"
}, {
"hash" : "11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9379",
"triggerID" : "11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c28dab0d5759db4c2c123cfe0867f911c2f46d03 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206)
* 11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9379)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 closed pull request #14101: feat: Add script to build and push Docker images
URL: https://github.com/apache/hudi/pull/14101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3409543252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 132b6570e47c2a2421b8d4ce9fb9191ac687dc5d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-5166533644
Closing in favour of #19489.
`docker/build_docker_images.sh` was substantially rewritten on master after this PR was opened, and this PR replaces that file with a copy forked from the older version. Rebasing would therefore have reverted the named version flags, the `pom.xml`-derived version tag, the Java 11/17 base selection and the multi-arch support that landed since. #19489 is a fresh port of the same idea onto the current script instead.
Both review comments here are addressed there:
- merged into a single script rather than a second one, with `--publish <true|false>` defaulting to false
- the header describes what the script does and that publishing is for maintainers, reachable via `--help`
- the flag is named `--publish` and takes an explicit value, as suggested
Thanks @xushiyan for the review, and @yihua for the nudge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3412055785
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
}, {
"hash" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206",
"triggerID" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 132b6570e47c2a2421b8d4ce9fb9191ac687dc5d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189)
* 10d0d787ba4bc340257f2e7d38ec11d28a76aca5 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204)
* c28dab0d5759db4c2c123cfe0867f911c2f46d03 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #14101:
URL: https://github.com/apache/hudi/pull/14101#discussion_r2437089379
##########
docker/push_docker_images.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+TAGS=("latest" "4e6ebba26cb097cb26cddcbb3958d99dda476320")
Review Comment:
need to add comment indicating this sha is the same as the other one in `build_docker_images.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3409272503
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 132b6570e47c2a2421b8d4ce9fb9191ac687dc5d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3411746546
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
}, {
"hash" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 132b6570e47c2a2421b8d4ce9fb9191ac687dc5d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189)
* 10d0d787ba4bc340257f2e7d38ec11d28a76aca5 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204)
* c28dab0d5759db4c2c123cfe0867f911c2f46d03 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #14101:
URL: https://github.com/apache/hudi/pull/14101#discussion_r2440446409
##########
docker/push_docker_images.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+TAGS=("latest" "4e6ebba26cb097cb26cddcbb3958d99dda476320")
+
+IMAGE_NAMES=(
+ "apachehudi/hudi-hadoop_3.3.4-base"
+ "apachehudi/hudi-hadoop_3.3.4-namenode"
+ "apachehudi/hudi-hadoop_3.3.4-datanode"
+ "apachehudi/hudi-hadoop_3.3.4-history"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3-sparkbase_3.5.3"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3-sparkmaster_3.5.3"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3-sparkworker_3.5.3"
+ "apachehudi/hudi-hadoop_3.3.4-hive_3.1.3-sparkadhoc_3.5.3"
Review Comment:
these images and the tag version are repeated vars from build docker script. it's hard to maintain between different script. please merge this script with the build docker script, adding an option to support pushing images (default false)
##########
docker/push_docker_images.sh:
##########
@@ -0,0 +1,79 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+TAGS=("latest" "4e6ebba26cb097cb26cddcbb3958d99dda476320")
Review Comment:
need to add comment indicating this sha is the same as the other one in `build_docker_images.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3456144027
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
}, {
"hash" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206",
"triggerID" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"triggerType" : "PUSH"
}, {
"hash" : "11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9379",
"triggerID" : "11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9379)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3455616102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
}, {
"hash" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206",
"triggerID" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"triggerType" : "PUSH"
}, {
"hash" : "11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c28dab0d5759db4c2c123cfe0867f911c2f46d03 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206)
* 11e074b5cdd3792dd1de7c3beca8c30e3c1c75cb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #14101:
URL: https://github.com/apache/hudi/pull/14101#discussion_r2481960345
##########
docker/build_and_push_docker_images.sh:
##########
@@ -0,0 +1,185 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+set -e
+
+# -----------------------------------------------------------------------------
+# build_and_push_docker_images.sh
Review Comment:
add more descriptions here, describe what this script does, and who should use it (as in pushing is for hudi maintainers, not every users)
##########
docker/build_and_push_docker_images.sh:
##########
@@ -0,0 +1,185 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+set -e
+
+# -----------------------------------------------------------------------------
+# build_and_push_docker_images.sh
+#
+# Usage:
+# ./build_and_push_docker_images.sh [push_flag]
+#
+# Example:
+# ./build_and_push_docker_images.sh # build only
+# ./build_and_push_docker_images.sh true # build and push
Review Comment:
```suggestion
# ./build_and_push_docker_images.sh --publish true # build and publish
```
rename to call it publish? and use named arg to be explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add script to build and push Docker images [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14101:
URL: https://github.com/apache/hudi/pull/14101#issuecomment-3412204002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9189",
"triggerID" : "132b6570e47c2a2421b8d4ce9fb9191ac687dc5d",
"triggerType" : "PUSH"
}, {
"hash" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204",
"triggerID" : "10d0d787ba4bc340257f2e7d38ec11d28a76aca5",
"triggerType" : "PUSH"
}, {
"hash" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206",
"triggerID" : "c28dab0d5759db4c2c123cfe0867f911c2f46d03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10d0d787ba4bc340257f2e7d38ec11d28a76aca5 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9204)
* c28dab0d5759db4c2c123cfe0867f911c2f46d03 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9206)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org