[jira] [Updated] (HADOOP-9658) SnappyCodec#checkNativeCodeLoaded may unexpectedly fail when native code is not loaded

["Tsuyoshi Ozawa (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsuyoshi Ozawa updated HADOOP-9658:
-----------------------------------
          Resolution: Fixed
       Fix Version/s: 2.7.1
    Target Version/s: 2.7.1
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

Committed this to trunk, branch-2, and branch-2.7. Thanks [~zjshen] for your contribution!

> SnappyCodec#checkNativeCodeLoaded may unexpectedly fail when native code is not loaded
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9658
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9658
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>             Fix For: 2.7.1
>
>         Attachments: HADOOP-9658.1.patch
>
>
> {code}
>   public static void checkNativeCodeLoaded() {
>       if (!NativeCodeLoader.buildSupportsSnappy()) {
>         throw new RuntimeException("native snappy library not available: " +
>             "this version of libhadoop was built without " +
>             "snappy support.");
>       }
>       if (!SnappyCompressor.isNativeCodeLoaded()) {
>         throw new RuntimeException("native snappy library not available: " +
>             "SnappyCompressor has not been loaded.");
>       }
>       if (!SnappyDecompressor.isNativeCodeLoaded()) {
>         throw new RuntimeException("native snappy library not available: " +
>             "SnappyDecompressor has not been loaded.");
>       }
>   }
> {code}
> buildSupportsSnappy is native method. If the native code is not loaded, the method will be missing. Therefore, whether the native code is loaded or not, the first runtime exception will not be thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)