You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2022/01/01 19:41:40 UTC
[GitHub] [tika] dk2k opened a new pull request #471: initial results of static analysis
dk2k opened a new pull request #471:
URL: https://github.com/apache/tika/pull/471
Analysis was performed with Findbugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #471: initial results of static analysis
Posted by GitBox <gi...@apache.org>.
tballison commented on pull request #471:
URL: https://github.com/apache/tika/pull/471#issuecomment-1005647809
Thank you for opening this. I don't want to add more work for you, but this PR is too big for me to handle in one go.
Can we break it up in PRs either by module or by severity? Or better yet, add a findbugs maven plugin to our project so that this isn't a fix-once-and-hope-for-the-best-in-the-future kind of thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] dk2k commented on pull request #471: initial results of static analysis
Posted by GitBox <gi...@apache.org>.
dk2k commented on pull request #471:
URL: https://github.com/apache/tika/pull/471#issuecomment-1006460510
I expect some opposition from other members of the team: Findbugs isn't maintained any longer and maven reports a warning about the structure of pom.xml when I add a section for findbugs. As for separate change lists for modules, I think it's feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] dk2k closed pull request #471: initial results of static analysis
Posted by GitBox <gi...@apache.org>.
dk2k closed pull request #471:
URL: https://github.com/apache/tika/pull/471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] dk2k commented on pull request #471: initial results of static analysis
Posted by GitBox <gi...@apache.org>.
dk2k commented on pull request #471:
URL: https://github.com/apache/tika/pull/471#issuecomment-1006531828
I will check sonarqube
Meanwhile, PR for module CORE https://github.com/apache/tika/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #471: initial results of static analysis
Posted by GitBox <gi...@apache.org>.
tballison commented on pull request #471:
URL: https://github.com/apache/tika/pull/471#issuecomment-1006510307
I used to use Findbugs on other projects and admire many of its features. After you opened this and I made my comment, I went digging a bit and found what you point out: no longer supported. I'd like to make many of the changes you found, but I'd also like to make this more of a lasting contribution somehow. Maybe sonarqube, e.g. https://sonarcloud.io/project/overview?id=apache_any23 ???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org