You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/06 16:21:44 UTC
[GitHub] [pinot] dongxiaoman opened a new issue #7716: [Refactor] Avoid Scala in pinot-kafka-xxx project
dongxiaoman opened a new issue #7716:
URL: https://github.com/apache/pinot/issues/7716
Right now the only places scala are needed are in `pinot-kafka-xxx` which forces a scala version of `2.10` and `2.11` respectively.
It introduces conflict at runtime when our own plugin loads another version of scala (e.g., `2.12`)
Based on code reading, the reason `kafka_2.10`/`kafka_2.11` are needed is because of `KafkaDataServerStartable`. That `StreamDataServerStartable` is not needed for our team but Kafka consumer is definitely needed.
One solution would be to move the `KafkaDataServerStartable` into a separated Plugin Jar, so we can avoid loading them. This way if my team needs scala I can be free to load whatever version we need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kkrugler commented on issue #7716: [Refactor] Avoid Scala in pinot-kafka-xxx project
Posted by GitBox <gi...@apache.org>.
kkrugler commented on issue #7716:
URL: https://github.com/apache/pinot/issues/7716#issuecomment-963556599
I think the `StreamDataServerStartable` implementations are only needed for tests and quickstart (aka demo), so part of this cleanup could be to move that interface out of `pinot-spi`, and into a new subproject that bundled all of the different stream data server jars - this could be depended on by `tools` and (elsewhere, as needed) test scope. Hmm, feels a bit messy though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org